[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-13 Thread GitBox
kwin commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818567126 bq. I think we should as a first step expose that as an option. That is where we don't agree. I don't see a good use case for that (even if

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-13 Thread GitBox
kwin commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818556608 @karlpauls `dropContent` is only an internal flag and can imho be renamed to reflect that this is only about not referencing it in the feature

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
kwin commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817738628 > but to write the content package no matter what seems unnecessary. I still fail to see use cases, where the transformed content package is not

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
kwin commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817707012 @karlpauls I asked in