[GitHub] [sling-org-apache-sling-junit-core] bdelacretaz commented on pull request #5: Sling 9915 support for sling annotations test runner

bdelacretaz commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-733602302 > Even with Java 8, my version fails. The system properties are null... The main issue was that the test was mistakenly run by `maven-surefire-plu

[GitHub] [sling-org-apache-sling-junit-core] bdelacretaz commented on pull request #5: Sling 9915 support for sling annotations test runner

bdelacretaz commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732835451 > One option can delete the tests I made which were useful for my development efforts... That wouldn't be good! But modifying the tests so that th

[GitHub] [sling-org-apache-sling-junit-core] bdelacretaz commented on pull request #5: Sling 9915 support for sling annotations test runner

bdelacretaz commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-732048957 > Tests for the @TestReference(String filter) are run via SlingAnnotationsTestRunner [0] IIUC this means those tests are not executed automaticall