rombert commented on issue #6: Allow caching of virtual resources
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-411333845
All good now, thanks for seeing this through @AndreasWurm !
rombert commented on issue #6: Allow caching of virtual resources
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-410682232
@AndreasWurm , yes, it makes sense since public methods were added to the
exported/API class Configuration.
---
rombert commented on issue #6: Allow caching of virtual resources
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-410269715
@AndreasWurm the build now fails due to baseline checks
```
[INFO] Comparing bundle org.apache.sling.dynamic-includ
rombert commented on issue #6: Allow caching of virtual resources
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-409552732
I get compilation errors when building this module with your patch on top.
```
[ERROR] Failed to execute goal
org.
rombert commented on issue #6: Allow caching of virtual resources
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-409280544
Looks good to me, thanks for the updates @AndreasWurm . One final request -
I applied #5 as i finished its review first. Can
rombert commented on issue #6: Allow caching of virtual resources
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/6#issuecomment-407727401
@AndreasWurm - can you please open a SLING Jira issue so be can better track
this? The issue should be referenced in the com
