stefanseifert merged PR #31:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
stefanseifert commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1764497387
thanks, i will merge it!
(the jenkins CI tests on windows are flaky, but that is not related to this
PR, we have to take care of this separately)
sonarcloud[bot] commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1764457971
Kudos, SonarCloud Quality Gate passed! [` proposal. do you have to apply
this annotation on test class level, or is it alternatively also possible to
apply
stefanseifert commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1759683521
i like the `@AutoConfig(MyService.class)` proposal. do you have to apply
this annotation on test class level, or is it alternatively also possible to
a
adamcin commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1759672317
> can you come up with a small code snipped how this would look in the unit
test as example how you envision this?
@stefanseifert Like this:
```
stefanseifert commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1759283538
> > 2. but it think it's very important that this new way of defining OSGi
configurations also works together with the current approach of OSGi mock usi
stefanseifert commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1759279603
> > i'm not so fond of having to place and explicit
@retention(RetentionPolicy.RUNTIME) to the annotation class, though - changing
the production code
stefanseifert commented on code in PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#discussion_r1356562016
##
junit5/pom.xml:
##
@@ -47,6 +47,25 @@
tests
test
+
+org.apache.sling
+
stefanseifert commented on code in PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#discussion_r1356540400
##
core/src/main/java/org/apache/sling/testing/mock/osgi/config/annotations/ConfigType.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to
adamcin commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1758809026
> 2. but it think it's very important that this new way of defining OSGi
configurations also works together with the current approach of OSGi mock using
regi
sonarcloud[bot] commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1758764292
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa
adamcin commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1758743454
> 1. you propose to use this new features as lightweight alternative to the
SCR metadata-based approach, making it easy to construct OSGI annotations
filled
adamcin commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1758297579
@stefanseifert in reply to:
> 4. you added a couple of methods to `OsgiContextImpl`. this class is the
primary API class developers interact with when writ
adamcin commented on code in PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#discussion_r1355415498
##
junit5/pom.xml:
##
@@ -47,6 +47,25 @@
tests
test
+
+org.apache.sling
+
stefanseifert commented on code in PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#discussion_r1354569056
##
core/src/main/java/org/apache/sling/testing/mock/osgi/config/package-info.java:
##
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apach
sonarcloud[bot] commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1757303111
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa
sonarcloud[bot] commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1757228224
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa
stefanseifert commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1757216063
the goal `javadoc:javadoc` fails on this PR due to malformed javadocs in
some places - please check and fix
(we should include this in our jenkins c
sonarcloud[bot] commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1756215255
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa
sonarcloud[bot] commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1756134992
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa
adamcin commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1756120569
> From a code perspective, this looks really clean and I at least can't spot
any obvious bugs.
>
> The challenge I'm having here is grokking the featur
kwin commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1753490229
@klcodanr Got it now. I was reading too much in it I guess, sorry for that.
--
This is an automated message from the Apache Git Service.
To respond to the mess
klcodanr commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1753461616
@kwin I believe we are agreeing on the request.
I am not suggesting in any way that this contribution is for an audience
outside of all consumers of a
kwin commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1753441976
Regarding
> assuming your audience isn't already familiar with the feature
There is no such thing as “your" or “my” audience when it comes to Sling.
sonarcloud[bot] commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1747973868
Kudos, SonarCloud Quality Gate passed! [