Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-20 Thread Bertrand Delacretaz
On Tue, Nov 20, 2018 at 4:56 PM Robert Munteanu wrote: > ...If I get my ITs executed on `mvn install` it's perfect. If I need to run > something else, well, ... not so much :-).. +1 to keeping ITs in the modules that they test, with about 467 Sling modules at last count, I think it's important fo

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-20 Thread Robert Munteanu
Hi Andrei, Thanks for commenting and sorry for taking so long to reply. On Fri, 2018-11-09 at 15:22 +0100, Andrei Dulvac wrote: > +1 for moving the tests to the code as well. > > However... I would be careful to check what is packaged in the > `tests` > artifact produced by the build. > Should

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-09 Thread Andrei Dulvac
+1 for moving the tests to the code as well. However... I would be careful to check what is packaged in the `tests` artifact produced by the build. Should we package the test transient dependencies? Otherwise it will be complicated to run multiple test artifacts under one build, with different tes

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-09 Thread Robert Munteanu
On Fri, 2018-11-09 at 13:50 +0100, Georg Henzler wrote: > +1 to move the tests closer to the code. > > Regarding the path src/test/it (mentioned in the wiki page): > Shouldn't > we rather stick with src/test/java for both ITs and regular tests > and > just use the standard name conventions as co

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-09 Thread Georg Henzler
+1 to move the tests closer to the code. Regarding the path src/test/it (mentioned in the wiki page): Shouldn't we rather stick with src/test/java for both ITs and regular tests and just use the standard name conventions as configured by default for plugins surefire/failsafe maven plugins, tha

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-09 Thread Robert Munteanu
On Thu, 2018-11-08 at 17:07 +0100, Oliver Lietz wrote: > I wrote a proposal about how this could look like in terms of > > results > > > > https://cwiki.apache.org/confluence/display/SLING/Moving+integration+tests+c > > loser+to+the+code+they+test > > > > I purposefully avoided looking into imple

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-08 Thread Oliver Lietz
On Wednesday 07 November 2018 17:29:01 Robert Munteanu wrote: > Hi, Hi Robert, > We discussed a couple of time that it would be desireable to move tests > closer to the code they're testing. > > I wrote a proposal about how this could look like in terms of results > > https://cwiki.apache.org/c

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-08 Thread Robert Munteanu
On Thu, 2018-11-08 at 14:37 +0100, Bertrand Delacretaz wrote: > Hi, > > On Wed, Nov 7, 2018 at 5:29 PM Robert Munteanu > wrote: > > ... > > https://cwiki.apache.org/confluence/display/SLING/Moving+integration+tests+closer+to+the+code+they+test > > ... > > I think it's a great idea to have tests

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-08 Thread Bertrand Delacretaz
Hi, On Wed, Nov 7, 2018 at 5:29 PM Robert Munteanu wrote: > ... > https://cwiki.apache.org/confluence/display/SLING/Moving+integration+tests+closer+to+the+code+they+test > ... I think it's a great idea to have tests closer to their code, while also running a large test suite against a "complet

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-08 Thread Robert Munteanu
Hi Valentin, On Wed, 2018-11-07 at 21:05 +0100, Valentin Olteanu wrote: > I just wanted to drop [1] which can give you some guidelines on where > to > put the tests. It shows the drawbacks of having the tests in > src/test/ and > it states that the preferred way is to create a separate project. >

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-07 Thread Valentin Olteanu
On Wed, Nov 7, 2018 at 5:29 PM Robert Munteanu wrote: > Hi, > > We discussed a couple of time that it would be desireable to move tests > closer to the code they're testing. > > I wrote a proposal about how this could look like in terms of results > > > https://cwiki.apache.org/confluence/display

[PROPOSAL] Moving integration tests closer to the code they test

2018-11-07 Thread Robert Munteanu
Hi, We discussed a couple of time that it would be desireable to move tests closer to the code they're testing. I wrote a proposal about how this could look like in terms of results https://cwiki.apache.org/confluence/display/SLING/Moving+integration+tests+closer+to+the+code+they+test I purpose