[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557148#comment-17557148 ] Oliver Lietz commented on SLING-11398: -- No, not at all. Go on. > handle serviceloa

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557143#comment-17557143 ] Eric Norman commented on SLING-11398: - [~olli] Updated the comment at: [14d248e|htt

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557124#comment-17557124 ] Oliver Lietz commented on SLING-11398: -- {quote}What is unclear about the comments i

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557109#comment-17557109 ] Eric Norman commented on SLING-11398: - [~olli]  {quote}You mentioned above HCs as yo

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557103#comment-17557103 ] Eric Norman commented on SLING-11398: - [~olli]  {quote}Sure, but it's not obvious to

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557102#comment-17557102 ] Oliver Lietz commented on SLING-11398: -- [~enorman], You mentioned above HCs as your

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557099#comment-17557099 ] Oliver Lietz commented on SLING-11398: -- {quote}Well, the test is specifically for t

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557092#comment-17557092 ] Eric Norman commented on SLING-11398: - [~olli]  {quote}The IT breaks when using Groo

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557089#comment-17557089 ] Eric Norman commented on SLING-11398: - [~olli]  {quote}bq. Felix HC comes with its o

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557088#comment-17557088 ] Oliver Lietz commented on SLING-11398: -- [~enorman], The IT breaks when using Groovy

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-21 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557083#comment-17557083 ] Oliver Lietz commented on SLING-11398: -- [~enorman], Felix HC comes with its own [{

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-20 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556555#comment-17556555 ] Eric Norman commented on SLING-11398: - [~olli] My use case was for running scripts a

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-20 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556539#comment-17556539 ] Oliver Lietz commented on SLING-11398: -- See also https://sling.apache.org/document

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-20 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556538#comment-17556538 ] Oliver Lietz commented on SLING-11398: -- [~enorman], I hadn't a chance to checkout a

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-20 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556445#comment-17556445 ] Eric Norman commented on SLING-11398: - [~olli] Can you please clarify if your commen

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-20 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556333#comment-17556333 ] Oliver Lietz commented on SLING-11398: -- Note: The scripting support for Groovy in S

[jira] [Commented] (SLING-11398) handle serviceloader ScriptEngineFactory defined in a fragment bundle

2022-06-19 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556123#comment-17556123 ] Eric Norman commented on SLING-11398: - PR #18 has the proposed changes for review an