rombert merged pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ashokmca07 commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084433876
Hi @rombert or @kwin Could you please release a new version after the PR
merge? will update the dependencies instead of using SNAPSHOT versions.
sonarcloud[bot] removed a comment on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084406966
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084426106
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
ashokmca07 commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084425658
> dependency to biz.acute:bndlib
@kwin dependency has been removed.
--
This is an automated message from the Apache Git Service.
To
sonarcloud[bot] removed a comment on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084404034
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084406966
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
ashokmca07 commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#discussion_r839457612
##
File path: pom.xml
##
@@ -22,38 +22,47 @@
4.0.0
org.apache.sling
-sling
-16
-
ashokmca07 commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#discussion_r839457782
##
File path: pom.xml
##
@@ -22,38 +22,47 @@
4.0.0
org.apache.sling
-sling
-16
-
ashokmca07 commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#discussion_r839456951
##
File path: pom.xml
##
@@ -22,38 +22,37 @@
4.0.0
org.apache.sling
-sling
-16
-
sonarcloud[bot] removed a comment on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084384691
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084404034
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
kwin commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#discussion_r839444963
##
File path: pom.xml
##
@@ -22,38 +22,37 @@
4.0.0
org.apache.sling
-sling
-16
-
+
kwin commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#discussion_r839441622
##
File path: pom.xml
##
@@ -22,38 +22,47 @@
4.0.0
org.apache.sling
-sling
-16
-
+
kwin commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#discussion_r839437196
##
File path: pom.xml
##
@@ -22,38 +22,47 @@
4.0.0
org.apache.sling
-sling
-16
-
+
sonarcloud[bot] commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084384691
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] removed a comment on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084155969
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
ashokmca07 commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084383945
> Thanks for the PR @ashokmca07 ! I see the build completes successfully
with Java 11 now, which is great. One thing which still needs attention
ashokmca07 commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#discussion_r839430169
##
File path: pom.xml
##
@@ -22,38 +22,37 @@
4.0.0
org.apache.sling
-sling
-16
-
rombert commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1#issuecomment-1084324294
Thanks for the quick turnaround @ashokmca07 , I have merged this PR.
--
This is an automated message from the Apache Git Service.
To respond to
rombert merged pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ashokmca07 commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1#issuecomment-1084315951
Thanks for letting me know @rombert about
https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1#pullrequestreview-927248093
sonarcloud[bot] removed a comment on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1#issuecomment-1084163468
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1#issuecomment-1084314253
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
ashokmca07 commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1#discussion_r839373386
##
File path: pom.xml
##
@@ -22,26 +22,31 @@
4.0.0
org.apache.sling
-sling
-16
-
ashokmca07 commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1#discussion_r839373256
##
File path: README.md
##
@@ -1,8 +1,8 @@
[![Apache
rombert commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#discussion_r839367511
##
File path: pom.xml
##
@@ -22,38 +22,37 @@
4.0.0
org.apache.sling
-sling
-16
-
rombert commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#discussion_r839367511
##
File path: pom.xml
##
@@ -22,38 +22,37 @@
4.0.0
org.apache.sling
-sling
-16
-
rombert commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1#discussion_r839365463
##
File path: README.md
##
@@ -1,8 +1,8 @@
[![Apache
rombert commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1#issuecomment-1084302258
Sorry, this was for the API PR, please ignore for now.
--
This is an automated message from the Apache Git Service.
To respond to the message,
sonarcloud[bot] commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1#issuecomment-1084163468
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-cache-api/pull/1#issuecomment-1084155969
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
kwin closed pull request #23:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
kwin commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-983508994
Superseded by #25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
paul-bjorkstrand commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-982882186
@ashokmca07 & @kwin , I opened #25 to eliminate the need for
`sun.misc.Unsafe`. If that can get merged first, then the test doesn't need to
be
paul-bjorkstrand commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-982858597
I have an idea for a better way, that avoids the use of `Unsafe` entirely.
I'll have a PR today with those changes.
--
This is an automated
sonarcloud[bot] commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-756012211
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=23=false=BUG)
sonarcloud[bot] removed a comment on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-756007516
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-756007516
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=23=false=BUG)
sonarcloud[bot] removed a comment on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-755916391
Kudos, SonarCloud Quality Gate passed!
rombert commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-755996183
I wonder if we can't reflectively load the Unsafe class for tests or remove
its usage, as the root cause is a compiler error.
ashokmca07 commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-755993133
https://blogs.oracle.com/javamagazine/the-unsafe-class-unsafe-at-any-speed
Java 11: `sun.misc.Unsafe` classes are no longer support.
ashokmca07 commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-755988107
I will remove the profile here since I have raised one more pull request to
fix on `sling-parent`
kwin commented on a change in pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#discussion_r553185978
##
File path: pom.xml
##
@@ -241,5 +242,23 @@
5.2.9.RELEASE
test
+
+
ashokmca07 commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-755923913
let me add these profiles directly on `sling-parent`
This is an automated message
ashokmca07 commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-755918584
Default properties are configured as java8
`
8
`
but SonarCloud compiling via jdk11 `Java version: 11.0.9, vendor: Oracle
sonarcloud[bot] removed a comment on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-755441503
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-755916391
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=23=false=BUG)
kwin commented on a change in pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#discussion_r552839825
##
File path: pom.xml
##
@@ -241,5 +242,18 @@
5.2.9.RELEASE
test
+
+
sonarcloud[bot] commented on pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#issuecomment-755441503
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-models-impl=23=false=BUG)
kwin commented on a change in pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#discussion_r552818302
##
File path: pom.xml
##
@@ -241,5 +258,10 @@
5.2.9.RELEASE
test
+
+
kwin commented on a change in pull request #23:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#discussion_r552802100
##
File path: pom.xml
##
@@ -103,6 +104,22 @@
false
+
+
ashokmca07 opened a new pull request #23:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/23
- javax.annotation-api: added maven dependency since it's not available from
jdk11
- maven-surefire-plugin: removed warnings from maven build logs
-
[
https://issues.apache.org/jira/browse/SLING-9074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz closed SLING-9074.
---
> Fix Jenkins build issues related to SonarCl
[
https://issues.apache.org/jira/browse/SLING-9074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-9074.
-
Resolution: Fixed
Error reporting improved, let's see...
> Fix Jenkins build issues rela
properties - anything that you would be changing
normally in the Jenkins UI ( JDK that will be used, or number of jobs to retain
) will be applied after the pipeline is executed once. I think that your change
should be picked up immediately, since it is code executed at runtime.
> Fix Jenkins bu
/86148295ff5c66e4842091b81daa89b6451ae703
[2] https://cwiki.apache.org/confluence/display/SLING/Sling+Jenkins+Setup
> Fix Jenkins build issues related to SonarCloud
> --
>
> Key: SLING-9074
> URL: https://is
is going on TBH, but
if you need anything from me just ping me.
> Fix Jenkins build issues related to SonarCloud
> --
>
> Key: SLING-9074
> URL: https://issues.apache.org/jira/browse/SLING-9074
>
with the sling-org-apache-sling-launchpad-testing
build.
> Fix Jenkins build issues related to SonarCloud
> --
>
> Key: SLING-9074
> URL: https://issues.apache.org/jira/browse/SLING-9074
>
/main/java/org/apache/sling/commons/messaging/mail/internal/SimpleMailService.java'
[ERROR] Parse error at line 169 column 42: Lambda expressions are allowed only
at source level 1.8 or above
{code}
> Fix Jenkins build issues related to SonarCl
[
https://issues.apache.org/jira/browse/SLING-9074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-9074:
Fix Version/s: (was: Commons Messaging Mail 1.0.0)
> Fix Jenkins build issues rela
[
https://issues.apache.org/jira/browse/SLING-9074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-9074:
Component/s: (was: Commons)
Build and Source Control
> Fix Jenkins bu
[
https://issues.apache.org/jira/browse/SLING-9074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-9074:
Summary: Fix Jenkins build issues related to SonarCloud (was: Onboard
Commons Messaging Mail
Hi Andy,
On Wed, 2017-02-15 at 15:04 -0800, Andreas Schaefer Sr. wrote:
> Hi Stefan
>
> Thanks. I am using the git repo and forgot that it can leave spurious
> directories around
> (git clean -df fix it then).
>
> That said the block in the regular (non -DskipTests) build remains.
>
> [INFO]
Hi Stefan
Thanks. I am using the git repo and forgot that it can leave spurious
directories around
(git clean -df fix it then).
That said the block in the regular (non -DskipTests) build remains.
[INFO]
[INFO] Building
>2) Rat Check fails for Apache Sling Testing Mocks Modules Reactor 1-
>SNAPSHOT
...
>[INFO] 2 resources included (use -debug for more details)
>[DEBUG] - included pom.xml
>[DEBUG] - included sling-mock-jackrabbit/org.apache.sling.testing.sling-
>mock-jackrabbit.iml
i think this happens only
Today I wanted to build Sling from trunk. I ran into two issues
1) Preparing test on Apache Sling Dynamic Class Loader Support 1.3.9-SNAPSHOT
is blocked for ever on:
[main] INFO org.ops4j.pax.exam.spi.DefaultExamSystem - Pax Exam System
(Version: 4.9.1) created.
[main] INFO
67 matches
Mail list logo
