[
https://issues.apache.org/jira/browse/SLING-12417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-12417.
-
> [Compiled Scripts] Add healthcheck for loading capabilit
[
https://issues.apache.org/jira/browse/SLING-12417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh resolved SLING-12417.
---
Resolution: Fixed
> [Compiled Scripts] Add healthcheck for loading capabilit
[
https://issues.apache.org/jira/browse/SLING-12417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12417:
--
Fix Version/s: Servlets Resolver 2.11.6
> [Compiled Scripts] Add healthcheck for loading capabilit
joerghoh merged PR #50:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
joerghoh commented on code in PR #50:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/50#discussion_r1860704391
##
src/main/java/org/apache/sling/servlets/resolver/internal/bundle/BundledScriptTracker.java:
##
@@ -136,10 +154,23 @@ protected void de
joerghoh commented on PR #50:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/50#issuecomment-2498334469
@raducotescu ok, got it.
Assuming your case, wouldn't it be reasonable to assume that version 2.0 and
version 1.0 have a large overlap of bundled scri
raducotescu commented on code in PR #50:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/50#discussion_r1856586287
##
src/main/java/org/apache/sling/servlets/resolver/internal/bundle/BundledScriptTracker.java:
##
@@ -756,4 +805,16 @@ private Set
re
raducotescu commented on PR #50:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/50#issuecomment-2497983321
> @raducotescu wrote:
>> would it make sense to add support for multiple versions of the same
bundle
> I don't know, what you mean with that in
joerghoh commented on PR #50:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/50#issuecomment-2494118002
@raducotescu wrote:
> would it make sense to add support for multiple versions of the same bundle
I don't know, what you mean with that in this
raducotescu commented on code in PR #50:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/50#discussion_r1853000481
##
src/main/java/org/apache/sling/servlets/resolver/internal/bundle/BundledScriptTracker.java:
##
@@ -557,6 +589,23 @@ public void rem
the provided scripts is exposed by a bundle using capabilities. These
capabilities are loaded async, and it's unclear when the loading process is
completed (a log statement was added with SLING-12461).
We should have a health check which can be configured with the symbolic names
of all exp
provided scripts is exposed by a bundle using capabilities. These
capabilities are loaded async, and it's unclear when the loading process is
completed (a log statement was added with SLING-12461).
We should have a health check which can be configured with the symbolic names
of all expected bu
[
https://issues.apache.org/jira/browse/SLING-12417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh reassigned SLING-12417:
-
Assignee: Joerg Hoh
> [Compiled Scripts] Add healthcheck for loading capabilit
bundle using capabilities. These capabilities are loaded async,
and it's unclear when the loading process is completed (a log statement was
added with SLING-12461).
We should have a healthcheck which can be configured with the symbolic names of
all expected bundles to contain such precom
ing capabilities
> ---
>
> Key: SLING-12417
> URL: https://issues.apache.org/jira/browse/SLING-12417
> Project: Sling
> Issue Type: Improvement
> Components: Scripti
Joerg Hoh created SLING-12417:
-
Summary: [Compiled Scripts] Add healthcheck for loading
capabilities
Key: SLING-12417
URL: https://issues.apache.org/jira/browse/SLING-12417
Project: Sling
Issue
kwin merged PR #59:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
sonarcloud[bot] commented on PR #59:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/59#issuecomment-1754699143
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/p
sonarcloud[bot] commented on PR #59:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/59#issuecomment-1753475080
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/p
cziegeler commented on PR #59:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/59#issuecomment-1738461612
@kwin the PR looks ok to me, we have the open question about a bundle not
export api into a region which we can ignore for now and get to it if it
becomes important
could add allow to add metadata like
"api-export-capabilities":"true" to a bundle. Otherwise I would just remove the
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
[
https://issues.apache.org/jira/browse/SLING-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu closed SLING-10808.
> Generate scripting capabilities from Jackrabbit FileVault content packa
[
https://issues.apache.org/jira/browse/SLING-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu closed SLING-10811.
> Mark unresolved required capabilities as optio
-scriptingbundle-maven-plugin/commit/0d45342].
> Generate scripting capabilities from Jackrabbit FileVault content packages
> --
>
> Key: SLING-10808
> URL: https://issues.apache.org/jira/bro
raducotescu merged pull request #8:
URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
sonarcloud[bot] commented on pull request #8:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#issuecomment-921800999
SonarCloud Quality Gate failed.  {
fileProcessor.processExtendsFile(resourceType,
entry, providedCapabilities, requiredCapabilities);
} else if
(Constants.REQUIRES_FILE.equals(file.toString
@@ public Capabilities getCapabilities(@NotNull Path
resourceTypeDirectory) {
fileProcessor.processExtendsFile(resourceType,
entry, providedCapabilities, requiredCapabilities);
} else if
(Constants.REQUIRES_FILE.equals(file.toString
kwin commented on a change in pull request #8:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#discussion_r710261328
##
File path: pom.xml
##
@@ -236,6 +236,18 @@
1.40.0
compile
+
+org.apache.jack
kwin commented on a change in pull request #8:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#discussion_r710261328
##
File path: pom.xml
##
@@ -236,6 +236,18 @@
1.40.0
compile
+
+org.apache.jack
sonarcloud[bot] commented on pull request #8:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#issuecomment-920978915
SonarCloud Quality Gate failed. 
+66,8 @@ public Capabilities getCapabilities(@NotNull Path
resourceTypeDirectory) {
fileProcessor.processExtendsFile(resourceType,
entry, providedCapabilities, requiredCapabilities);
} else if
(Constants.REQUIRES_FILE.equals(file.toString
raducotescu commented on a change in pull request #8:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#discussion_r709886560
##
File path:
src/main/java/org/apache/sling/scriptingbundle/plugin/processor/filevault/VaultContentXmlReader.java
##
@@ -0,0 +
+66,8 @@ public Capabilities getCapabilities(@NotNull Path
resourceTypeDirectory) {
fileProcessor.processExtendsFile(resourceType,
entry, providedCapabilities, requiredCapabilities);
} else if
(Constants.REQUIRES_FILE.equals(file.toString
raducotescu commented on a change in pull request #8:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#discussion_r709869399
##
File path:
src/main/java/org/apache/sling/scriptingbundle/plugin/processor/Constants.java
##
@@ -53,6 +53,10 @@ private Cons
sonarcloud[bot] commented on pull request #8:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#issuecomment-920179073
SonarCloud Quality Gate failed.  {
fileProcessor.processExtendsFile(resourceType,
entry, providedCapabilities, requiredCapabilities);
} else if
(Constants.REQUIRES_FILE.equals(file.toString
raducotescu commented on pull request #8:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#issuecomment-919201767
> Are you expecting the FileVault Docview files inside the scripts folder
for a bundle? That way they would end up in the bundle unnecessarily. Would it
raducotescu commented on a change in pull request #8:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#discussion_r708320022
##
File path:
src/main/java/org/apache/sling/scriptingbundle/plugin/processor/filevault/VaultContentXmlReader.java
##
@@ -0,0 +
+66,8 @@ public Capabilities getCapabilities(@NotNull Path
resourceTypeDirectory) {
fileProcessor.processExtendsFile(resourceType,
entry, providedCapabilities, requiredCapabilities);
} else if
(Constants.REQUIRES_FILE.equals(file.toString
kwin commented on pull request #8:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#issuecomment-919094245
Are you expecting the FileVault Docview files inside the scripts folder for
a bundle? That way they would end up in the bundle unnecessarily. Would it make
se
ants.SLING_RESOURCE_SUPER_TYPE);
Review comment:
You need to consider namespaces defined in the xml and check against the
fully qualified element name. Docview XMLs might use other url prefixes than
"sling"
##
File path:
src/main/java/org/apache/sling/scripti
sonarcloud[bot] commented on pull request #8:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8#issuecomment-919004604
SonarCloud Quality Gate failed. ![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadg
Radu Cotescu created SLING-10811:
Summary: Mark unresolved required capabilities as optional
Key: SLING-10811
URL: https://issues.apache.org/jira/browse/SLING-10811
Project: Sling
Issue Type
raducotescu opened a new pull request #8:
URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/8
* added support to generate provided and required capabilities based on
FileVault content packages by reading the `.content.xml` files
--
This is an automated message from
Radu Cotescu created SLING-10808:
Summary: Generate scripting capabilities from Jackrabbit FileVault
content packages
Key: SLING-10808
URL: https://issues.apache.org/jira/browse/SLING-10808
Project
kwin merged pull request #3:
URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
sonarcloud[bot] commented on pull request #3:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-893473330
SonarCloud Quality Gate failed. ![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadg
sonarcloud[bot] removed a comment on pull request #3:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-892792652
SonarCloud Quality Gate failed. ![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Quality
sonarcloud[bot] removed a comment on pull request #3:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-889873719
SonarCloud Quality Gate failed. ![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Quality
sonarcloud[bot] commented on pull request #3:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-892792652
SonarCloud Quality Gate failed. ![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadg
sonarcloud[bot] commented on pull request #3:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-892792652
SonarCloud Quality Gate failed. ![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadg
sonarcloud[bot] removed a comment on pull request #3:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-889873719
SonarCloud Quality Gate failed. ![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Quality
the versioned
capabilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please
versioned
capabilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact
versioned
capabilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact
kwin edited a comment on pull request #3:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-891693924
I am fine with using another directive/attribute. The main question is if
the stricter parsing is ok (so that the position of the attribute/directive
d
kwin commented on pull request #3:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-891693924
I am fine with using another directive/attribute. The main question is if
the stricter parsing is ok (so that the position of the attribute/version does
not m
karlpauls commented on pull request #3:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-891691474
@kwin, wouldn't it be better to just allow extends to be
resolution=optional? So, we would still parse it as a header but just add all
attributes and dir
sonarcloud[bot] commented on pull request #3:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-889873719
SonarCloud Quality Gate failed. ![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadg
kwin opened a new pull request #3:
URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3
"extends"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
[0] section of each partial file.
[0] -
https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator#provider-bundles
> Provide a BND plugin that can automatically generate the requirements and
> capabil
Radu Cotescu created SLING-10658:
Summary: Provide a BND plugin that can automatically generate the
requirements and capabilities for provider bundles
Key: SLING-10658
URL: https://issues.apache.org/jira/browse
[
https://issues.apache.org/jira/browse/SLING-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu closed SLING-9998.
---
> Remove required internal OSGi capabilit
egration. I vaguely
remember asking infra about it at some point but I can't find the Jira
issue/email right now.
> Add missing OSGi capabilities
> -
>
> Key: SLING-9997
> URL: https://issues.apache.org/jira/browse/
OSGi capabilities is a "standard" summary which helps finding
similar issues...
Works for me! We might also use jira labels for such things, or create a
"master" issue about this and link others to it.
> Add missing OSGi capabilities
> -
>
=org.apache.sling.engine.SlingRequestProcessor,\
osgi.service;objectClass=javax.servlet.ServletContext
{noformat}
> Add missing OSGi capabilities
> -
>
> Key: SLING-9997
> URL: https://issues.apache.org/jira/browse/SLING-9997
>
[
https://issues.apache.org/jira/browse/SLING-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-9997:
Summary: Add missing OSGi capabilities (was: Add missing OSGi
SlingRequestProcessor and
n Jira?
> Add missing OSGi SlingRequestProcessor and ServletContext capabilities
> --
>
> Key: SLING-9997
> URL: https://issues.apache.org/jira/browse/SLING-9997
> Proj
SGi capabilities
> --
>
> Key: SLING-9998
> URL: https://issues.apache.org/jira/browse/SLING-9998
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>
[
https://issues.apache.org/jira/browse/SLING-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-9998.
-
Resolution: Done
> Remove required internal OSGi capabilit
[
https://issues.apache.org/jira/browse/SLING-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-9998:
Fix Version/s: Servlets Resolver 2.7.14
> Remove required internal OSGi capabilit
[
https://issues.apache.org/jira/browse/SLING-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-9998:
Summary: Remove required internal OSGi capabilities (was: Add missing OSGi
capabilities
[
https://issues.apache.org/jira/browse/SLING-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-9997:
---
Summary: Add missing OSGi SlingRequestProcessor and ServletContext
capabilities
ious, that's [commit
dcf1f30|https://github.com/apache/sling-org-apache-sling-engine/commit/dcf1f300910ab2c16780e7f55b7229164b6bc778]
> Add missing OSGi SlingRequestProcessor and ServletContext
[
https://issues.apache.org/jira/browse/SLING-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-9997.
-
Resolution: Done
> Add missing OSGi capabilit
[
https://issues.apache.org/jira/browse/SLING-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-9997:
Fix Version/s: Engine 2.7.4
> Add missing OSGi capabilit
[
https://issues.apache.org/jira/browse/SLING-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-9997:
Affects Version/s: (was: Engine 2.7.2)
> Add missing OSGi capabilit
1 - 100 of 246 matches
Mail list logo
