Re: Consistently failing ITs

Reviewing the setup I came to the conclusion that we should actually retire that module. See "[VOTE] Deprecate org.apache.launchpad.test- services-war" on dev@sling and https://issues.apache.org/jira/browse/SLING-9351 . Thanks, Robert On Mon, 2020-04-06 at 16:10 +0200, Konrad Windszus wrote: > T

Re: Consistently failing ITs

That is because testing war (https://github.com/apache/sling-org-apache-sling-launchpad-testing-war/blob/master/src/main/provisioning/model.txt ) does not deploy anything apart fr

Re: Consistently failing ITs

FWIW, the same tests fail in launchpad-testing-war as well [1]. So that is probably not the right fix to do. [1]: https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing-war/job/master/68/console On Wed, 2020-04-01 at 16:06 +0200, Robert Munteanu wrote: > Sounds like

Re: Consistently failing ITs

Sounds like a reasonable explanation to me. Thanks, Robert On Wed, 2020-04-01 at 16:03 +0200, Konrad Windszus wrote: > What I assume happened was the following: > > The WAR was incorrectly treated as bundle and therefore installed by > the OSGi Installer for bundles. > As consequence the accordi

Re: Consistently failing ITs

What I assume happened was the following: The WAR was incorrectly treated as bundle and therefore installed by the OSGi Installer for bundles. As consequence the according servlets were registered. > On 1. Apr 2020, at 16:00, Robert Munteanu wrote: > > I agree in principle. But why did these

Re: Consistently failing ITs

I agree in principle. But why did these not fail until now? Thanks, Robert On Wed, 2020-04-01 at 15:39 +0200, Konrad Windszus wrote: > IMHO there are some test which should only be executed from > https://github.com/apache/sling-org-apache-sling-launchpad-testing-war > , namely > https://github

Re: Consistently failing ITs

IMHO there are some test which should only be executed from https://github.com/apache/sling-org-apache-sling-launchpad-testing-war, namely https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/blob/bd0c0c270b73e582dc5dfa3ed25231c951d0c98d/src/main/java/org/apache/sling/laun

Re: Consistently failing ITs

Done with https://github.com/apache/sling-org-apache-sling-launchpad-test-bundles/commit/43956dd07234ddc3263ce29c5b7c3f7198ad4caf . That leaves us with 2 remaining issues: [

Re: Consistently failing ITs

On Wed, 2020-04-01 at 15:16 +0200, Konrad Windszus wrote: > The test fails with the following output > > [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time > elapsed: 0.292 s <<< FAILURE! - in > org.apache.sling.launchpad.webapp.integrationtest.installer.ServerSid > eInstallerTest > [E

Re: Consistently failing ITs

The test fails with the following output [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.292 s <<< FAILURE! - in org.apache.sling.launchpad.webapp.integrationtest.installer.ServerSideInstallerTest [ERROR] noUntransformedResources(org.apache.sling.launchpad.webapp.integ

Re: Consistently failing ITs

I can do releases on JCR Provider, File Provider and Package Feature but first someone should investigate org.apache.sling.launchpad.webapp.integrationtest.installer.ServerSideInstallerTest.noUntransformedResources I unfortunately won't have time to look into that this week. Konrad > On 1. Apr

Re: Consistently failing ITs

On Wed, 2020-04-01 at 13:25 +0200, Robert Munteanu wrote: > On Wed, 2020-04-01 at 13:16 +0200, Bertrand Delacretaz wrote: > > Hi, > > > > On Wed, Apr 1, 2020 at 12:36 PM Robert Munteanu > > > > wrote: > > > ... I noticed that our launchpad tests are in poor shape... > > > > It looks like https:/

Re: Consistently failing ITs

On Wed, 2020-04-01 at 13:16 +0200, Bertrand Delacretaz wrote: > Hi, > > On Wed, Apr 1, 2020 at 12:36 PM Robert Munteanu > wrote: > > ... I noticed that our launchpad tests are in poor shape... > > It looks like https://issues.apache.org/jira/browse/SLING-9319 will > fix a number of those, and th

Re: Consistently failing ITs

Hi, On Wed, Apr 1, 2020 at 12:36 PM Robert Munteanu wrote: >... I noticed that our launchpad tests are in poor shape... It looks like https://issues.apache.org/jira/browse/SLING-9319 will fix a number of those, and this means the org.apache.sling/org.apache.sling.installer.provider.jcr/3.2.0 rel

Consistently failing ITs

Hi, I noticed that our launchpad tests are in poor shape. They consistently fail on Jenkins and locally, making in hard to evaluate the impact of 'risky' changes, like Oak upgrades. For instance, in [1] I can see the following groups of changes: - installer org.apache.sling.launchpad.webapp.