Hi Carlos,
On Tue, Jun 23, 2020 at 1:35 AM Carlos Munoz wrote:
> ...Bertrand, I confirmed the approach works two ways...
Thank you! I have added a javadoc comment mentioning this, in commit 1536b10
-Bertrand
Bertrand, I confirmed the approach works two ways:
1. By embedding the dependency directly in the bundle using the
directive.
2. By using the directive with the following content:
@org.apache.sling.servlets.post-*.jar!/org/apache/sling/servlets/post/impl/**
This includes the full private
On Mon, Jun 22, 2020 at 2:36 PM Carlos Munoz wrote:
> ...My suggestion would be to add this
> solution you just proposed to the javadocs of those deprecated classes...
Good idea - let's wait until you confirm that it works for you and
this sounds like a plan!
-Bertrand
Thanks Bertrand. I will try this out, but I believe in theory it should
work for us.
And no worries about the contribution, at least it let me get more familiar
with some of Sling's internals :)
I'll still reiterate that the deprecation on the Post classes threw me off
because it meant our code
Hi Carlos,
On Thu, Jun 18, 2020 at 3:59 AM Carlos Munoz wrote:
...
> https://github.com/apache/sling-org-apache-sling-servlets-post/pull/5
...
Thank you for this!
In the meantime I think there's a simpler way for you to use the
existing
Hi Bertrand, I did just that (moved the code up to the public package) and
submitted a PR for it:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/5
Let me know what you think.
Carlos
On Thu, Jun 11, 2020 at 8:24 AM Bertrand Delacretaz
wrote:
> Hi,
>
> On Thu, Jun 11, 2020
Hi,
On Thu, Jun 11, 2020 at 1:51 PM Carlos Munoz wrote:
> ...I might take it upon myself to code up said public replacement (my first
> Sling contribution!) which avoids using the jcr apis...
That would be fantastic! As mentioned, moving the code from the
servlets.post.impl.operations to the
Thanks Bertrand, that makes sense.
So, to recap it's fine to use the deprecated API.
I would recommend getting rid of the deprecation in all honesty as it
might be sending the wrong message to developers, especially since there is
no effective replacement.
I might take it upon myself to code
Hi,
On Thu, Jun 11, 2020 at 3:06 AM Carlos Munoz wrote:
> ...We are currently using class
> org.apache.sling.servlets.post.AbstractPostOperation but it is deprecated
> (seems to have been for a while)...
As per https://issues.apache.org/jira/browse/SLING-6722 the reason for
deprecation is that
Hi all,
We are currently using class
org.apache.sling.servlets.post.AbstractPostOperation but it is deprecated
(seems to have been for a while). We found non-deprecated class
org.apache.sling.servlets.post.impl.operations.AbstractPostOperation which
seems to be almost the same (save for a thrown
10 matches
Mail list logo
