Re: Failing Installer test (was Re: ConfigAdmin support in Launchpad...)

2010-08-19 Thread Carsten Ziegeler
Justin Edelson wrote > I think I identified the JCRInstall problem. See > https://issues.apache.org/jira/browse/JCR-2720 > Ah, yes, this could be the problem. > Working around this in the test shouldn't be hard, but it's a nasty bug. We could also revert back to the older sling testing module wi

Re: Failing Installer test (was Re: ConfigAdmin support in Launchpad...)

2010-08-19 Thread Carsten Ziegeler
Justin Edelson wrote > On Wed, Aug 18, 2010 at 1:38 PM, Justin Edelson > wrote: >> I fixed the ConfigInstallTest failure in the osgi.it module. Not sure if >> this is the one which has been "failing for a long time". Great! Thanks Justin. >> >> The problem is in the waitForConfiguration method

Re: Failing Installer test (was Re: ConfigAdmin support in Launchpad...)

2010-08-18 Thread Justin Edelson
I think I identified the JCRInstall problem. See https://issues.apache.org/jira/browse/JCR-2720 Working around this in the test shouldn't be hard, but it's a nasty bug. Justin On Wed, Aug 18, 2010 at 2:35 PM, Justin Edelson wrote: > On Wed, Aug 18, 2010 at 1:38 PM, Justin Edelson > wrote: >>

Re: Failing Installer test (was Re: ConfigAdmin support in Launchpad...)

2010-08-18 Thread Justin Edelson
On Wed, Aug 18, 2010 at 1:38 PM, Justin Edelson wrote: > I fixed the ConfigInstallTest failure in the osgi.it module. Not sure if > this is the one which has been "failing for a long time". > > The problem is in the waitForConfiguration method of OsgiInstallerTestBase. > > The logic was: > if (res

Failing Installer test (was Re: ConfigAdmin support in Launchpad...)

2010-08-18 Thread Justin Edelson
I fixed the ConfigInstallTest failure in the osgi.it module. Not sure if this is the one which has been "failing for a long time". The problem is in the waitForConfiguration method of OsgiInstallerTestBase. The logic was: if (result != null ||!shouldBePresent) { break; } but this fails to take