Re: Feedback required for providing a new MetricOptions in MetricService API (SLING-5420)

2016-01-11 Thread Bertrand Delacretaz
Hi Chetan, On Mon, Jan 11, 2016 at 12:04 PM, Chetan Mehrotra wrote: > ...if no other suggestion > would withdraw this issue and cut the first release of the bundle > tomorrow morning.. I agree with Ian's points, having a first release with less features sounds better to me, in order to get feedb

Re: Feedback required for providing a new MetricOptions in MetricService API (SLING-5420)

2016-01-11 Thread Chetan Mehrotra
On Mon, Jan 11, 2016 at 3:32 PM, Ian Boston wrote: > I think you should keep it simple and not add this functionality into the > Metrics API involved in instrumentation. okie makes sense now. If required we can capture such "meta" information via OSGi config as its not the concern of the instrume

Re: Feedback required for providing a new MetricOptions in MetricService API (SLING-5420)

2016-01-11 Thread Ian Boston
Hi, I think you should keep it simple and not add this functionality into the Metrics API involved in instrumentation. If you need control over metadata associated with metrics or the behaviour of an implementation of a metrics that should (imo) be done in a separate API, optionally implemented by

Feedback required for providing a new MetricOptions in MetricService API (SLING-5420)

2016-01-11 Thread Chetan Mehrotra
Hi Team, Given that 1.0 release is not yet cut I was thinking about some future requirements and how they might impact the API. Based on that I have opened SLING-5420 where a new MetricOptions class is proposed to control how certain aspect of Metric collection/reporting are controlled. Kindly ha