Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

2017-01-16 Thread Robert Munteanu
On Fri, 2017-01-13 at 12:05 -0800, Andreas Schaefer Sr. wrote: > This is not limited to API. > > There is the issue with impl-vlt that uses the Activator to obtain > the Plugin Logger. > IntelliJ for example is not OSGi based and this caused me some > headaches (and still does). > > But there is

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

2017-01-13 Thread Andreas Schaefer Sr.
This is not limited to API. There is the issue with impl-vlt that uses the Activator to obtain the Plugin Logger. IntelliJ for example is not OSGi based and this caused me some headaches (and still does). But there is also code that would be common to IDEs but it is embedded into Eclipse

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

2017-01-13 Thread Konrad Windszus
For the API part I will make sure to not introduce any Eclipse specific dependencies. For the null-check annotations we should probably then rely on JSR-305 annotations (https://sling.apache.org/documentation/development/jsr-305.html). Konrad > On 13 Jan 2017, at 17:10, Andreas Schaefer Sr.

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

2017-01-13 Thread Andreas Schaefer Sr.
If tooling is every going to support other IDEs than Eclipse then you should not add more Eclipse dependencies to non Eclipse modules. Cheers - Andy Schaefer > On Jan 10, 2017, at 3:24 AM, Robert Munteanu wrote: > > On Mon, 2017-01-09 at 09:24 -0500, Konrad Windszus

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

2017-01-10 Thread Robert Munteanu
On Mon, 2017-01-09 at 09:24 -0500, Konrad Windszus wrote: > > On 9 Jan 2017, at 06:00, Robert Munteanu > > wrote: > > > > Hi Konrad, > > > > On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote: > > > This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=4340 > >

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

2017-01-09 Thread Konrad Windszus
> On 9 Jan 2017, at 06:00, Robert Munteanu wrote: > > Hi Konrad, > > On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote: >> This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=434033. >> Any suggestions which annotation types to use in the Eclipse IDE for >>

Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

2017-01-09 Thread Robert Munteanu
Hi Konrad, On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote: > This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=434033. > Any suggestions which annotation types to use in the Eclipse IDE for > null checks? > Or would it be fine to build the Sling IDE with target 1.8? I am not