Re: OSGi Installer Core Release

2017-02-16 Thread Karl Pauls
Great! I'll cut the release today and btw. good catch wrt the retry issue- without your insistence I wouldn't have spotted that the test didn't test the right thing and subsequently, not found the remaining bugs in the patch! regards, Karl On Thu, Feb 16, 2017 at 11:47 AM, Konrad Windszus wrot

Re: OSGi Installer Core Release

2017-02-16 Thread Konrad Windszus
I just committed the fix for SLING-6392. Can you please set the Fix Version of SLING-5457 (I assume to Installer Core 3.8.4)? Nothing blocking a release now from my side. Thanks for taking care, Konrad > On 16 Feb 2017, at 00:31, Karl Pauls wrote: > > Hi Konrad, > > SLING-6392 looks good. If y

Re: OSGi Installer Core Release

2017-02-15 Thread Karl Pauls
Hi Konrad, SLING-6392 looks good. If you commit it (and assuming you agree with SLING-5457 for now) I would go ahead and cut a release. regards, Karl On Wed, Feb 15, 2017 at 3:25 PM, Karl Pauls wrote: > I'll have a look. > > regards, > > Karl > > On Wed, Feb 15, 2017 at 2:45 PM, Konrad Windszu

Re: OSGi Installer Core Release

2017-02-15 Thread Karl Pauls
I'll have a look. regards, Karl On Wed, Feb 15, 2017 at 2:45 PM, Konrad Windszus wrote: > Hi, > since obviously the next release of the OSGi Installer is imminent > (https://issues.apache.org/jira/browse/SLING-5457?focusedCommentId=15867820&page=com.atlassian.jira.plugin.system.issuetabpanels:

OSGi Installer Core Release

2017-02-15 Thread Konrad Windszus
Hi, since obviously the next release of the OSGi Installer is imminent (https://issues.apache.org/jira/browse/SLING-5457?focusedCommentId=15867820&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15867820) could someone please look at the proposed patch in https://is