Re: Parameterizing Sling Feature model extensions

2018-11-09 Thread Carsten Ziegeler
lgtm THanks Carsten Am 09.11.2018 um 17:37 schrieb David Bosschaert: Hi all, Looking at how this is now done for the analyse-features mojo [1], I would propose to follow a similar pattern for the extension handlers/post processors. We can add an optional handlerConfiguration tag in the aggrega

Re: Parameterizing Sling Feature model extensions

2018-11-09 Thread David Bosschaert
Hi all, Looking at how this is now done for the analyse-features mojo [1], I would propose to follow a similar pattern for the extension handlers/post processors. We can add an optional handlerConfiguration tag in the aggregate-features task that holds configuration for specific handlers. As the k

Re: Parameterizing Sling Feature model extensions

2018-11-07 Thread Carsten Ziegeler
Rethinking my own proposal from below, I think it's mixing the concern of how to configure it in a maven plugin with how to handle it in the respective component. So instead of doing the filtering in the component, I guess it makes more sense to let the caller do this. Or in other words instead

Re: Parameterizing Sling Feature model extensions

2018-11-07 Thread Carsten Ziegeler
Hi, we're currently discussing a similar problem for SLING-8078 with Simo. So maybe we can have a similar approach here (at least for how this is configured in the plugin configuration). I'm fine to extend the HandlerContext to provide configuration properties. I guess we should plan for cla

Parameterizing Sling Feature model extensions

2018-11-07 Thread David Bosschaert
Hi all, I would like to be able to send some parameters to my Feature Model PostProcessHandler when its run from the slingfeature-maven-plugin. The handlers in the org.apache.sling.feature.extension.apiregions component generate files for the runtime component. I would like to be able to configu