Re: Feedback on the current ResourceAccessSecurity API

2013-04-04 Thread Bertrand Delacretaz
Hi Mike, On Wed, Apr 3, 2013 at 9:18 PM, Mike Müller mike...@mysign.ch wrote: ...I commited a last shot of the SPI API. The Sling API hasn't changed anymore. I think the API is now complete and after all the discussions enough mature I have added/tweaked javadocs on the

RE: Feedback on the current ResourceAccessSecurity API

2013-04-04 Thread Mike Müller
AM To: dev@sling.apache.org Subject: Re: Feedback on the current ResourceAccessSecurity API Hi Mike, On Wed, Apr 3, 2013 at 9:18 PM, Mike Müller mike...@mysign.ch wrote: ...I commited a last shot of the SPI API. The Sling API hasn't changed anymore. I think the API is now complete

Re: Feedback on the current ResourceAccessSecurity API

2013-04-03 Thread Bertrand Delacretaz
On Wed, Apr 3, 2013 at 12:17 PM, Carsten Ziegeler cziege...@apache.org wrote: ...I would like to cut some releases shortly, especially a new API, resourceresolver and jcr resource release... Do we really want to include Mike's new APIs in a release already? I'd feel more comfortable if we can

Re: Feedback on the current ResourceAccessSecurity API

2013-04-03 Thread Carsten Ziegeler
We discussed this API in length and as I said, the impl is missing. So yes, we're not releasing until it's implemented 2013/4/3 Bertrand Delacretaz bdelacre...@apache.org On Wed, Apr 3, 2013 at 12:17 PM, Carsten Ziegeler cziege...@apache.org wrote: ...I would like to cut some releases

RE: Feedback on the current ResourceAccessSecurity API

2013-04-03 Thread Mike Müller
To: dev@sling.apache.org Subject: Re: Feedback on the current ResourceAccessSecurity API We discussed this API in length and as I said, the impl is missing. So yes, we're not releasing until it's implemented 2013/4/3 Bertrand Delacretaz bdelacre...@apache.org On Wed, Apr 3, 2013 at 12

Re: Feedback on the current ResourceAccessSecurity API

2013-03-27 Thread Bertrand Delacretaz
Hi Mike, On Wed, Mar 27, 2013 at 8:54 AM, Mike Müller mike...@mysign.ch wrote: Bertrand wrote: Could sanitizeQuery be done by having the ResourceProvider implement a QueryOptimizer API instead?... It's not really an optimization in the sense of a QueryOptimizer, that could be done by

RE: Feedback on the current ResourceAccessSecurity API

2013-03-27 Thread Mike Müller
It's not really an optimization in the sense of a QueryOptimizer, that could be done by every ResourceProvider by now, without any new API. The sanitizeQuery functionality has to come with the ResourceAccessSecurity service: The query can be injected (sanitized) only from a service

Re: Feedback on the current ResourceAccessSecurity API

2013-03-27 Thread Bertrand Delacretaz
Hi Mike, On Wed, Mar 27, 2013 at 12:50 PM, Mike Müller mike...@mysign.ch wrote: ...It shouldn't scare at all: With or without the use of sanitizeQuery, the resulting list of resources (or the resulting resource) is checked against security anyway... ok, good then. ...The use case is very

RE: Feedback on the current ResourceAccessSecurity API

2013-03-27 Thread Mike Müller
So it is optimizeQuery really ;-) -Bertrand optimizeQuery in matters of performant security checks :-) Maybe you are right in this case, that we rather should name the method optimizeQuery than sanitizeQuery. mike

Re: Feedback on the current ResourceAccessSecurity API

2013-03-27 Thread Carsten Ziegeler
What about a neutral name? It's up to the implementation whether it optimizes or sanitizes - transformQuery maybe? Carsten 2013/3/27 Mike Müller mike...@mysign.ch: So it is optimizeQuery really ;-) -Bertrand optimizeQuery in matters of performant security checks :-) Maybe you are right in

Re: Feedback on the current ResourceAccessSecurity API

2013-03-27 Thread Bertrand Delacretaz
On Wed, Mar 27, 2013 at 5:48 PM, Carsten Ziegeler cziege...@apache.org wrote: ...What about a neutral name? It's up to the implementation whether it optimizes or sanitizes - transformQuery maybe?... Works for me, suggested javadoc: ** Allows the ResourceProvider to transform the query based on

RE: Feedback on the current ResourceAccessSecurity API

2013-03-27 Thread Mike Müller
+1 -Original Message- From: Bertrand Delacretaz [mailto:bdelacre...@apache.org] Sent: Wednesday, March 27, 2013 5:53 PM To: dev@sling.apache.org Subject: Re: Feedback on the current ResourceAccessSecurity API On Wed, Mar 27, 2013 at 5:48 PM, Carsten Ziegeler cziege...@apache.org

Re: Feedback on the current ResourceAccessSecurity API

2013-03-26 Thread Bertrand Delacretaz
Hi Mike, Thanks for your replies - as usual I'm a stickler for names...I think good naming helps a lot in making APIs understandable. On Mon, Mar 25, 2013 at 8:14 PM, Mike Müller mike...@mysign.ch wrote: ... Bertrand wrote: // Calling that canRead would be more consistent with other names

RE: Feedback on the current ResourceAccessSecurity API

2013-03-25 Thread Mike Müller
Notes on ResourceAccessSecurity: 1) javadocs says * - Expected to only be implemented once in the framework/application..., I'm not sure about that. If you have both a filesystem and an HBase resource providers, they might use very different implementations? 2) Notes as comments in the

Re: Feedback on the current ResourceAccessSecurity API

2013-03-25 Thread Carsten Ziegeler
2013/3/25 Mike Müller mike...@mysign.ch: Notes on ResourceAccessSecurity: At this time ResourceResolver has a method named getUserID() which returns a String. The Javadoc of this method says: * Get the user ID, if any, associated with this resource resolver. The * meaning of this