Then let's fix this in trunk, given the fact that we've released several
versions of the engine (1.0.0 - 1.0.18) until now with antlr embedded.
Thanks,
Radu
On Mon, 27 Feb 2017 at 17:05 Karl Pauls wrote:
> That said, if you fix it in trunk and get the majority of the votes I
> suppose it isn't
Well, I personally think you'd be better of recutting the release.
After all, release votes are pretty much for the purpose of making
sure there are no legal issues with the release and not having the
proper licenses in place isn't good.
That said, if you fix it in trunk and get the majority of th
Hi Karl,
I guess we should. Do you consider this a release blocker or can I just add
them into a separate commit?
Cheers,
Radu
On Mon, 27 Feb 2017 at 15:52 Karl Pauls wrote:
> [...]
> Shouldn't they be added to the LICENSE file?
>
+1 -- checked signature and build
On Mon, Feb 27, 2017 at 8:27 AM, Robert Munteanu wrote:
> On Mon, 2017-02-27 at 11:17 +, Radu Cotescu wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert
The HTL Compiler binary embeds antlr4-runtime-4.1.jar and
org.abego.treelayout.core-1.0.1.jar.
Both are under BSD license. While they are mentioned in the
DEPENDENCIES I couldn't find the actual licenses in the LICENSE file.
Shouldn't they be added to the LICENSE file?
regards,
Karl
On Mon, Fe
On Mon, 2017-02-27 at 11:17 +, Radu Cotescu wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
Typo. Yes, we fixed 3 issues. Sorry for that.
On Mon, 27 Feb 2017 at 13:13 Stefan Seifert wrote:
> +1
>
> stefan
>
> p.s. i count 3 issues, not 2.
>
>
> >-Original Message-
> >From: Radu Cotescu [mailto:r...@apache.org]
> >Sent: Monday, February 27, 2017 12:18 PM
> >To: Sling Dev
> >Subj
+1
stefan
p.s. i count 3 issues, not 2.
>-Original Message-
>From: Radu Cotescu [mailto:r...@apache.org]
>Sent: Monday, February 27, 2017 12:18 PM
>To: Sling Dev
>Subject: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.8, Apache
>Sling Scripting HTL Engine 1.0.32
>
>Hi,
>
>We so
