sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1354497755
SonarCloud Quality Gate failed. [![Quality Gate
kwin commented on PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1354554130
> I suggest discussing on the dev list then, I think a more general
discussion is useful on the topic of repoinit backwards compatibility and how
we tackle similar
bdelacretaz commented on PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1354480678
> I think the best way out is to create new instructions with the right
behaviour, deprecate the old instructions.
I agree that repoinit should stay
Hi,
There are some issue with RepoInit with regards to failure behaviour like [1]
and [2] and the discussion initially raised in JIRA and/or GitHub PR was a bit
tough I try to summarise the issue and status quo here in order to get some
more feedback.
Most repoinit statements lead to an
kwin commented on PR #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#issuecomment-1354376709
Due to concerns with regards to backwards-compatibility I propose to add the
new statement `enforce principal ACL` (with same options and enclosing path
privilege
sonarcloud[bot] commented on PR #27:
URL:
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27#issuecomment-1354361673
SonarCloud Quality Gate failed. [![Quality Gate
kwin commented on PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1354488929
@bdelacretaz Let us please discuss this in
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27. From
an end user perspective deprecating one
bdelacretaz commented on PR #41:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1354496377
I suggest discussing on the dev list then, I think a more general discussion
is useful on the topic of repoinit backwards compatibility and how we tackle
kwin opened a new pull request, #27:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27
stricter semantics of adjusting types of existing nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kwin commented on code in PR #27:
URL:
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27#discussion_r1050566210
##
src/main/java/org/apache/sling/repoinit/parser/operations/CreateNode.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/SLING-11736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-11736:
Fix Version/s: Repoinit Parser 1.8.2
> Create path should potentially adjust the primary
Kronnox commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1354480380
> Do you think that any inline documentation is necessary/helpful?
@joerghoh I added additional javadoc comments where it made sense imo.
Everything else
[
https://issues.apache.org/jira/browse/SLING-11736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-11736:
Summary: Create path should potentially adjust the primary type/mixin types
of existing
> On 16. Dec 2022, at 14:31, Bertrand Delacretaz wrote:
>
> So in the case of SLING-11736 I have proposed adding a [strict] option
> to "create path", exemple:
>
> create path [strict] (nt:folder) /one(mixin nt:art)/step(mixin
> nt:dance)/two/steps
>
> which activates the improved behavior
rombert commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1354924486
I tried to prepare the release but the tests consistently fail for me
locally with
```
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]
Konrad Windszus wrote:
> ...I would really appreciate direct feedback in the GH PR (where you are
> reviewer BTW ;-))...
Sure, but I also want to see if others agree with the general
principles proposed in this thread.
-Bertrand
[
https://issues.apache.org/jira/browse/SLING-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-11733.
-
Resolution: Fixed
> Add junit rule for defining a custom user-agent
>
Konrad Windszus wrote:
> ...I don’t like this for the reasons outlined at
> https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/41#issuecomment-1354488929
>
> "From an end user perspective deprecating one statement and introducing a new
> one with a more concise name is better
rombert merged PR #3:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
he-sling-starter_master/jdk_1.8_latest@tmp/withMavenff387557/maven-spy-20221216-115820-928285865194471719155.log
[Pipeline] }
[withMaven] artifactsPublisher - Archive artifact pom.xml under
org/apache/sling/org.apache.sling.starter/13-SNAPSHOT/org.apache.sling.starter-13-SNAPSHOT.pom
[withMaven] artif
rombert commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1354741646
Thanks for the contribution @Kronnox !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rombert merged PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SLING-11711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh reassigned SLING-11711:
-
Assignee: Joerg Hoh
> Deprecate the use of @Inject in favor of injector-specific annotations
>
It is more about that this answers all the questions you had about the proposal
because it is code (which says more than 1000 words).
Konrad
> On 16. Dec 2022, at 15:08, Bertrand Delacretaz wrote:
>
> Konrad Windszus wrote:
>> ...I would really appreciate direct feedback in the GH PR (where
dependabot[bot] opened a new pull request, #3:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/3
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1.
Release notes
Sourced from https://github.com/junit-team/junit4/releases;>junit's
[
https://issues.apache.org/jira/browse/SLING-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-11733:
Fix Version/s: Apache Sling Testing Rules 2.0.2
> Add junit rule for defining a custom
[
https://issues.apache.org/jira/browse/SLING-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-11733:
---
Assignee: Luca Adams
> Add junit rule for defining a custom user-agent
>
Hi,
Konrad Windszus wrote:
> ...There are some issues with RepoInit with regards to failure behaviour like
> [1] and [2]...
I think we should keep the existing principles in repoinit, and as you
say clarify them in the documentation:
- repoinit is strictly backwards compatible, we try very
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-testing-rules/pull/3#issuecomment-1354885463
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
> On 16. Dec 2022, at 14:58, Bertrand Delacretaz wrote:
>
> So (assumption A) for SLING-11736 you would add a completely new
> "create node" command, that has the exact same behavior as "create
> path" except for the behavior changes of SLING-11736 ?
Exactly, this is what is proposed in [4]
On 16.12.2022 14:38, Konrad Windszus wrote:
On 16. Dec 2022, at 14:31, Bertrand Delacretaz wrote:
So in the case of SLING-11736 I have proposed adding a [strict] option
to "create path", exemple:
create path [strict] (nt:folder) /one(mixin nt:art)/step(mixin
nt:dance)/two/steps
which
TBH I don’t yet see use cases for failing when the node does already exist
(create node in your proposal) nor for failing when the node does not exist
(update node)
Can you share some examples you have in mind which would benefit from that
functionality?
(We also don’t have anything like that
sonarcloud[bot] commented on PR #4:
URL:
https://github.com/apache/sling-org-apache-sling-testing-rules/pull/4#issuecomment-1355715208
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
rombert merged PR #4:
URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1355880271
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1355886695
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
For me the proposed "strict" modifier doesn't seem obvious what it is going
to do.
I would prefer a more verbose language with several options and let me
choose which one to use. In other words, deprecate the original
(ambiguous) "create path" syntax and replace it with a new
>
> TBH I don’t yet see use cases for failing when the node does already
> exist (create node in your proposal) nor for failing when the node does
> not exist (update node)
>
Yes, that is kind of the point. You can't possibly conceive every possible
use case, so just make the language generic
Also, another use case I was thinking of for the "update node" scenario is
if you want to add a mixin to a node that was expected to be already
created elsewhere, if the node doesn't exist yet then your mixin won't get
assigned and you could have indeterminate behavior later. So failing fast
apelluru merged PR #1:
URL: https://github.com/apache/sling-org-apache-sling-hc-api/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #4:
URL:
https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/pull/4#issuecomment-1356092504
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-11699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashok Pelluru resolved SLING-11699.
---
Resolution: Fixed
> Deprecate apache-sling-hc-api
> -
>
>
apelluru merged PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/SLING-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashok Pelluru resolved SLING-11697.
---
Resolution: Fixed
> Update parent bundle (49) to sling-commons-fsclassloader
>
[
https://issues.apache.org/jira/browse/SLING-11696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashok Pelluru resolved SLING-11696.
---
Resolution: Fixed
> Update parent bundle (49) to sling.commons.threaddump
>
dependabot[bot] opened a new pull request, #4:
URL:
https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/pull/4
Bumps commons-io from 2.5 to 2.7.
[![Dependabot compatibility
apelluru merged PR #4:
URL: https://github.com/apache/sling-org-apache-sling-adapter-annotations/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SLING-11695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashok Pelluru resolved SLING-11695.
---
Resolution: Fixed
> Update parent bundle (49) to sling-org-apache-sling-adapter-annotations
apelluru merged PR #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-threaddump/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
49 matches
Mail list logo
