Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]
reschke commented on code in PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560466861 ## pom.xml: ## @@ -45,7 +45,7 @@ 1.44.0 Review Comment: These versions of Oak and Jackrabbit are EOLd. Please use the latest maintenance branch versions (Jackrabbit 2.20.15 and Oak 1.22.19). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835795#comment-17835795 ] Julian Reschke commented on SLING-12266: I'm not an expert on mocking and Oak APIs, so I really can't provide feedback here. If it works... That said: please make sure to update Jackrabbit/Oak references to non-EOLd releases... > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835759#comment-17835759 ] Csaba Varga commented on SLING-12266: - I separated that change to a different commit because I wasn't sure about it, either. On one hand, it's the only way I can see to avoid running some code that parses a large CND file and tries to (redundantly) register the built-in node types. On the other hand, it _is_ a bit ugly, and it doesn't save that much time, according to my quick and dirty performance tests. I can drop that part from my PR if that's the consensus. > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835756#comment-17835756 ] Stefan Seifert commented on SLING-12266: the approach looks good to me in general. it would be nice if there is a way to avoid code like [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12/commits/11de72022bf969e7253c6f6725b528963d3638db] which seems to duplicate some logic from the Jcr class implementation. but i have too less insight there from an oak impl perspective. [~reschke] can you have a look at PR [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12] as well from an oak perspective? > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned SLING-12266: -- Assignee: Stefan Seifert > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
stefanseifert commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2047647027 lgtm from sling-mock perspective -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835741#comment-17835741 ] Gagan Malpani commented on SLING-12285: --- Hello [~rombert] , Currently i am working on one of the upgrade program of product based on AEM 6.4 which has sling-org-apache-sling-tenant version 1.0.0 & we are updating it to AEM Version which has sling-org-apache-sling-tenant version 1.1.4. We have faced issue during tenant creation. On investigation , we found [bindTenantSetup|https://github.com/apache/sling-org-apache-sling-tenant/blob/org.apache.sling.tenant-1.1.4/src/main/java/org/apache/sling/tenant/internal/TenantProviderImpl.java#L150] is not getting called but it is working in 1.0.0 . Major difference between 2 releases WRT tenantproviderimpl is we have migrated from SCR annotations to OSGI annotations. AFAIK bind & unbind should be explicitly mention in OSGI R6 annotation. Please correct me if wrong. After applying fix of PR , binding is happening. > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Gagan Malpani >Priority: Major > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]
rombert commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2047316646 Thanks @gagan031992 ! I asked for clarification there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835704#comment-17835704 ] Robert Munteanu commented on SLING-12285: - Thanks for the report [~malp...@adobe.com]. Is this an actual bug? How does this manifest (log entries, etc)? > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Gagan Malpani >Priority: Major > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12266 - Add support for repo snapshots [sling-org-apache-sling-testing-sling-mock]
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39#issuecomment-2047293884 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock=39) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=39=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=39=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock=39=false=true)  [95.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=39=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=39=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock=39) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2047276453 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-tenant=3) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tenant=3=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tenant=3=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tenant=3=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tenant=3=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-tenant=3) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]
gagan031992 commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2047272622 Hello @rombert , Here is the Sling issue for it. https://issues.apache.org/jira/browse/SLING-12285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12285) adding bind & unbind methods mapping in reference annotation
Gagan Malpani created SLING-12285: - Summary: adding bind & unbind methods mapping in reference annotation Key: SLING-12285 URL: https://issues.apache.org/jira/browse/SLING-12285 Project: Sling Issue Type: Improvement Components: General Reporter: Gagan Malpani adding bind & unbind methods mapping in reference annotation for tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1332 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1332/ for details. No further emails will be sent until the status of the build is changed.
[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835676#comment-17835676 ] Csaba Varga commented on SLING-12266: - [~sseifert] : I have opened two PRs, as this will need changes to both sling-mock and sling-mock-oak. Looks like I will need to work a bit on test coverage before the build becomes green, but in the meantime, feel free to review the overall approach. > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12266 - Add support for repo snapshots [sling-org-apache-sling-testing-sling-mock]
csaboka commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39#issuecomment-2047123375 This PR goes together with https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12/ . Without that change, this one makes nothing useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]
csaboka commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#issuecomment-2047124607 This change depends on https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39 . It won't build properly until that PR is merged. This is expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12266 - Add support for repo snapshots [sling-org-apache-sling-testing-sling-mock]
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39#issuecomment-2047123805 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock=39) **Quality Gate failed** Failed conditions  [66.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=39=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock=39) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]
csaboka opened a new pull request, #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): update dependency commons-io:commons-io to v2.16.1 [sling-org-apache-sling-starter]
rombert merged PR #318: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency org.apache.jackrabbit:oak-api to v1.62.0 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #319: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/319 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.jackrabbit:oak-api](http://jackrabbit.apache.org/) | `1.60.0` -> `1.62.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore(deps): update dependency commons-io:commons-io to v2.16.1 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #318: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/318 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [commons-io:commons-io](https://commons.apache.org/proper/commons-io/) ([source](https://gitbox.apache.org/repos/asf?p=commons-io.git)) | `2.16.0` -> `2.16.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: How to use structured logging in sling?
Sounds good. I will try this approach. Am Mi., 10. Apr. 2024 um 11:00 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi Christian, > > On Wed, 2024-04-10 at 10:14 +0200, Christian Schneider wrote: > > I would like to add an appender like below to sling. > > The idea is to use structured logging for simpler ingestion and the > > ability > > to easily add markers and MDC key/value pairs. > > > > Did anyone try this before? The issue here is that I need special > > classes > > for encoder and decorator that are not part of logback core. > > > > I did not try this. The docs indicate though that you can register > Appenders as OSGi services [1], perhaps you can create a small bundle > that has a such a service and register it? > > Thanks, > Robert > > > [1]: > > https://sling.apache.org/documentation/development/logging.html#appenders-as-osgi-services-1 > -- -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
Re: How to use structured logging in sling?
Hi Christian, On Wed, 2024-04-10 at 10:14 +0200, Christian Schneider wrote: > I would like to add an appender like below to sling. > The idea is to use structured logging for simpler ingestion and the > ability > to easily add markers and MDC key/value pairs. > > Did anyone try this before? The issue here is that I need special > classes > for encoder and decorator that are not part of logback core. > I did not try this. The docs indicate though that you can register Appenders as OSGi services [1], perhaps you can create a small bundle that has a such a service and register it? Thanks, Robert [1]: https://sling.apache.org/documentation/development/logging.html#appenders-as-osgi-services-1
Re: [PR] adding bind & unbind methods mapping [sling-org-apache-sling-tenant]
rombert commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2046914907 @gagan031992 - thanks for the PR! Since this is a non-trivial change, can you please open a Jira issue? https://issues.apache.org/jira/browse/SLING -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
How to use structured logging in sling?
I would like to add an appender like below to sling. The idea is to use structured logging for simpler ingestion and the ability to easily add markers and MDC key/value pairs. Did anyone try this before? The issue here is that I need special classes for encoder and decorator that are not part of logback core. true Christian
[jira] [Resolved] (SLING-12284) sling/jcr/osgi/resourceresolver-mock: Update to Parent 60, Java 11 Minimum Version
[ https://issues.apache.org/jira/browse/SLING-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-12284. Resolution: Fixed logging-mock * [https://github.com/apache/sling-org-apache-sling-testing-logging-mock/commit/cb4e079f89240290e32ec0d2ba103be89707a33a] * [https://github.com/apache/sling-org-apache-sling-testing-logging-mock/commit/3ed3f3eb7fd4f9ea0910a7619d4c3a6f8dcf4cde] * [https://github.com/apache/sling-org-apache-sling-testing-logging-mock/commit/77933617b033b98ba983fa9e00bea5fea548ef3d] jcr-mock * [https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/commit/74f6c497295699a66db3d6fd2f9147f8faa24404] * [https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/commit/423f2856db8d03d5accb12dd3b55c5fc6311c020] * [https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/commit/2b964f2b6e7db301aa51258deffa7af7f53a98e2] osgi-mock * [https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/commit/771ed600ac3347f8f0c563e10a06fd0ed73d2d1a] * [https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/commit/5cb642928aab2001b8fbfb326ea92b58f713b4de] * [https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/commit/dbc9d3051a741de52c64ea6c32bd00b883c8fdbb] resourceresolver-mock * [https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/commit/b86313a0fb75f067ddcddd5b184e032c17e27434] * [https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/commit/d4090be2060ec63d87f1a505b9ca5c0a1fc3] * [https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/commit/0f2acd051d0bf40139e19ea58787931c8b9bf02b] sling-mock * [https://github.com/apache/sling-org-apache-sling-testing-sling-mock/commit/bf72c05b952fc688442e0d0a3bc3c7ea2df3f478] * [https://github.com/apache/sling-org-apache-sling-testing-sling-mock/commit/74c1f1ec587abb9dcf8a115aa8fe4b5eee6b9f72] * [https://github.com/apache/sling-org-apache-sling-testing-sling-mock/commit/211ce26e26de49822fad6bad3ce6dd4941b80dd0] sling-mock-oak * [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/16c34e2aa6f8cbfb384ddb324d6b3a6bc51f48a4] * [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/61ee823f52beeca205edd2aafbf5b0f2779c6619] * [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/7998acc66ba183b371839f27f1a9cfaa46b4ea07] caconfig-mock-plugin * [https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/commit/fd5f9e100d7de2125a3a2731367d04d4d926b94e] * [https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/commit/1468f9ec381a74a2c4e59cda67e3e296210ede34] * [https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/commit/c3b5889cc26b0900baadb2cd4c350707d215ffa2] > sling/jcr/osgi/resourceresolver-mock: Update to Parent 60, Java 11 Minimum > Version > -- > > Key: SLING-12284 > URL: https://issues.apache.org/jira/browse/SLING-12284 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing Logging Mock 2.1.0, Testing Sling Mock Oak > 3.2.0-1.44.0, Context-Aware Configuration Mock Plugin 1.6.0, Testing JCR Mock > 1.7.0, Testing OSGi Mock 3.5.0, Testing ResourceResolver Mock 1.5.0, Testing > Sling Mock 3.5.0 > > > update to parent 60, see also [https://cwiki.apache.org/confluence/x/SI75E] > this drops java 8 support, and instead supports java 11, 17, 21 - build is > done with java 17 > minimum java requirement for runtime is java 11 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-sling-mock]
stefanseifert merged PR #38: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-caconfig-mock-plugin]
stefanseifert merged PR #6: URL: https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-sling-mock]
sonarcloud[bot] commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/38#issuecomment-2046836583 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock=38) **Quality Gate failed** Failed conditions  [64.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=38=new_coverage=list) (required ≥ 80%)  [3.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=38=new_duplicated_lines_density=list) (required ≤ 3%)  [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock=38) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock=38) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-sling-mock-oak]
stefanseifert merged PR #11: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-osgi-mock]
stefanseifert merged PR #40: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-osgi-mock]
sonarcloud[bot] commented on PR #40: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/40#issuecomment-2046813226 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock=40) **Quality Gate failed** Failed conditions  [73.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock=40=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock=40) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-resourceresolver-mock]
stefanseifert merged PR #15: URL: https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-jcr-mock]
stefanseifert merged PR #35: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-logging-mock]
stefanseifert merged PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-logging-mock/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12265) Node type registration is inefficient during unit tests when using the JCR_OAK resolver type
[ https://issues.apache.org/jira/browse/SLING-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-12265. Fix Version/s: Testing Sling Mock 3.5.0 Resolution: Fixed https://github.com/apache/sling-org-apache-sling-testing-sling-mock/commit/4ff35ad95143d85bc1f91888cd53a3f624f86e06 > Node type registration is inefficient during unit tests when using the > JCR_OAK resolver type > > > Key: SLING-12265 > URL: https://issues.apache.org/jira/browse/SLING-12265 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > Labels: performance > Fix For: Testing Sling Mock 3.5.0 > > > I did some profiling on my company's slow-running unit tests today, and found > that 70+% of the CPU time is spent inside NodeTypeDefinitionScanner, more > specifically in the commit() call triggered by it. Our test classpath > includes AEM Mocks and the Cloud SDK, resulting in 30+ CND files being > detected, and as many commits done preparing the repository before each test. > (Slightly more, because some commits fail and get retried later.) > It should be possible to parse each CND into memory structures in a separate > pass, then create the node types all at once in a single commit. This > wouldn't just eliminate the extra commits, but would also remove the need to > retry, since all dependencies would also be provided in the same call. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12265 - Improve node type registration in JCR_OAK [sling-org-apache-sling-testing-sling-mock]
stefanseifert merged PR #37: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
