Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-10 Thread via GitHub
reschke commented on code in PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560466861 ## pom.xml: ## @@ -45,7 +45,7 @@ 1.44.0 Review Comment: These versions of Oak and Jackrabbit are EOLd.

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-10 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835795#comment-17835795 ] Julian Reschke commented on SLING-12266: I'm not an expert on mocking and Oak APIs, so I really

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-10 Thread Csaba Varga (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835759#comment-17835759 ] Csaba Varga commented on SLING-12266: - I separated that change to a different commit because I

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-10 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835756#comment-17835756 ] Stefan Seifert commented on SLING-12266: the approach looks good to me in general. it would be

[jira] [Assigned] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-10 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned SLING-12266: -- Assignee: Stefan Seifert > Cache initial repository state to improve JCR_OAK

Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]

2024-04-10 Thread via GitHub
stefanseifert commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2047647027 lgtm from sling-mock perspective -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SLING-12285) adding bind & unbind methods mapping in reference annotation

2024-04-10 Thread Gagan Malpani (Jira)
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835741#comment-17835741 ] Gagan Malpani commented on SLING-12285: --- Hello [~rombert]  , Currently i am working on one of the

Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]

2024-04-10 Thread via GitHub
rombert commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2047316646 Thanks @gagan031992 ! I asked for clarification there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (SLING-12285) adding bind & unbind methods mapping in reference annotation

2024-04-10 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835704#comment-17835704 ] Robert Munteanu commented on SLING-12285: - Thanks for the report [~malp...@adobe.com]. Is this

Re: [PR] SLING-12266 - Add support for repo snapshots [sling-org-apache-sling-testing-sling-mock]

2024-04-10 Thread via GitHub
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39#issuecomment-2047293884 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality

Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]

2024-04-10 Thread via GitHub
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2047276453 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]

2024-04-10 Thread via GitHub
gagan031992 commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2047272622 Hello @rombert , Here is the Sling issue for it. https://issues.apache.org/jira/browse/SLING-12285 -- This is an automated message from the Apache Git

[jira] [Created] (SLING-12285) adding bind & unbind methods mapping in reference annotation

2024-04-10 Thread Gagan Malpani (Jira)
Gagan Malpani created SLING-12285: - Summary: adding bind & unbind methods mapping in reference annotation Key: SLING-12285 URL: https://issues.apache.org/jira/browse/SLING-12285 Project: Sling

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1332 is FIXED

2024-04-10 Thread Apache Jenkins Server
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1332/ for details. No further emails will be sent until the status of the build is changed.

[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance

2024-04-10 Thread Csaba Varga (Jira)
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835676#comment-17835676 ] Csaba Varga commented on SLING-12266: - [~sseifert] : I have opened two PRs, as this will need

Re: [PR] SLING-12266 - Add support for repo snapshots [sling-org-apache-sling-testing-sling-mock]

2024-04-10 Thread via GitHub
csaboka commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39#issuecomment-2047123375 This PR goes together with https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12/ . Without that change, this one makes nothing

Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-10 Thread via GitHub
csaboka commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#issuecomment-2047124607 This change depends on https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39 . It won't build properly until that PR is merged.

Re: [PR] SLING-12266 - Add support for repo snapshots [sling-org-apache-sling-testing-sling-mock]

2024-04-10 Thread via GitHub
sonarcloud[bot] commented on PR #39: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39#issuecomment-2047123805 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality

[PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-10 Thread via GitHub
csaboka opened a new pull request, #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore(deps): update dependency commons-io:commons-io to v2.16.1 [sling-org-apache-sling-starter]

2024-04-10 Thread via GitHub
rombert merged PR #318: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] chore(deps): update dependency org.apache.jackrabbit:oak-api to v1.62.0 [sling-org-apache-sling-starter]

2024-04-10 Thread via GitHub
renovate-bot opened a new pull request, #319: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/319 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

[PR] chore(deps): update dependency commons-io:commons-io to v2.16.1 [sling-org-apache-sling-starter]

2024-04-10 Thread via GitHub
renovate-bot opened a new pull request, #318: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/318 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

Re: How to use structured logging in sling?

2024-04-10 Thread Christian Schneider
Sounds good. I will try this approach. Am Mi., 10. Apr. 2024 um 11:00 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi Christian, > > On Wed, 2024-04-10 at 10:14 +0200, Christian Schneider wrote: > > I would like to add an appender like below to sling. > > The idea is to use structured

Re: How to use structured logging in sling?

2024-04-10 Thread Robert Munteanu
Hi Christian, On Wed, 2024-04-10 at 10:14 +0200, Christian Schneider wrote: > I would like to add an appender like below to sling. > The idea is to use structured logging for simpler ingestion and the > ability > to easily add markers and MDC key/value pairs. > > Did anyone try this before? The

Re: [PR] adding bind & unbind methods mapping [sling-org-apache-sling-tenant]

2024-04-10 Thread via GitHub
rombert commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2046914907 @gagan031992 - thanks for the PR! Since this is a non-trivial change, can you please open a Jira issue? https://issues.apache.org/jira/browse/SLING -- This is

How to use structured logging in sling?

2024-04-10 Thread Christian Schneider
I would like to add an appender like below to sling. The idea is to use structured logging for simpler ingestion and the ability to easily add markers and MDC key/value pairs. Did anyone try this before? The issue here is that I need special classes for encoder and decorator that are not part of

[jira] [Resolved] (SLING-12284) sling/jcr/osgi/resourceresolver-mock: Update to Parent 60, Java 11 Minimum Version

2024-04-10 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-12284. Resolution: Fixed logging-mock *

Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-sling-mock]

2024-04-10 Thread via GitHub
stefanseifert merged PR #38: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-caconfig-mock-plugin]

2024-04-10 Thread via GitHub
stefanseifert merged PR #6: URL: https://github.com/apache/sling-org-apache-sling-testing-caconfig-mock-plugin/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-sling-mock]

2024-04-10 Thread via GitHub
sonarcloud[bot] commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/38#issuecomment-2046836583 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality

Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-sling-mock-oak]

2024-04-10 Thread via GitHub
stefanseifert merged PR #11: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-osgi-mock]

2024-04-10 Thread via GitHub
stefanseifert merged PR #40: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-osgi-mock]

2024-04-10 Thread via GitHub
sonarcloud[bot] commented on PR #40: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/40#issuecomment-2046813226 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality

Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-resourceresolver-mock]

2024-04-10 Thread via GitHub
stefanseifert merged PR #15: URL: https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-jcr-mock]

2024-04-10 Thread via GitHub
stefanseifert merged PR #35: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] SLING-12284 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-testing-logging-mock]

2024-04-10 Thread via GitHub
stefanseifert merged PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-logging-mock/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Resolved] (SLING-12265) Node type registration is inefficient during unit tests when using the JCR_OAK resolver type

2024-04-10 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-12265. Fix Version/s: Testing Sling Mock 3.5.0 Resolution: Fixed

Re: [PR] SLING-12265 - Improve node type registration in JCR_OAK [sling-org-apache-sling-testing-sling-mock]

2024-04-10 Thread via GitHub
stefanseifert merged PR #37: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,