Re: Looking for final review of SOLR-16842

2024-06-28 Thread David Smiley
Thanks so much Jason for investing your time to fix the build machines! RE timeout -- we ought to explicitly set a timeout so as to not hog the machine indefinitely. For Bats, I don't know where that is. I've done changes in the recent past for normal / JUnit tests. On Fri, Jun 28, 2024 at 5:42

Re: Looking for final review of SOLR-16842

2024-06-28 Thread Jason Gerlowski
> I wanted to confirm that our Jenkins builds are still happy, and while our > normal Jenkins boxes are busted The boxes are fixed! Or, lucene-solr-1 should be at least. I'm still looking into lucene-solr-2. So any failures at this point are legitimate issues. Case in point, it looks like our

Re: Looking for final review of SOLR-16842

2024-06-28 Thread Jan Høydahl
From an upgrade 9->10 perspective, it would be good to start getting deprecation warnings in 9.x for old options and change scripts etc so you don't have a big-bang moment in 10.0. A potential option 5) is to introduce the new options and deprecate old in 10.0, meaning they won't be removed unt

Re: Looking for final review of SOLR-16842

2024-06-28 Thread David Smiley
I don’t care if this is 10x only; that’s the easiest path ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Fri, Jun 28, 2024 at 1:18 PM Eric Pugh wrote: > Hi all…. Quick update that I merged SOLR-16842 into main. > > I wanted to confirm that our Je

Re: Looking for final review of SOLR-16842

2024-06-28 Thread Eric Pugh
Hi all…. Quick update that I merged SOLR-16842 into main. I wanted to confirm that our Jenkins builds are still happy, and while our normal Jenkins boxes are busted, I see that we have “Solr-Check-main-s390x”? Looking at it, it appears that recent code merges are fine, that the one test that

Re: Looking for final review of SOLR-16842

2024-06-22 Thread Eric Pugh
Thanks Jason, I’m happy to stall till end of day on Monday to click “merge”! Thanks. > On Jun 21, 2024, at 12:33 PM, Jason Gerlowski wrote: > > Hey Eric, > > Sorry for the delay - I am hoping to review that PR. I'll try to have > a review done by Monday (if not today). That should leave a

Re: Looking for final review of SOLR-16842

2024-06-21 Thread Jason Gerlowski
Hey Eric, Sorry for the delay - I am hoping to review that PR. I'll try to have a review done by Monday (if not today). That should leave a week or so for any followups prior to your big trip! (Safe travels!) If Monday isn't early enough and you need to merge on Saturday, IMO that's fine. The

Looking for final review of SOLR-16842

2024-06-21 Thread Eric Pugh
Hi all, I’m planning on merging https://github.com/apache/solr/pull/1768, SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands tomorrow (Saturday). I’m going to be traveling (Spain!) for three weeks starting June 29th, and I’d like to make sure this fairly big change