Re: Overlapping arguments (SOLR-17383)

We are almost done addressing all the overlapping issues I wanted to cover in this series and we already solved multiple conflicts. I would like to add the next resolutions in this message. Right now, the common entrypoint for the tools is bin/solr(.cmd). This includes the AssertTool, which uses s

Re: Overlapping arguments (SOLR-17383)

I am happy with the current solution of your PR Eric, thanks. I would like to continue with two more flags that may cause confusion or in future additional conflicts. These flags are -f and -s. They are used multiple times in multiple tools for different options or similar options with different n

Re: Overlapping arguments (SOLR-17383)

I am really close to merging the PR for the overlapping requirements and just looking at --debug doesn't sit quite right with me.   Plus mulling on Houston's feedback.   Maybe it's too many years of typing in -verbose.   Maybe it's that --debug makes me think I am setting Log4j levels...    I

Re: Overlapping arguments (SOLR-17383)

Here is a candidate PR for resolving the various -v flavours of verbose, value, and version by moving to --debug in place of -v and --verbose.   https://github.com/apache/solr/pull/2721 On Tuesday, September 24, 2024 at 01:25:57 AM PDT, Christos Malliaridis wrote: I see. I didn't kn

Re: Overlapping arguments (SOLR-17383)

I see. I didn't know that "start" is mandatory now. I am not sure if this case occurs, but we still have in bin/solr.cmd `IF "%SCRIPT_CMD%"=="" set SCRIPT_CMD=start` (see https://github.com/apache/solr/blob/7d6088381d918e4a94e8c3d2c20c1eb5be003186/solr/bin/solr.cmd#L393C1-L393C43), which is why I a

Re: Overlapping arguments (SOLR-17383)

Bin/solr start actually is mandatory now, I would have to look up when we made that change. It feels like a while ago…. I will put up a pr and we can see how it feels. Sent from my iPhone > On Sep 13, 2024, at 5:05 PM, Houston Putman wrote: > > I thought we were eventually going to make `st

Re: Overlapping arguments (SOLR-17383)

I thought we were eventually going to make `start` mandatory, thus no confusion when just providing bin/solr -v? Anyways, I'm not going to make a line in the sand. I just think '-v' works better as "verbose", though I do understand others use it for "version". - Houston On Sun, Sep 8, 2024 at 9:

Re: Overlapping arguments (SOLR-17383)

In the section on "Arguments and Flags" in https://clig.dev/#arguments-and-flags, they suggestion that --version is for Version.  And that due to the confusion of -v for Version or Verbose, to use -d and --debug and skip the verbose concept completely.  I think the --version would only apply t

Re: Overlapping arguments (SOLR-17383)

Maybe both? Meaning, if "-v" is provided, start Solr in verbose mode and print the version number first. On Sun, Sep 8, 2024 at 2:34 PM Christos Malliaridis wrote: > Thanks Houston for your perspective and sorey for the late response. > > I have considered both outcomes and thought that going w

Re: Overlapping arguments (SOLR-17383)

Thanks Houston for your perspective and sorey for the late response. I have considered both outcomes and thought that going with the -v for version is more expected for new users. Usually CLI tools allow something like "[command] -v" to get quick and easy the version of the CLI tool / command. In

Re: Overlapping arguments (SOLR-17383)

Why keep "-v" and "-version" around? I'd much rather keep the very widely-used "-v"="--verbose". Only supporting "bin/solr version" makes much more sense to me. And I'm not even particularly worried about back compat for this one. - Houston On Fri, Sep 6, 2024 at 1:10 PM Christos Malliaridis wr

Re: Overlapping arguments (SOLR-17383)

Many thanks to Eric for handling all the conflicts so far and creating PRs in an instant. The next conflict we have in Solr is the -v flag. -v is used for version in bin/solr.cmd (explicitly) and SolrCLI, for verbose (with the partly removed uppercase variant -V for a special case) in multiple CLI

Re: Overlapping arguments (SOLR-17383)

Continuing with the next conflict, We use -p mainly for the port argument and it is currently used in RunExampleTool and SolrExporter as such. -p is also used in ConfigTool for --property, in PackageTool for --param, and in PostTool for --params. This is more of a "light" conflict, as it does not

Re: Overlapping arguments (SOLR-17383)

Hello everyone, In order to start resolving the CLI argument conflicts from https://issues.apache.org/jira/browse/SOLR-17383, we started to deprecate (in 9.X) and remove or change (in 10.0/main) the overlapping arguments. I would like to use this thread for tracking each conflict resolution. A co

Overlapping arguments (SOLR-17383)

Hello devs, I would like to get some attention on overlapping arguments that I have found and documented in SOLR-17383 . This was one of my "bad experiences" when I started working with Solr, so I think it may be more important than I thought. Wit