Re: bazel and external/

2022-03-17 Thread Jungtaek Lim
Avro reader is technically a connector. We eventually called data source implementation "connector" as well; the package name in the catalyst represents it. Docker is something I'm not sure fits with the name "external". It probably deserves a top level directory now, since we start to release an

Re: bazel and external/

2022-03-17 Thread Sean Owen
I sympathize, but might be less change to just rename the dir. There is more in there like the avro reader; it's kind of miscellaneous. I think we might want fewer rather than more top level dirs. On Thu, Mar 17, 2022 at 7:33 PM Jungtaek Lim wrote: > We seem to just focus on how to avoid the

Re: bazel and external/

2022-03-17 Thread Jungtaek Lim
We seem to just focus on how to avoid the conflict with the name "external" used in bazel. Since we consider the possibility of renaming, why not revisit the modules "external" contains? Looks like kinds of the modules external directory contains are 1) Docker 2) Connectors 3) Sink on Dropwizard

Re: bazel and external/

2022-03-17 Thread Dongjoon Hyun
Thank you for posting this, Alkis. Before the question (1) and (2), I'm curious if the Apache Spark community has other downstreams using Bazel. To All. If there are some Bazel users with Apache Spark code, could you share your practice? If you are using renaming, what is your renamed directory

Re: bazel and external/

2022-03-17 Thread Alkis Evlogimenos
AFAIK there is not. `external` has been baked in bazel since the beginning and there is no plan from bazel devs to attempt to fix this . On Thu, Mar 17, 2022 at 7:52 PM Sean Owen wrote: > Just checking - there is no way to

Re: bazel and external/

2022-03-17 Thread Sean Owen
Just checking - there is no way to tell bazel to look somewhere else for whatever 'external' means to it? It's a kinda big ugly change but it's not a functional change. If anything it might break some downstream builds that rely on the current structure too. But such is life for developers? I

bazel and external/

2022-03-17 Thread Alkis Evlogimenos
Hi Spark devs. The Apache Spark repo has a top level external/ directory. This is a reserved name for the bazel build system and it causes all sorts of problems: some can be worked around and some cannot (for some details on one that cannot see

Re: Apache Spark 3.3 Release

2022-03-17 Thread Tom Graves
Is the feature freeze target date March 22nd then?  I saw a few dates thrown around want to confirm what we landed on  I am trying to get the following improvements finished review and in, if concerns with either, let me know:- [SPARK-34079][SQL] Merge non-correlated scalar subqueries-

Re: Apache Spark 3.3 Release

2022-03-17 Thread Gengliang Wang
I'd like to add the following new SQL functions in the 3.3 release. These functions are useful when overflow or encoding errors occur: - [SPARK-38548][SQL] New SQL function: try_sum - [SPARK-38589][SQL] New SQL function: try_avg