Re: @scala.annotation.varargs or @_root_.scala.annotation.varargs?

2016-09-24 Thread Jacek Laskowski
On Sat, Sep 24, 2016 at 5:27 AM, Hyukjin Kwon wrote: > Then, are we going to submit a PR and fix this maybe? https://issues.apache.org/jira/browse/SPARK-17656 Thanks Hyukjin! Unless someone beats me to it, I'm going to have a PR over the weekend. Jacek

Re: @scala.annotation.varargs or @_root_.scala.annotation.varargs?

2016-09-23 Thread Hyukjin Kwon
t; >>> On Thu, Sep 8, 2016 at 9:27 AM, Sean Owen <so...@cloudera.com> > wrote: > >> >>> > I think the @_root_ version is redundant because > >> >>> > @scala.annotation.varargs is redundant. Actually wouldn't we just > >>

Re: @scala.annotation.varargs or @_root_.scala.annotation.varargs?

2016-09-09 Thread Sean Owen
n <so...@cloudera.com> wrote: >> >>> > I think the @_root_ version is redundant because >> >>> > @scala.annotation.varargs is redundant. Actually wouldn't we just >> >>> > import varargs and write @varargs? >> >>>

Re: @scala.annotation.varargs or @_root_.scala.annotation.varargs?

2016-09-08 Thread Reynold Xin
Yea but the earlier email was asking they were introduced in the first place. On Friday, September 9, 2016, Marcelo Vanzin wrote: > Not after SPARK-14642, right? > > On Thu, Sep 8, 2016 at 5:07 PM, Reynold Xin > wrote: > > There is a

Re: @scala.annotation.varargs or @_root_.scala.annotation.varargs?

2016-09-08 Thread Marcelo Vanzin
nk the @_root_ version is redundant because >>> > @scala.annotation.varargs is redundant. Actually wouldn't we just >>> > import varargs and write @varargs? >>> > >>> > On Thu, Sep 8, 2016 at 1:24 PM, Jacek Laskowski <ja...@japila.pl> >>>

Re: @scala.annotation.varargs or @_root_.scala.annotation.varargs?

2016-09-08 Thread Reynold Xin
dant. Actually wouldn't we just >> > import varargs and write @varargs? >> > >> > On Thu, Sep 8, 2016 at 1:24 PM, Jacek Laskowski <ja...@japila.pl >> <javascript:_e(%7B%7D,'cvml','ja...@japila.pl');>> wrote: >> >> Hi, >> >> >> &g

Re: @scala.annotation.varargs or @_root_.scala.annotation.varargs?

2016-09-08 Thread Hyukjin Kwon
t; import varargs and write @varargs? > > > > On Thu, Sep 8, 2016 at 1:24 PM, Jacek Laskowski <ja...@japila.pl> wrote: > >> Hi, > >> > >> The code is not consistent with @scala.annotation.varargs annotation. > >> There are classes with @

Re: @scala.annotation.varargs or @_root_.scala.annotation.varargs?

2016-09-08 Thread Jakob Odersky
ala.annotation.varargs annotation. >> There are classes with @scala.annotation.varargs like DataFrameReader >> or functions as well as examples of @_root_.scala.annotation.varargs, >> e.g. Window or UserDefinedAggregateFunction. >> >> I think it should be consistent and @scala

Re: @scala.annotation.varargs or @_root_.scala.annotation.varargs?

2016-09-08 Thread Sean Owen
otation.varargs annotation. > There are classes with @scala.annotation.varargs like DataFrameReader > or functions as well as examples of @_root_.scala.annotation.varargs, > e.g. Window or UserDefinedAggregateFunction. > > I think it should be consistent and @scala.annotation.varargs only.

@scala.annotation.varargs or @_root_.scala.annotation.varargs?

2016-09-08 Thread Jacek Laskowski
Hi, The code is not consistent with @scala.annotation.varargs annotation. There are classes with @scala.annotation.varargs like DataFrameReader or functions as well as examples of @_root_.scala.annotation.varargs, e.g. Window or UserDefinedAggregateFunction. I think it should be consistent