Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-10-11 Thread Dongjoon Hyun
It depends on the release manager's decision in general, but historically we skip the vote on old tags in favor of new RC tags. I believe Yuming will decide as the 3.3.1 release manager. On Tue, Oct 11, 2022 at 1:17 PM Jonathan Kelly wrote: > Ah, OK, I didn't realize that you were waiting for

Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-10-11 Thread Jonathan Kelly
Ah, OK, I didn't realize that you were waiting for something. Will the v3.3.1-rc3 tag be moved once SPARK-40703 is out? (Is that even possible?) Or will you just cut rc4 eventually and never vote on rc3? On Tue, Oct 11, 2022 at 1:14 PM Dongjoon Hyun wrote: > Yes, that's the current status. > >

Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-10-11 Thread Dongjoon Hyun
Yes, that's the current status. FYI, 3.3.1-rc3 tag was created 6 days ago but the vote was not started because we are waiting for https://issues.apache.org/jira/browse/SPARK-40703 Chao Sun pinged the release manager 4 days ago and has been working on it. Now, his PR is ready for 3.3.1 release

Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-10-11 Thread Jonathan Kelly
Yep, makes sense. Thanks for the quick response! On Tue, Oct 11, 2022 at 12:04 PM Sean Owen wrote: > Actually yeah that is how the release vote works by default at Apache: > https://www.apache.org/foundation/voting.html#ReleaseVotes > > However I would imagine there is broad consent to just

Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-10-11 Thread Sean Owen
Actually yeah that is how the release vote works by default at Apache: https://www.apache.org/foundation/voting.html#ReleaseVotes However I would imagine there is broad consent to just roll another RC if there's any objection or -1. We could formally re-check the votes, as I think the +1s would

Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-10-11 Thread Jonathan Kelly
Hi, Yuming, In your original email, you said that the vote "passes if a majority +1 PMC votes are cast, with a minimum of 3 +1 votes". There were four +1 votes (all from PMC members) and one -1 (also from a PMC member), so shouldn't the vote pass because both requirements (majority +1 and minimum

Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-10-05 Thread Yuming Wang
Hi All, Thank you all for testing and voting! There's a -1 vote here, so I think this RC fails. I will prepare for RC3 soon. On Tue, Oct 4, 2022 at 6:34 AM Mridul Muralidharan wrote: > +1 from me, with a few comments. > > I saw the following failures, are these known issues/flakey tests ? > >

Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-10-03 Thread Mridul Muralidharan
+1 from me, with a few comments. I saw the following failures, are these known issues/flakey tests ? * PersistenceEngineSuite.ZooKeeperPersistenceEngine Looks like a port conflict issue from a quick look into logs (conflict with starting admin port at 8080) - is this expected behavior for the

Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-10-03 Thread Dongjoon Hyun
Sorry, but -1 due to the undocumented breaking query result change. Apache Spark 3.2.0, 3.2.1, 3.2.2, 3.3.0 has the following result for `grouping_id()` and `grouping__id`. scala> sql("SELECT count(*), grouping__id from (VALUES (1,1,1),(2,2,2)) AS t(k1,k2,v) GROUP BY k1 GROUPING SETS (k2)

Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-10-03 Thread Gengliang Wang
+1. I ran some simple tests and also verified that SPARK-40389 is fixed. Gengliang On Mon, Oct 3, 2022 at 8:56 AM Thomas Graves wrote: > +1. ran out internal tests and everything looks good. > > Tom Graves > > On Wed, Sep 28, 2022 at 12:20 AM Yuming Wang wrote: > > > > Please vote on

Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-10-03 Thread Thomas Graves
+1. ran out internal tests and everything looks good. Tom Graves On Wed, Sep 28, 2022 at 12:20 AM Yuming Wang wrote: > > Please vote on releasing the following candidate as Apache Spark version > 3.3.1. > > The vote is open until 11:59pm Pacific time October 3th and passes if a > majority +1

Re: [VOTE] Release Spark 3.3.1 (RC2)

2022-09-28 Thread Sean Owen
+1 from me, same result as last RC. On Wed, Sep 28, 2022 at 12:21 AM Yuming Wang wrote: > Please vote on releasing the following candidate as Apache Spark version > 3.3.1. > > The vote is open until 11:59pm Pacific time October 3th and passes if a > majority +1 PMC votes are cast, with a

[VOTE] Release Spark 3.3.1 (RC2)

2022-09-27 Thread Yuming Wang
Please vote on releasing the following candidate as Apache Spark version 3.3.1. The vote is open until 11:59pm Pacific time October 3th and passes if a majority +1 PMC votes are cast, with a minimum of 3 +1 votes. [ ] +1 Release this package as Apache Spark 3.3.1 [ ] -1 Do not release this