Yes, I mean "open" for a long time, but I do mean PRs aren't intended
to be open for long periods. Of course, they actually stick around
forever on github.
I think Reynold did manually close yours, but I was noting for the
record that there's also an automated process that does this in
response to
Hi Mridul,
Thanks for the message. All you said made sense to me.
It can definitely be frustrating when one of your pull requests got
accidentally closed, and that's why we often ping the original authors to
close them. However, this doesn't always work because the original authors
might be inact
On the contrary, PR's are actually meant to be long lived - and a
reference of discussion about review and changes.
Particularly so for spark since JIRA's and review board are not used
for code review.
Note - they are not used only in spark, but by other organization's to
track contributions (like
There's a script that can be run manually which closes PRs that have
been 'requested' to be closed. I'm not sure of the exact words it
looks for but "Do you mind closing this PR?" seems to work. However it
does seem to mean that PRs will occasionally get closed as a false
positive, so maybe that ha
I am not sure of others, but I had a PR close from under me where
ongoing discussion was as late as 2 weeks back.
Given this, I assumed it was automated close and not manual !
When the change was opened is not a good metric about viability of the
change (particularly when it touches code which is
No there is not. I actually manually closed them to cut down the number of
open pull requests. Feel free to reopen individual ones.
On Wednesday, December 30, 2015, Mridul Muralidharan
wrote:
> Is there a script running to close "old" PR's ? I was not aware of any
> discussion about this in dev
Is there a script running to close "old" PR's ? I was not aware of any
discussion about this in dev list.
- Mridul
-
To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org
For additional commands, e-mail: dev-h...@spark.apache.
