Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-24 Thread shane knapp
> Another clarification: not databricks, but the Apache Spark PMC grants > access to the JIRA / wiki. That said... I'm not actually sure how its done. word. i'll make the changes if we need to. - To unsubscribe, e-mail:

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-24 Thread Michael Armbrust
> > i can't give you permissions -- that has to be (most likely) through > someone @ databricks, like michael. > Another clarification: not databricks, but the Apache Spark PMC grants access to the JIRA / wiki. That said... I'm not actually sure how its done.

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-24 Thread Dongjoon Hyun
Yep. Let's hold on. :) On Tue, May 24, 2016 at 3:45 PM, shane knapp wrote: > > Sure, could you give me the permission for Spark Jira? > > > > Although we haven't decided yet, I can add Travis related section > > (summarizing current configurations and expected VM HW, etc).

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-24 Thread shane knapp
> Sure, could you give me the permission for Spark Jira? > > Although we haven't decided yet, I can add Travis related section > (summarizing current configurations and expected VM HW, etc). > i can't give you permissions -- that has to be (most likely) through someone @ databricks, like michael.

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-24 Thread Dongjoon Hyun
Thank you, Shane. Sure, could you give me the permission for Spark Jira? Although we haven't decided yet, I can add Travis related section (summarizing current configurations and expected VM HW, etc). That will be helpful for further discussions. It's just a Wiki, you can delete the Travis

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-24 Thread shane knapp
> As Sean said, Vanzin made a PR for JDK7 compilation. We can ignore the issue > of JDK7 compilation. > vanzin and i are working together on this right now... we currently have java 7u79 installed on all of the workers. if some random test failures keep happening during his tests, i will roll

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-24 Thread Dongjoon Hyun
Hi, All. As Sean said, Vanzin made a PR for JDK7 compilation. We can ignore the issue of JDK7 compilation. The remaining issues are the java-linter and maven installation test. To: Michael For the rate limit, Apache Foundation seems to use 30 concurrent according to the INFRA blog.

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread Dongjoon Hyun
Thank you, Sean! On Mon, May 23, 2016 at 2:09 PM, Sean Owen wrote: > No, because then none of the Java 8 support can build. Marcelo has a JIRA > for handling that the right way with bootstrap class path config. > > Ideally it can be rolled into Jenkins though there are

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread Sean Owen
No, because then none of the Java 8 support can build. Marcelo has a JIRA for handling that the right way with bootstrap class path config. Ideally it can be rolled into Jenkins though there are possibly historical reasons it was not enabled before. Best to fix those if possible but if not I'd

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread Ted Yu
For #1 below, currently Jenkins uses Java 8: JAVA_HOME=/usr/java/jdk1.8.0_60 How about switching to Java 7 ? My two cents. On Mon, May 23, 2016 at 1:24 PM, Dongjoon Hyun wrote: > Thank you for your opinion! > > Sure. I know that history and totally agree with all your

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread Dongjoon Hyun
I want to clarify something here. For Travis CI, it's free for open source projects and there is only one management point, `.travis.xml`, for Spark community. It's not some like physical Jenkins cluster farm. It's just a cloud service like Github. PS. I'm also not an employee of Travis(or

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread Dongjoon Hyun
Thank you, Shane! I really hope that SparkPullRequestBuilder handle them if possible. Dongjoon. On Mon, May 23, 2016 at 1:24 PM, Dongjoon Hyun wrote: > Thank you for your opinion! > > Sure. I know that history and totally agree with all your concerns. > I indeed has

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread Dongjoon Hyun
Thank you for your opinion! Sure. I know that history and totally agree with all your concerns. I indeed has hesitated about sending this kind of suggestion for a while. If Travis CI cannot handle those simple jobs at this time again, we must turn off from Spark PR queue. We can see the result

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread shane knapp
chiming in, as i'm the one who currently maintains the CI infrastructure... :) +1 on not having more than one CI system... there's no way i can commit to keeping an eye on anything else other than jenkins. and i agree wholeheartedly w/michael: if it's this important, let's add it to the

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread Michael Armbrust
We did turn on travis a few years ago, but ended up turning it off because it was failing (I believe because of insufficient resources) which was confusing for developers. I wouldn't be opposed to turning it on if it provides more/faster signal, but its not obvious to me that it would. In

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread Dongjoon Hyun
Thank you, Steve and Hyukjin. And, don't worry, Ted. Travis launches new VMs for every PR. Apache Spark repository uses the following setting. VM: Google Compute Engine OS: Ubuntu 14.04.3 LTS Server Edition 64bit CPU: ~2 CORE RAM: 7.5GB FYI, you can find more information about this here.

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread Ted Yu
Do you know if more than one PR would be verified on the same machine ? I wonder whether the 'mvn install' from two simultaneous PR builds may have conflict. On Sun, May 22, 2016 at 9:21 PM, Dongjoon Hyun wrote: > Thank you for feedback. Sure, correctly, that's the reason

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread Hyukjin Kwon
+1 - I wouldn't be bothered if a build becomes longer if I can write cleaner codes without manually running it. I have just looked though the related PRs and JIRAs and it looks generally okay and reasonable to me. 2016-05-23 18:54 GMT+09:00 Steve Loughran : > > On 23

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-23 Thread Steve Loughran
On 23 May 2016, at 05:21, Dongjoon Hyun > wrote: Thank you for feedback. Sure, correctly, that's the reason why the current SparkPullRequestBuilder do not run `lint-java`. :-) In addition, that's the same reason why contributors are reluctant to

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-22 Thread Dongjoon Hyun
Thank you for feedback. Sure, correctly, that's the reason why the current SparkPullRequestBuilder do not run `lint-java`. :-) In addition, that's the same reason why contributors are reluctant to run `lint-java` and causes breaking on JDK7 builds. Such a tedious and time-consuming job should be

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-22 Thread Ted Yu
Without Zinc, 'mvn -DskipTests clean install' takes ~30 minutes. Maybe not everyone is willing to wait that long. On Sun, May 22, 2016 at 1:30 PM, Dongjoon Hyun wrote: > Oh, Sure. My bad! > > - For Oracle JDK7, mvn -DskipTests install and run `dev/lint-java`. > - For

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-22 Thread Dongjoon Hyun
Oh, Sure. My bad! - For Oracle JDK7, mvn -DskipTests install and run `dev/lint-java`. - For Oracle JDK8, mvn -DskipTests install and run `dev/lint-java`. Thank you, Ted. Dongjoon. On Sun, May 22, 2016 at 1:29 PM, Ted Yu wrote: > The following line was repeated twice: > >

Re: Using Travis for JDK7/8 compilation and lint-java.

2016-05-22 Thread Ted Yu
The following line was repeated twice: - For Oracle JDK7, mvn -DskipTests install and run `dev/lint-java`. Did you intend to cover JDK 8 ? Cheers On Sun, May 22, 2016 at 1:25 PM, Dongjoon Hyun wrote: > Hi, All. > > I want to propose the followings. > > - Turn on Travis

Using Travis for JDK7/8 compilation and lint-java.

2016-05-22 Thread Dongjoon Hyun
Hi, All. I want to propose the followings. - Turn on Travis CI for Apache Spark PR queue. - Recommend this for contributors, too Currently, Spark provides Travis CI configuration file to help contributors check Scala/Java style conformance and JDK7/8 compilation easily during their preparing