Re: bazel and external/

We might want to keep this open for another several days to see more voices or support here, since it just went through 4 days including weekend. But I'm happy with the change (+1 from me), given the new name makes much more sense than before. For me, this is pure improvement even without the cont

Re: bazel and external/

The PR is updated to rename the directory to `connectors`. If there are no other objections can we merge it? On Mon, Mar 21, 2022 at 1:42 PM Alkis Evlogimenos < alkis.evlogime...@databricks.com> wrote: > Unless there are objections, I will update the PR tonight to rename > `external` to `connecto

Re: bazel and external/

Unless there are objections, I will update the PR tonight to rename `external` to `connectors`. On Mon, Mar 21, 2022 at 12:36 PM Wenchen Fan wrote: > How about renaming it to `connectors` if docker is the only exception and > will be moved out? > > On Sat, Mar 19, 2022 at 6:18 PM Alkis Evlogimen

Re: bazel and external/

How about renaming it to `connectors` if docker is the only exception and will be moved out? On Sat, Mar 19, 2022 at 6:18 PM Alkis Evlogimenos wrote: > It looks like renaming the directory and moving components can be separate > steps. If there is consensus that connectors will move out, should

Re: bazel and external/

It looks like renaming the directory and moving components can be separate steps. If there is consensus that connectors will move out, should the directory be named misc for everything else until there is some direction for the remaining modules? On Fri, 18 Mar 2022 at 03:03 Jungtaek Lim wrote:

Re: bazel and external/

Avro reader is technically a connector. We eventually called data source implementation "connector" as well; the package name in the catalyst represents it. Docker is something I'm not sure fits with the name "external". It probably deserves a top level directory now, since we start to release an

Re: bazel and external/

I sympathize, but might be less change to just rename the dir. There is more in there like the avro reader; it's kind of miscellaneous. I think we might want fewer rather than more top level dirs. On Thu, Mar 17, 2022 at 7:33 PM Jungtaek Lim wrote: > We seem to just focus on how to avoid the con

Re: bazel and external/

We seem to just focus on how to avoid the conflict with the name "external" used in bazel. Since we consider the possibility of renaming, why not revisit the modules "external" contains? Looks like kinds of the modules external directory contains are 1) Docker 2) Connectors 3) Sink on Dropwizard m

Re: bazel and external/

Thank you for posting this, Alkis. Before the question (1) and (2), I'm curious if the Apache Spark community has other downstreams using Bazel. To All. If there are some Bazel users with Apache Spark code, could you share your practice? If you are using renaming, what is your renamed directory n

Re: bazel and external/

AFAIK there is not. `external` has been baked in bazel since the beginning and there is no plan from bazel devs to attempt to fix this . On Thu, Mar 17, 2022 at 7:52 PM Sean Owen wrote: > Just checking - there is no way to t

Re: bazel and external/

Just checking - there is no way to tell bazel to look somewhere else for whatever 'external' means to it? It's a kinda big ugly change but it's not a functional change. If anything it might break some downstream builds that rely on the current structure too. But such is life for developers? I don't

bazel and external/

Hi Spark devs. The Apache Spark repo has a top level external/ directory. This is a reserved name for the bazel build system and it causes all sorts of problems: some can be worked around and some cannot (for some details on one that cannot see https://github.com/hedronvision/bazel-compile-command