Re: withExpr private method duplication in Column and functions objects?

2016-11-11 Thread Reynold Xin
private[sql] has no impact in Java, and these functions are literally one line of code. It's overkill to think about code duplication for functions that simple. On Fri, Nov 11, 2016 at 1:12 PM, Jacek Laskowski wrote: > Hi, > > Any reason for withExpr duplication in Column [1]

withExpr private method duplication in Column and functions objects?

2016-11-11 Thread Jacek Laskowski
Hi, Any reason for withExpr duplication in Column [1] and functions [2] objects? It looks like it could be less private and be at least private[sql]? private def withExpr(newExpr: Expression): Column = new Column(newExpr) [1]