Re: Review Request 12032: Incremental import using lastmodified mode always assumes column type to be timestamp, this patch fixes that

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12032/ --- (Updated July 11, 2013, 7:13 p.m.) Review request for Sqoop. Changes ---

[jira] [Commented] (SQOOP-1115) Sqoop2: Integration: Provide helper methods for synchronous job submission

[ https://issues.apache.org/jira/browse/SQOOP-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706549#comment-13706549 ] ASF subversion and git services commented on SQOOP-1115: Commit 2e

Re: Review Request 12202: SQOOP-1115 Sqoop2: Integration: Provide helper methods for synchronous job submission

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12202/#review23045 --- Ship it! Ship It! - Hari Shreedharan On June 30, 2013, 6:54 p.m.

Re: Review Request 12201: SQOOP-1114 Sqoop2: Integration: Add tests for various Generic JDBC Connector splitters

> On July 12, 2013, 12:32 a.m., Hari Shreedharan wrote: > > Jarcec, > > > > This test really does not test if the input data was really split. It only > > tests that the input data was received on the other side. We need to ensure > > that the data was indeed split and each split was really pr

Re: Review Request 12201: SQOOP-1114 Sqoop2: Integration: Add tests for various Generic JDBC Connector splitters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12201/#review23042 --- Jarcec, This test really does not test if the input data was really

[jira] [Commented] (SQOOP-672) Unify logger usage across entire code base

[ https://issues.apache.org/jira/browse/SQOOP-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706516#comment-13706516 ] ASF subversion and git services commented on SQOOP-672: --- Commit 1f016

[jira] [Commented] (SQOOP-1111) Sqoop2: Implement version detection and structure updates into Derby repository

[ https://issues.apache.org/jira/browse/SQOOP-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706510#comment-13706510 ] ASF subversion and git services commented on SQOOP-: Commit 76

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

> On July 11, 2013, 9:54 p.m., Jarek Cecho wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java, > > line 184 > > > > > > I'm concerned a bit of u

[jira] [Commented] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706477#comment-13706477 ] Hudson commented on SQOOP-1001: --- Integrated in Sqoop2-hadoop100 #482 (See [https://builds.a

[jira] [Commented] (SQOOP-1130) Sqoop2: Sqoop MapReduce Job Failed when max and min boundary are both null

[ https://issues.apache.org/jira/browse/SQOOP-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706476#comment-13706476 ] Hudson commented on SQOOP-1130: --- Integrated in Sqoop2-hadoop100 #482 (See [https://builds.a

[jira] [Commented] (SQOOP-1130) Sqoop2: Sqoop MapReduce Job Failed when max and min boundary are both null

[ https://issues.apache.org/jira/browse/SQOOP-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706457#comment-13706457 ] Hudson commented on SQOOP-1130: --- Integrated in Sqoop2-hadoop200 #460 (See [https://builds.a

[jira] [Commented] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706458#comment-13706458 ] Hudson commented on SQOOP-1001: --- Integrated in Sqoop2-hadoop200 #460 (See [https://builds.a

[jira] [Commented] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706447#comment-13706447 ] Jarek Jarcec Cecho commented on SQOOP-1001: --- Thank you [~raghavgautam]!

[jira] [Assigned] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho reassigned SQOOP-1001: - Assignee: Raghav Kumar Gautam > Sqoop2: Document methods for overriding serve

[jira] [Commented] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706446#comment-13706446 ] ASF subversion and git services commented on SQOOP-1001: Commit de

[jira] [Commented] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706443#comment-13706443 ] Jarek Jarcec Cecho commented on SQOOP-1001: --- The patch is quite simple, so I'm g

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

> On July 11, 2013, 9:54 p.m., Jarek Cecho wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java, > > line 184 > > > > > > I'm concerned a bit of u

[jira] [Updated] (SQOOP-1111) Sqoop2: Implement version detection and structure updates into Derby repository

[ https://issues.apache.org/jira/browse/SQOOP-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-: -- Attachment: bugSQOOP-.patch > Sqoop2: Implement version detection and structure

Re: Review Request 12196: SQOOP-1111 Sqoop2: Implement version detection and structure updates into Derby repository

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12196/ --- (Updated July 11, 2013, 11:25 p.m.) Review request for Sqoop. Changes ---

Re: Review Request 12196: SQOOP-1111 Sqoop2: Implement version detection and structure updates into Derby repository

> On July 11, 2013, 9:58 p.m., Hari Shreedharan wrote: > > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java, lines > > 126-149 > > > > > > I will create a jira for this, but I think these methods sho

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

> On July 11, 2013, 9:54 p.m., Jarek Cecho wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java, > > line 184 > > > > > > I'm concerned a bit of u

[jira] [Created] (SQOOP-1135) Sqoop2: Rename queries in Derby repository to have the same naming scheme

Jarek Jarcec Cecho created SQOOP-1135: - Summary: Sqoop2: Rename queries in Derby repository to have the same naming scheme Key: SQOOP-1135 URL: https://issues.apache.org/jira/browse/SQOOP-1135 Pro

[jira] [Updated] (SQOOP-1134) Sqoop2: Introduce better repository method names than createOrUpdateInternals and haveSuitableInternals

[ https://issues.apache.org/jira/browse/SQOOP-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-1134: -- Priority: Minor (was: Major) > Sqoop2: Introduce better repository method names th

[jira] [Created] (SQOOP-1134) Sqoop2: Introduce better repository method names than createOrUpdateInternals and haveSuitableInternals

Jarek Jarcec Cecho created SQOOP-1134: - Summary: Sqoop2: Introduce better repository method names than createOrUpdateInternals and haveSuitableInternals Key: SQOOP-1134 URL: https://issues.apache.org/jira/brow

Re: Review Request 12032: Incremental import using lastmodified mode always assumes column type to be timestamp, this patch fixes that

> On July 11, 2013, 3:24 p.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/tool/ImportTool.java, line 286 > > > > > > This can be further simplified to > > manager.getColumnTypes(options.getTableName(), > > opti

[jira] [Commented] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706384#comment-13706384 ] Sqoop QA bot commented on SQOOP-1001: - Here are the results of testing the latest atta

[jira] [Commented] (SQOOP-1130) Sqoop2: Sqoop MapReduce Job Failed when max and min boundary are both null

[ https://issues.apache.org/jira/browse/SQOOP-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706357#comment-13706357 ] ASF subversion and git services commented on SQOOP-1130: Commit a3

Re: Review Request 12449: SQOOP-1130: Sqoop2: Sqoop MapReduce Job Failed when max and min boundary are both null

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12449/#review23032 --- Ship it! Ship It! - Jarek Cecho On July 10, 2013, 6:51 p.m., Men

[jira] [Commented] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706353#comment-13706353 ] Raghav Kumar Gautam commented on SQOOP-1001: New patch uploaded.

[jira] [Updated] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raghav Kumar Gautam updated SQOOP-1001: --- Attachment: SQOOP-1001.txt > Sqoop2: Document methods for overriding server port

Re: Review Request 12032: Incremental import using lastmodified mode always assumes column type to be timestamp, this patch fixes that

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12032/#review23031 --- Hi Raghav, thank you very much for incorporating my suggestion, grea

[jira] [Commented] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706308#comment-13706308 ] Jarek Jarcec Cecho commented on SQOOP-1001: --- Hi [~raghavgautam], thank you very

Re: Review Request 12196: SQOOP-1111 Sqoop2: Implement version detection and structure updates into Derby repository

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12196/#review23029 --- Ship it! Looks good, couple of nits. can you fix and attach patch t

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12451/#review23028 --- Hi Mengwei, thank you very much for identifying this issue and provi

[jira] [Commented] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706278#comment-13706278 ] Sqoop QA bot commented on SQOOP-1001: - Here are the results of testing the latest atta

[jira] [Created] (SQOOP-1133) Sqoop2: Integration: Add NULL values into testing data sets

Jarek Jarcec Cecho created SQOOP-1133: - Summary: Sqoop2: Integration: Add NULL values into testing data sets Key: SQOOP-1133 URL: https://issues.apache.org/jira/browse/SQOOP-1133 Project: Sqoop

[jira] [Updated] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raghav Kumar Gautam updated SQOOP-1001: --- Attachment: SQOOP-1001.txt > Sqoop2: Document methods for overriding server port

Re: Review Request 10964: SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running on MiniCluster

> On July 9, 2013, 6:14 p.m., Jarek Cecho wrote: > > test/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniCluster.java, > > lines 50-51 > > > > > > The getDataDir seems to be overloaded. Here it's used for local f

Re: Review Request 10964: SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running on MiniCluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10964/#review23015 --- Hi Abe, thank you very much for incorporating all my suggestions! I

[jira] [Commented] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706193#comment-13706193 ] Jarek Jarcec Cecho commented on SQOOP-1001: --- Hi [~raghavgautam], thank you very

[jira] [Commented] (SQOOP-1001) Sqoop2: Document methods for overriding server port

[ https://issues.apache.org/jira/browse/SQOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706164#comment-13706164 ] Raghav Kumar Gautam commented on SQOOP-1001: Environment variable SQOOP_HTTP_P

[jira] [Commented] (SQOOP-1124) Direct export to PostgreSQL with PGBulkloadManager fails without explicit port number settings

[ https://issues.apache.org/jira/browse/SQOOP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705970#comment-13705970 ] Hudson commented on SQOOP-1124: --- Integrated in Sqoop-ant-jdk-1.6-hadoop100 #756 (See [https

[jira] [Commented] (SQOOP-1124) Direct export to PostgreSQL with PGBulkloadManager fails without explicit port number settings

[ https://issues.apache.org/jira/browse/SQOOP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705968#comment-13705968 ] Hudson commented on SQOOP-1124: --- Integrated in Sqoop-ant-jdk-1.6-hadoop23 #995 (See [https:

[jira] [Commented] (SQOOP-1124) Direct export to PostgreSQL with PGBulkloadManager fails without explicit port number settings

[ https://issues.apache.org/jira/browse/SQOOP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705961#comment-13705961 ] Hudson commented on SQOOP-1124: --- Integrated in Sqoop-ant-jdk-1.6-hadoop200 #804 (See [https

[jira] [Commented] (SQOOP-1124) Direct export to PostgreSQL with PGBulkloadManager fails without explicit port number settings

[ https://issues.apache.org/jira/browse/SQOOP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705957#comment-13705957 ] Hudson commented on SQOOP-1124: --- Integrated in Sqoop-ant-jdk-1.6-hadoop20 #795 (See [https:

[jira] [Resolved] (SQOOP-1124) Direct export to PostgreSQL with PGBulkloadManager fails without explicit port number settings

[ https://issues.apache.org/jira/browse/SQOOP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho resolved SQOOP-1124. --- Resolution: Fixed Fix Version/s: 1.4.4 Thank you for your contribution [~iwasa

[jira] [Commented] (SQOOP-1124) Direct export to PostgreSQL with PGBulkloadManager fails without explicit port number settings

[ https://issues.apache.org/jira/browse/SQOOP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705920#comment-13705920 ] ASF subversion and git services commented on SQOOP-1124: Commit ab

[jira] [Commented] (SQOOP-1096) Sqoop generates bounding vals queries with synatx error, when the number of mappers is greater than 1 and there is WITH UR option in the query for DB2

[ https://issues.apache.org/jira/browse/SQOOP-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705895#comment-13705895 ] Jarek Jarcec Cecho commented on SQOOP-1096: --- Hi [~thomastechs], it seems that yo

[jira] [Updated] (SQOOP-1124) Direct export to PostgreSQL with PGBulkloadManager fails without explicit port number settings

[ https://issues.apache.org/jira/browse/SQOOP-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated SQOOP-1124: Attachment: SQOOP-1124-1.patch attaching reviewed patch. > Direct export t