Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

> On Nov. 21, 2018, 2:05 p.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java > > Lines 1 (patched) > > > > > > Apache headers are missing from new files.

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 3 p.m.) Review request for Sqoop, Boglarka Egyed and Sz

[jira] [Commented] (SQOOP-3406) Sqoop should not try to execute test category interfaces as tests with Ant

[ https://issues.apache.org/jira/browse/SQOOP-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694780#comment-16694780 ] Hudson commented on SQOOP-3406: --- FAILURE: Integrated in Jenkins build Sqoop-hadoop200 #1230

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/#review210762 --- Fix it, then Ship it! Hi Fero, Your change generally looks goo

[jira] [Commented] (SQOOP-3406) Sqoop should not try to execute test category interfaces as tests with Ant

[ https://issues.apache.org/jira/browse/SQOOP-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694732#comment-16694732 ] ASF subversion and git services commented on SQOOP-3406: Commit 6

Re: Review Request 69414: Sqoop should not try to execute test category interfaces as tests with Ant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69414/#review210763 --- Ship it! Ship It! - Fero Szabo On Nov. 21, 2018, 12:22 p.m.,

[jira] [Commented] (SQOOP-3407) Introduce methods instead of TEMP_BASE_DIR and LOCAL_WAREHOUSE_DIR static fields

[ https://issues.apache.org/jira/browse/SQOOP-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694679#comment-16694679 ] Hudson commented on SQOOP-3407: --- FAILURE: Integrated in Jenkins build Sqoop-hadoop200 #1229

Re: Review Request 69414: Sqoop should not try to execute test category interfaces as tests with Ant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69414/#review210757 --- Ship it! Ship It! - Boglarka Egyed On Nov. 21, 2018, 12:22 p

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/#review210756 --- Ship it! Hi Feró, Thank you for improving these tests, unit an

[jira] [Comment Edited] (SQOOP-3407) Introduce methods instead of TEMP_BASE_DIR and LOCAL_WAREHOUSE_DIR static fields

[ https://issues.apache.org/jira/browse/SQOOP-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694648#comment-16694648 ] Fero Szabo edited comment on SQOOP-3407 at 11/21/18 12:22 PM: -

[jira] [Commented] (SQOOP-3407) Introduce methods instead of TEMP_BASE_DIR and LOCAL_WAREHOUSE_DIR static fields

[ https://issues.apache.org/jira/browse/SQOOP-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694644#comment-16694644 ] ASF subversion and git services commented on SQOOP-3407: Commit 2

Re: Review Request 69413: Introduce methods instead of TEMP_BASE_DIR and LOCAL_WAREHOUSE_DIR static fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69413/#review210755 --- Ship it! Hi Szabolcs, Thanks for this fix! Unit and 3rd party

Re: Review Request 69414: Sqoop should not try to execute test category interfaces as tests with Ant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69414/ --- (Updated Nov. 21, 2018, 12:22 p.m.) Review request for Sqoop. Bugs: SQOOP-340

Re: Review Request 69413: Introduce methods instead of TEMP_BASE_DIR and LOCAL_WAREHOUSE_DIR static fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69413/#review210754 --- Ship it! Lgtm. - Fero Szabo On Nov. 20, 2018, 5:29 p.m., Sza

Re: Review Request 69414: Sqoop should not try to execute test category interfaces as tests with Ant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69414/#review210753 --- build.xml Lines 950 (patched)

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 10:20 a.m.) Review request for Sqoop, Boglarka Egyed an

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 9:31 a.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 9:29 a.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 9:07 a.m.) Review request for Sqoop, Boglarka Egyed and