e.org/media/uploaded/files/2018/08/28/7058a562-ccef-4ca3-8b58-bd6a6e6ec377__SQOOP-3104.patch
Test order in my machine
https://reviews.apache.org/media/uploaded/files/2018/09/08/4af4030f-1230-402b-99c7-51d2d37da524__SqoopTestOrder.txt
Thanks,
Nguyen Truong
-51d2d37da524__SqoopTestOrder.txt
Thanks,
Nguyen Truong
machine
https://reviews.apache.org/media/uploaded/files/2018/09/08/4af4030f-1230-402b-99c7-51d2d37da524__SqoopTestOrder.txt
Thanks,
Nguyen Truong
files/2018/08/28/7058a562-ccef-4ca3-8b58-bd6a6e6ec377__SQOOP-3104.patch
Thanks,
Nguyen Truong
ks a lot for your JUnit fix, I will apply your fix to the my next updated
diff.
Best,
Nguyen
- Nguyen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68541/#review208094
-
util files so I did not check them. Will update.
Thanks!
- Nguyen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68541/#review208128
---------
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68541/#review208094
-------
On Aug. 28, 2018, 3:52 p.m., Nguyen Truong wrote:
>
> ---
ate the decription of it in my next patch.
- Nguyen
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68541/#review208172
---
/28/7058a562-ccef-4ca3-8b58-bd6a6e6ec377__SQOOP-3104.patch
Thanks,
Nguyen Truong
tests and everything ran fine.
Thank you for your contribution.
Best,
Nguyen
- Nguyen Truong
On Aug. 27, 2018, 8:46 a.m., Szabolcs Vasas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68470/#review207818
-------
On Aug. 23, 2018, 3:54 p.m., Nguyen Truong wrote:
>
> -
has been added.
Thanks,
Nguyen Truong
/HsqldbTestServer.java c63a8f2dc
src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c342
Diff: https://reviews.apache.org/r/68470/diff/2/
Changes: https://reviews.apache.org/r/68470/diff/1-2/
Testing
---
No test has been added.
Thanks,
Nguyen Truong
test PostgresMetaConnectIncrementalImportTest failed when I ran the third
party test suite but succeeded when I ran it again alone. I guess it was not
because of your patch though.
Best,
Nguyen
- Nguyen Truong
On Aug. 16, 2018, 2:37 p.m., Szabolcs Vasas wrote
/testutil/HsqldbTestServer.java c63a8f2dc
Diff: https://reviews.apache.org/r/68470/diff/1/
Testing
---
No test has been added.
Thanks,
Nguyen Truong
[
https://issues.apache.org/jira/browse/SQOOP-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Truong updated SQOOP-3362:
-
Attachment: SQOOP-3362.patch
> Fix toString() methods of OraOopOracleDataCh
[
https://issues.apache.org/jira/browse/SQOOP-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Truong updated SQOOP-3362:
-
Summary: Fix toString() methods of OraOopOracleDataChunk (was: Debug
toString() methods of
TestOraOopDBInputSplitGetDebugDetails.
Thanks,
Nguyen Truong
TestOraOopDBInputSplitGetDebugDetails.
Thanks,
Nguyen Truong
, visit:
https://reviews.apache.org/r/68316/#review207314
-----------
On Aug. 14, 2018, 12:53 p.m., Nguyen Truong wrote:
>
> ---
> This is an automatically gener
ly solution because I prefer implementing methods
inside subclasses rather than inside the superclass.
Best,
Nguyen
- Nguyen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/683
covered.
Thanks,
Nguyen Truong
/OraOopOracleDataChunkPartition.java
59889b82b
Diff: https://reviews.apache.org/r/68316/diff/2/
Changes: https://reviews.apache.org/r/68316/diff/1-2/
Testing
---
No test case is added because the change has already covered.
Thanks,
Nguyen Truong
/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java
59889b82b4d166098f3de40cb1e95a39bcc74bd7
Diff: https://reviews.apache.org/r/68316/diff/1/
Testing
---
No test case is added because the change has already covered.
Thanks,
Nguyen Truong
[
https://issues.apache.org/jira/browse/SQOOP-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Truong updated SQOOP-3362:
-
Description: The method is currently returning the hash of data chunk
object. It would be nice
[
https://issues.apache.org/jira/browse/SQOOP-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Truong updated SQOOP-3362:
-
Summary: Debug toString() methods of OraOopOracleDataChunk (was: Debug
toString methods of
Nguyen Truong created SQOOP-3362:
Summary: Debug toString methods of OraOopOracleDataChunk
Key: SQOOP-3362
URL: https://issues.apache.org/jira/browse/SQOOP-3362
Project: Sqoop
Issue Type
://reviews.apache.org/r/68278/diff/3/
Changes: https://reviews.apache.org/r/68278/diff/2-3/
Testing
---
Thanks,
Nguyen Truong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/#review207030
-------
On Aug. 9, 2018, 1:53 p.m., Nguyen Truong wrote:
>
>
: https://reviews.apache.org/r/68278/diff/2/
Changes: https://reviews.apache.org/r/68278/diff/1-2/
Testing
---
Thanks,
Nguyen Truong
/
Testing
---
Thanks,
Nguyen Truong
[
https://issues.apache.org/jira/browse/SQOOP-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Truong updated SQOOP-3359:
-
Summary: Add LOG message for Git hash (was: Add LOG for Git hash)
> Add LOG message for
[
https://issues.apache.org/jira/browse/SQOOP-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Truong updated SQOOP-3359:
-
Summary: Add LOG message for git hash (was: Add LOG message for Git hash)
> Add LOG message
[
https://issues.apache.org/jira/browse/SQOOP-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Truong reassigned SQOOP-3359:
Assignee: Nguyen Truong
> Add LOG for Git h
[
https://issues.apache.org/jira/browse/SQOOP-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Truong reassigned SQOOP-3357:
Assignee: Nguyen Truong
> Change MainframeImportTool to refer to MainframeManager cl
Nguyen Truong created SQOOP-3359:
Summary: Add LOG for Git hash
Key: SQOOP-3359
URL: https://issues.apache.org/jira/browse/SQOOP-3359
Project: Sqoop
Issue Type: Improvement
/apache/sqoop/manager/TestMainframeManager.java 97e48e88
Diff: https://reviews.apache.org/r/68254/diff/1/
Testing
---
I ran ant test and did not add any more test case because my change was already
covered.
Thanks,
Nguyen Truong
[
https://issues.apache.org/jira/browse/SQOOP-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Truong updated SQOOP-3357:
-
Attachment: SQOOP-3357.patch
> Change MainframeImportTool to refer to MainframeManager cl
Nguyen Truong created SQOOP-3357:
Summary: Change MainframeImportTool to refer to MainframeManager
class directly
Key: SQOOP-3357
URL: https://issues.apache.org/jira/browse/SQOOP-3357
Project: Sqoop
39 matches
Mail list logo
