Re: Review Request 8559: Add Accumulo support to Sqoop

2013-11-05 Thread Sean Busbey
/ToStringMutationTransformer.java <https://reviews.apache.org/r/8559/#comment54900> It's worth a follow on ticket to control the character set rather than relying on the platform default, since it could vary across clients. FWIW, HBase relies on the hbase.util.Bytes class to specify UTF-8. - Sean

Re: Review Request 8559: Add Accumulo support to Sqoop

2013-11-04 Thread Sean Busbey
it's obviously not threadsafe when future maintainers look at it. (sorry for the thrashing) - Sean Busbey On Nov. 4, 2013, 11 p.m., Philip Grim wrote: > > -

Re: Review Request 8559: Add Accumulo support to Sqoop

2013-11-04 Thread Sean Busbey
> On Nov. 2, 2013, 5:04 p.m., Sean Busbey wrote: > > src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java, lines > > 131-141 > > <https://reviews.apache.org/r/8559/diff/6/?file=373821#file373821line131> > > > > Just curious, is there

Re: Review Request 8559: Add Accumulo support to Sqoop

2013-11-02 Thread Sean Busbey
do reference counting so that stopping can happen in the tearDown method. ( http://bit.ly/182jsOe and http://bit.ly/1iCYeeE ) - Sean Busbey On Oct. 29, 2013, 9:22 p.m., Philip Grim wrote: > > --- > This is

Re: Review Request 8559: Add Accumulo support to Sqoop

2013-11-02 Thread Sean Busbey
> On Oct. 24, 2013, 5:09 p.m., Sean Busbey wrote: > > src/test/org/apache/sqoop/accumulo/TestAccumuloImport.java, lines 42-58 > > <https://reviews.apache.org/r/8559/diff/5/?file=370079#file370079line42> > > > > Could you rewrite this to use the @Tes

Re: Review Request 8559: Add Accumulo support to Sqoop

2013-10-24 Thread Sean Busbey
s) form? src/test/org/apache/sqoop/accumulo/TestAccumuloQueryImport.java <https://reviews.apache.org/r/8559/#comment53378> Could you rewrite this to use the @Test(expects=IOException.class) form? - Sean Busbey On Oct. 23, 2013, 9:24 p.m