Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/ --- (Updated July 13, 2018, 8:06 a.m.) Review request for Sqoop, Attila Szabo and S

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/#review186055 --- All test's passed. - Sandish Kumar HN On July 3, 2017, 5:36 a.m

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/ --- (Updated July 3, 2017, 5:36 a.m.) Review request for Sqoop, Attila Szabo and Sz

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

> On April 20, 2017, 1:08 p.m., Liz Szilagyi wrote: > > Hi Eric, > > Looks like you have addressed all previous concerns, yet they remain open > > issues - are you planning to do more changes to further address these > > questions? > > Thanks, > > Liz Hi Liz, thanks for your update. I thought

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/#review172478 --- Hi Eric, Looks like you have addressed all previous concerns, yet

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

> On March 20, 2017, 4:07 p.m., Attila Szabo wrote: > > Hey Eric, > > > > For the first shot I do understand you motivation here, and also attached > > some comments/requests around the implementation. > > > > Although I'm a bit concerned about the big picture as well B/C I do feel in > > the

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/ --- (Updated March 28, 2017, 4:35 a.m.) Review request for Sqoop, Attila Szabo and

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

> On March 20, 2017, 4:07 p.m., Attila Szabo wrote: > > Hey Eric, > > > > For the first shot I do understand you motivation here, and also attached > > some comments/requests around the implementation. > > > > Although I'm a bit concerned about the big picture as well B/C I do feel in > > the

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/#review169453 --- Hey Eric, For the first shot I do understand you motivation here,

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/#review169404 --- Ship it! Ship It! - Boglarka Egyed On March 20, 2017, 8:54 a

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/ --- (Updated March 20, 2017, 8:54 a.m.) Review request for Sqoop, Attila Szabo and

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

> On March 20, 2017, 8:18 a.m., Boglarka Egyed wrote: > > src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java > > Lines 256 (patched) > > > > > > Thanks for splitting up the test case, however, could you please

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

> On March 20, 2017, 8:18 a.m., Boglarka Egyed wrote: > > Hi Eric, > > > > Thanks for the corrections. > > > > I ran 'ant clean test' with your patch and TestHiveImport failed for me so > > please review your changes there. > > > > Besides that, I had some minor findings related to naming con

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/#review169389 --- Hi Eric, Thanks for the corrections. I ran 'ant clean test' with

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/ --- (Updated March 20, 2017, 8:13 a.m.) Review request for Sqoop, Attila Szabo and

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/ --- (Updated March 20, 2017, 3:16 a.m.) Review request for Sqoop, Attila Szabo and

Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/#review169364 --- Hi Eric, Thanks for your contribution! I had some minor findings

Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/ --- Review request for Sqoop, Attila Szabo and Szabolcs Vasas. Repository: sqoop-tr