Re: STDCXX-1056 : numpunct fix

2012-09-25 Thread Liviu Nicoara
On 09/24/12 22:28, Martin Sebor wrote: On 09/20/2012 06:46 PM, Stefan Teleman wrote: On Thu, Sep 20, 2012 at 8:39 PM, Liviu Nicoara wrote: I have not created this requirement out of thin air. STDCXX development has functioned in this manner for as long as I remember. If it does not suit you,

Re: STDCXX-1056 : numpunct fix

2012-09-25 Thread Liviu Nicoara
On 09/24/12 23:50, Stefan Teleman wrote: On Mon, Sep 24, 2012 at 10:03 PM, Martin Sebor wrote: FWIW, there are race conditions in stdcxx. Some of them are by design and benign on the systems the library runs on (although I acknowledge that some others may be bugs). One such benign date race is:

Re: STDCXX-1056 : numpunct fix

2012-09-25 Thread Stefan Teleman
On Tue, Sep 25, 2012 at 7:41 AM, Liviu Nicoara wrote: > Caching failures aside, we have no failing tests. Before saying they are > malign you need to objectively show a failing program. > > Martin's example above is a read-write race. In the absence of a failing > test case it is quite unreasona

STDCXX-1070

2012-09-25 Thread Liviu Nicoara
I filed 1070, failure to build 22.locale.collate.cpp on Linux with gcc 4.7.1. Gcc, Comeau and Clang fail to compile it, Intel and Sun are fine. It looks to me like Intel and Sun compilers are not doing the right thing. A small test case and a patch have been attached. The failing code has been

Re: STDCXX-1070

2012-09-25 Thread Martin Sebor
On 09/25/2012 02:46 PM, Liviu Nicoara wrote: I filed 1070, failure to build 22.locale.collate.cpp on Linux with gcc 4.7.1. Gcc, Comeau and Clang fail to compile it, Intel and Sun are fine. It looks to me like Intel and Sun compilers are not doing the right thing. A small test case and a patch hav

Re: STDCXX-1070

2012-09-25 Thread Liviu Nicoara
On 9/25/12 7:50 PM, Martin Sebor wrote: On 09/25/2012 02:46 PM, Liviu Nicoara wrote: I filed 1070, failure to build 22.locale.collate.cpp on Linux with gcc 4.7.1. Gcc, Comeau and Clang fail to compile it, Intel and Sun are fine. It looks to me like Intel and Sun compilers are not doing the right

Re: [jira] [Closed] (STDCXX-1056) std::moneypunct and std::numpunct implementations are not thread-safe

2012-09-25 Thread Liviu Nicoara
On 9/25/12 7:56 PM, Stefan Teleman (JIRA) wrote: [ https://issues.apache.org/jira/browse/STDCXX-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan, I don't think it's ok to close this bug. The race conditions are there and we have not come to a completely

Re: [jira] [Closed] (STDCXX-1056) std::moneypunct and std::numpunct implementations are not thread-safe

2012-09-25 Thread Wojciech Meyer
Hi guys, I think the consensus about this bug is that everybody wants to fix it. Stefan has a patch but I got completely lost what is the exact reason of not applying it. It would be a shame to stop at this point. Liviu Nicoara writes: > On 9/25/12 7:56 PM, Stefan Teleman (JIRA) wrote: >> >>

Re: [jira] [Closed] (STDCXX-1056) std::moneypunct and std::numpunct implementations are not thread-safe

2012-09-25 Thread Stefan Teleman
On Tue, Sep 25, 2012 at 8:05 PM, Liviu Nicoara wrote: > On 9/25/12 7:56 PM, Stefan Teleman (JIRA) wrote: >> >> >> [ >> https://issues.apache.org/jira/browse/STDCXX-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] > > > Stefan, > > I don't think it's ok to close thi

Re: [jira] [Closed] (STDCXX-1066) SPARCV8 requires pthread_mutex_t and pthread_cond_t to be aligned on an 8-byte boundary

2012-09-25 Thread Liviu Nicoara
On 9/25/12 7:56 PM, Stefan Teleman (JIRA) wrote: [ https://issues.apache.org/jira/browse/STDCXX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anybody around here, except Stefan, who has access to a SPARC V8 machine updated to the specified kernel update or l

Re: STDCXX-1056 : numpunct fix

2012-09-25 Thread Liviu Nicoara
On 9/24/12 11:06 PM, Stefan Teleman wrote: On Mon, Sep 24, 2012 at 7:48 PM, Liviu Nicoara wrote: Stefan, was it your intention to completely eliminate all the race conditions with this last patch? Is this what the tools showed in your environment? https://issues.apache.org/jira/browse/STDCX

Re: [jira] [Closed] (STDCXX-1056) std::moneypunct and std::numpunct implementations are not thread-safe

2012-09-25 Thread Martin Sebor
On 09/25/2012 06:08 PM, Wojciech Meyer wrote: Hi guys, I think the consensus about this bug is that everybody wants to fix it. Stefan has a patch but I got completely lost what is the exact reason of not applying it. It would be a shame to stop at this point. From my POV, there's no disagreeme

Re: svn commit: r1389337 - /stdcxx/branches/4.2.x/tests/support/atomic_xchg.cpp

2012-09-25 Thread Martin Sebor
On 09/24/2012 06:38 AM, lnico...@apache.org wrote: Author: lnicoara Date: Mon Sep 24 12:38:17 2012 New Revision: 1389337 URL: http://svn.apache.org/viewvc?rev=1389337&view=rev Log: 2012-09-24 Liviu Nicoara * tests/support/atomic_xchg.cpp: (run_test) moved counter volatile qualifi

Re: [jira] [Closed] (STDCXX-1056) std::moneypunct and std::numpunct implementations are not thread-safe

2012-09-25 Thread Stefan Teleman
On Tue, Sep 25, 2012 at 10:58 PM, Martin Sebor wrote: > As for Stefan's patches, the biggest problem I see there > (besides the above) is that they introduce changes that > appear to be unrelated to the problem without providing > a satisfactory rationale. The established stdcxx bug > fixing proc

Re: [jira] [Closed] (STDCXX-1066) SPARCV8 requires pthread_mutex_t and pthread_cond_t to be aligned on an 8-byte boundary

2012-09-25 Thread Travis Vitek
I asked around and we don't have one available at this time. Travis Liviu Nicoara wrote: On 9/25/12 7:56 PM, Stefan Teleman (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/STDCXX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] Anybody around here,