[
https://issues.apache.org/jira/browse/STORM-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272289#comment-14272289
]
ASF GitHub Bot commented on STORM-188:
--
Github user clockfly commented on the pull req
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/120#issuecomment-69435220
@revans,
Feel free to do what you want, change it, or replace it.:)
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/STORM-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272252#comment-14272252
]
ASF GitHub Bot commented on STORM-495:
--
Github user rick-kilgore commented on the pull
Github user rick-kilgore commented on the pull request:
https://github.com/apache/storm/pull/254#issuecomment-69433393
@revans2 I made changes to address both your comments. Please have a look.
That's a good catch about how I was using Comparable - thanks!
By the way,
[
https://issues.apache.org/jira/browse/STORM-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-578.
---
Resolution: Fixed
Fix Version/s: 0.10.0
[~mansheng] Thanks again for the fix I m
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/319
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/319#issuecomment-69402124
@lightyang I am really sorry this took me so long to get back and review
this again. It looks great +1, I'll merge this in.
---
If your project is set up for it, you ca
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/360#issuecomment-69399742
For the most part this looks good and I am +1 on merging this in. However,
I was wondering why we don't just replace the the backtype.storm.util
url-encode with the ring
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/312#issuecomment-69380814
@BuDongDong the changes you made look good to me. Would it be possible to
get you to file a JIRA for them? This is mostly for tracking to make it
simpler to see what has
[
https://issues.apache.org/jira/browse/STORM-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-552.
---
Resolution: Fixed
Fix Version/s: 0.10.0
Thanks [~caofangkun],
I merged this int
[
https://issues.apache.org/jira/browse/STORM-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271681#comment-14271681
]
ASF GitHub Bot commented on STORM-552:
--
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/311
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
[
https://issues.apache.org/jira/browse/STORM-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271677#comment-14271677
]
ASF GitHub Bot commented on STORM-552:
--
Github user revans2 commented on the pull requ
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/311#issuecomment-69378392
+1 the change looks good to me. I'll check it in to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
[
https://issues.apache.org/jira/browse/STORM-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271644#comment-14271644
]
ASF GitHub Bot commented on STORM-512:
--
Github user revans2 commented on the pull requ
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/275#issuecomment-69375242
The changes look find to me I am +1 for merging this in.
@nathanmarz I would like to get your opinion on this before merging it in,
because you had the original re
[
https://issues.apache.org/jira/browse/STORM-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271638#comment-14271638
]
ASF GitHub Bot commented on STORM-430:
--
Github user RaghavendraNandagopal commented on
Github user RaghavendraNandagopal commented on the pull request:
https://github.com/apache/storm/pull/250#issuecomment-69374819
Hi Bobby,
Sorry for getting it late. I will definitely complete it within 3-4
days from now. Hopefully by Tuesday I will send a new pull request.
[
https://issues.apache.org/jira/browse/STORM-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271562#comment-14271562
]
ASF GitHub Bot commented on STORM-430:
--
Github user revans2 commented on the pull requ
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/250#issuecomment-69367006
@RaghavendraNandagopal any update on this? Don't want to lose this great
work. If you are too busy I can try and upmerge it myself.
---
If your project is set up for it
[
https://issues.apache.org/jira/browse/STORM-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271558#comment-14271558
]
ASF GitHub Bot commented on STORM-188:
--
Github user revans2 commented on the pull requ
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/120#issuecomment-69366808
@clockfly any update on this? I just had the one minor comment, and I am
happy to do it myself in a follow up JIRA if you want. Just curious if this is
still on your rad
[
https://issues.apache.org/jira/browse/STORM-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271546#comment-14271546
]
ASF GitHub Bot commented on STORM-620:
--
Github user revans2 commented on the pull requ
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/377#issuecomment-69365186
@Lewuathe very sorry I missed where it is in two places in the reporting
section. You are 100% correct. +1 for mering this in.
---
If your project is set up for it, you
[
https://issues.apache.org/jira/browse/STORM-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271544#comment-14271544
]
ASF GitHub Bot commented on STORM-620:
--
Github user revans2 commented on the pull requ
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/377#issuecomment-69364868
The javadoc plugin you removed is in the reporting section of the pom.
That is used when running `mvn site` The other one is part of the dist
profile, The dist profile i
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271143#comment-14271143
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on a diff in the
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271151#comment-14271151
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on the pull requ
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/294#issuecomment-69348667
@caofangkun Overall it looks really good, thanks for doing this. I have a
few comments, mostly to clean things up a bit, or some follow up work.
---
If your project is s
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271145#comment-14271145
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on a diff in the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22721149
--- Diff: storm-dist/binary/src/main/assembly/binary.xml ---
@@ -131,13 +131,6 @@
-${project.basedir}/
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22721124
--- Diff: bin/storm ---
@@ -88,12 +88,12 @@ def get_config_opts():
global CONFIG_OPTS
return "-Dstorm.options=" + ','.join(map(quote_plus,CONF
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271142#comment-14271142
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on a diff in the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22720912
--- Diff: storm-core/pom.xml ---
@@ -464,6 +464,30 @@
+org.codehaus.mojo
--- E
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271139#comment-14271139
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on a diff in the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22720781
--- Diff: storm-core/src/saveVersion.sh ---
@@ -0,0 +1,42 @@
+#this file is used to generate the package-info.java class that
+# records the version, re
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271122#comment-14271122
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on a diff in the
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271108#comment-14271108
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on a diff in the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22720641
--- Diff: storm-core/src/saveVersion.sh ---
@@ -0,0 +1,42 @@
+#this file is used to generate the package-info.java class that
+# records the version, re
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271114#comment-14271114
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on a diff in the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22720543
--- Diff: storm-core/src/jvm/backtype/storm/utils/VersionInfo.java ---
@@ -0,0 +1,58 @@
+package backtype.storm.utils;
+
+public class VersionInfo {
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271112#comment-14271112
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on a diff in the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22720414
--- Diff: storm-core/src/jvm/backtype/storm/package-info.java ---
@@ -0,0 +1,7 @@
+/*
--- End diff --
This file is also a build artifact and sh
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22720173
--- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
@@ -510,7 +501,7 @@
(map #(.get_num_executors ^TopologySummary %))
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271100#comment-14271100
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on a diff in the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22720049
--- Diff: storm-core/dependency-reduced-pom.xml ---
@@ -0,0 +1,743 @@
+
--- End diff --
This file is a build byproduct and should not be checke
GitHub user Lewuathe opened a pull request:
https://github.com/apache/storm/pull/377
[STORM-620] Duplicate maven plugin declaration
Fix duplicate maven-javadoc-plugin declaration in pom.xml reporting section
You can merge this pull request into a Git repository by running:
$ gi
[
https://issues.apache.org/jira/browse/STORM-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271005#comment-14271005
]
ASF GitHub Bot commented on STORM-620:
--
GitHub user Lewuathe opened a pull request:
Kai Sasaki created STORM-620:
Summary: Duplicate maven plugin declaration
Key: STORM-620
URL: https://issues.apache.org/jira/browse/STORM-620
Project: Apache Storm
Issue Type: Bug
Affects Ver
[
https://issues.apache.org/jira/browse/STORM-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270923#comment-14270923
]
Danijel Schiavuzzi commented on STORM-616:
--
I had a quick glance at the README, lo
50 matches
Mail list logo
