[jira] [Commented] (STORM-329) Add Option to Config Message handling strategy when connection timeout

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313678#comment-14313678 ] ASF GitHub Bot commented on STORM-329: -- Github user clockfly commented on the pull req

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2015-02-09 Thread clockfly
Github user clockfly commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-73651894 +1 on the update, the patch is well written. I made a few comments under reivew panel of https://github.com/miguno/storm/commit/8ebaaf8dbc63df3c2691e0cc3ac5

[jira] [Commented] (STORM-668) Generate storm-ui war using maven and deployed on TomCat

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313555#comment-14313555 ] ASF GitHub Bot commented on STORM-668: -- GitHub user caofangkun opened a pull request:

[GitHub] storm pull request: STORM-668:Generate storm-ui.war and could be d...

2015-02-09 Thread caofangkun
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/423 STORM-668:Generate storm-ui.war and could be deployed on TomCat ``` ➜ storm-core git:(storm-668) mvn clean && mvn install -Dmaven.test.skip=true -Dwar ➜ storm-core git:(storm-668) c

Re: [DISCUSS] Logging framework logback -> log4j 2.x

2015-02-09 Thread Jeff Ramsdale
On Mon, Feb 9, 2015 at 10:25 AM, Bobby Evans wrote: > Yes we would get rid of the log4j-over-slf4j, which is not that commonly > used in libraries anyways, and replace it with the log4j-1.2-api jar. That > prevents slf4j from seeing a logging feedback loop. - Bobby > If you mean that log4j-over

[jira] [Created] (STORM-668) Generate storm-ui war using maven and deployed on TomCat

2015-02-09 Thread caofangkun (JIRA)
caofangkun created STORM-668: Summary: Generate storm-ui war using maven and deployed on TomCat Key: STORM-668 URL: https://issues.apache.org/jira/browse/STORM-668 Project: Apache Storm Issue Ty

[jira] [Commented] (STORM-495) Add delayed retries to KafkaSpout

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313348#comment-14313348 ] ASF GitHub Bot commented on STORM-495: -- Github user kenshih commented on a diff in the

[GitHub] storm pull request: STORM-495: KafkaSpout retries with exponential...

2015-02-09 Thread kenshih
Github user kenshih commented on a diff in the pull request: https://github.com/apache/storm/pull/254#discussion_r24383036 --- Diff: external/storm-kafka/src/jvm/storm/kafka/ExponentialBackoffMsgRetryManager.java --- @@ -0,0 +1,167 @@ +/** + * Licensed to the Apache Softwa

Re: [DISCUSS] Logging framework logback -> log4j 2.x

2015-02-09 Thread P. Taylor Goetz
I'm okay with switching logging frameworks (I hate most of them equally ;) ), but I would like to stick with slf4j as the logging api so changes like this are easy. However, we may want to at least consider polling users@, and make sure the change is well documented. The impact to devs is small

[GitHub] storm pull request: STORM-541:Clean duplicate dependences in poms

2015-02-09 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/422#issuecomment-73626073 @revans2 Could you please have a review on this PR? Thanks a lot . --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Updated] (STORM-657) make the shutdown-worker sleep time before kill -9 configurable

2015-02-09 Thread caofangkun (JIRA)
[ https://issues.apache.org/jira/browse/STORM-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun updated STORM-657: - Fix Version/s: (was: 0.9.2-incubating) > make the shutdown-worker sleep time before kill -9 configurabl

[jira] [Updated] (STORM-657) make the shutdown-worker sleep time before kill -9 configurable

2015-02-09 Thread caofangkun (JIRA)
[ https://issues.apache.org/jira/browse/STORM-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun updated STORM-657: - Affects Version/s: 0.10.0 > make the shutdown-worker sleep time before kill -9 configurable > -

[jira] [Commented] (STORM-541) Build produces maven warnings

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313315#comment-14313315 ] ASF GitHub Bot commented on STORM-541: -- Github user caofangkun commented on the pull r

[jira] [Reopened] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-09 Thread caofangkun (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun reopened STORM-534: -- > Store Nimbus Server Information in zookeeper path > {storm.zookeeper.root}/nimbus > --

[GitHub] storm commit comment: fd066985a74c3140f61a465cfc49c83a6ddfa713

2015-02-09 Thread kenshih
Github user kenshih commented on commit fd066985a74c3140f61a465cfc49c83a6ddfa713: https://github.com/apache/storm/commit/fd066985a74c3140f61a465cfc49c83a6ddfa713#commitcomment-9666318 In external/storm-kafka/src/jvm/storm/kafka/ExponentialBackoffMsgRetryManager.java: In external

[jira] [Assigned] (STORM-663) Create javadocs for BoltDeclarer

2015-02-09 Thread Kai Sasaki (JIRA)
[ https://issues.apache.org/jira/browse/STORM-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kai Sasaki reassigned STORM-663: Assignee: Kai Sasaki > Create javadocs for BoltDeclarer > > >

[jira] [Commented] (STORM-400) Thrift upgrade to 0.9.1

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312988#comment-14312988 ] ASF GitHub Bot commented on STORM-400: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: [STORM-400] Thrift upgrade to thrift-0.9.2

2015-02-09 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/410#issuecomment-73601819 the workaround from @knusbaum didn't work for me, but I also hit the same issue without this patch in, so I think it is a race condition that was not modified by this patc

[GitHub] storm pull request: Storm-166: Nimbus HA design doc and implementa...

2015-02-09 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/354#issuecomment-73581369 @harshach My original intention was to have a single replication count for a cluster but after your comments I realized the users may want to change this setting

[jira] [Commented] (STORM-162) Load Balancing Shuffle Grouping

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312763#comment-14312763 ] ASF GitHub Bot commented on STORM-162: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: STORM-162: Load Balancing Shuffle Grouping

2015-02-09 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/402#discussion_r24359884 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -199,6 +199,12 @@ public static final Object TOPOLOGY_TUPLE_SERIALIZER_SCHEMA = String.

[jira] [Commented] (STORM-162) Load Balancing Shuffle Grouping

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312752#comment-14312752 ] ASF GitHub Bot commented on STORM-162: -- Github user d2r commented on a diff in the pul

[GitHub] storm pull request: STORM-162: Load Balancing Shuffle Grouping

2015-02-09 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/402#discussion_r24359616 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -199,6 +199,12 @@ public static final Object TOPOLOGY_TUPLE_SERIALIZER_SCHEMA = String.clas

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312727#comment-14312727 ] ASF GitHub Bot commented on STORM-634: -- Github user knusbaum commented on a diff in th

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-02-09 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/414#discussion_r24358543 --- Diff: storm-core/src/clj/backtype/storm/converter.clj --- @@ -0,0 +1,200 @@ +(ns backtype.storm.converter --- End diff -- > Each function

[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...

2015-02-09 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/318#issuecomment-73568595 Yes, I think its ok to close the jira. @NareshKosgi can you test and comment. The changes are merged into master so should be easy to test. --- If your project i

[jira] [Resolved] (STORM-637) Integrate PartialKeyGrouping into storm API

2015-02-09 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-637. --- Resolution: Fixed Fix Version/s: 0.10.0 Assignee: Robert Joseph Evans >

[jira] [Commented] (STORM-637) Integrate PartialKeyGrouping into storm API

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312586#comment-14312586 ] ASF GitHub Bot commented on STORM-637: -- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-637: Integrate PartialKeyGrouping into s...

2015-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312582#comment-14312582 ] ASF GitHub Bot commented on STORM-634: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-02-09 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/414#discussion_r24351821 --- Diff: storm-core/src/clj/backtype/storm/converter.clj --- @@ -0,0 +1,200 @@ +(ns backtype.storm.converter --- End diff -- That seems fine t

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-02-09 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/414#discussion_r24351697 --- Diff: storm-core/src/jvm/backtype/storm/serialization/ThriftSerializationDelegate.java --- @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Softwa

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312577#comment-14312577 ] ASF GitHub Bot commented on STORM-634: -- Github user revans2 commented on a diff in the

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312570#comment-14312570 ] ASF GitHub Bot commented on STORM-634: -- Github user Parth-Brahmbhatt commented on a di

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-02-09 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/414#discussion_r24351380 --- Diff: storm-core/src/clj/backtype/storm/converter.clj --- @@ -0,0 +1,200 @@ +(ns backtype.storm.converter --- End diff -- I actual

Re: [DISCUSS] Logging framework logback -> log4j 2.x

2015-02-09 Thread Bobby Evans
Yes we would get rid of the log4j-over-slf4j, which is not that commonly used in libraries anyways, and replace it with the log4j-1.2-api jar.  That prevents slf4j from seeing a logging feedback loop. - Bobby On Monday, February 9, 2015 12:18 PM, Michael Rose wrote: In cases when

Re: [DISCUSS] Logging framework logback -> log4j 2.x

2015-02-09 Thread Michael Rose
In cases when you have two SLF4J bindings on the classpath, it essentially chooses the first to show up on the classpath. That'll usually be the case given the Storm libdir is read first. "With our current setup if someone doesn't exclude things properly it crashes." How so? Because of slf4j-log4

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312557#comment-14312557 ] ASF GitHub Bot commented on STORM-634: -- Github user Parth-Brahmbhatt commented on a di

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-02-09 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/414#discussion_r24350530 --- Diff: storm-core/src/jvm/backtype/storm/serialization/ThriftSerializationDelegate.java --- @@ -0,0 +1,52 @@ +/** + * Licensed to the Apac

Re: [DISCUSS] Logging framework logback -> log4j 2.x

2015-02-09 Thread Nathan Marz
The critical feature is putting a cap on the total size of log files kept for a worker. As long as log4j2 allows you to put a hard limit (e.g. 1GB total across all log files for a worker, with older files being deleted as limit is exceeded), then I don't mind switching. On Mon, Feb 9, 2015 at 9:43

[GitHub] storm pull request: [STORM-659] return grep matches each on its ow...

2015-02-09 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/420#issuecomment-73553271 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: [DISCUSS] Logging framework logback -> log4j 2.x

2015-02-09 Thread Bobby Evans
I'm not totally positive on this, but the little test I ran did not cause any serious issues.  I created a small project that just logs using slf4j and log4j 1.2 API with the slf4j log4j2 bridge and the log4j1.2 compatibility bridge on the classpath. ```package test; import org.slf4j.Logger; i

[jira] [Commented] (STORM-659) Logviewer used with grep param returns all matches on one line

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312520#comment-14312520 ] ASF GitHub Bot commented on STORM-659: -- Github user knusbaum commented on the pull req

[jira] [Commented] (STORM-400) Thrift upgrade to 0.9.1

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312516#comment-14312516 ] ASF GitHub Bot commented on STORM-400: -- Github user knusbaum commented on the pull req

[GitHub] storm pull request: [STORM-400] Thrift upgrade to thrift-0.9.2

2015-02-09 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/410#issuecomment-73552653 +1 I was having the same issues as @revans2 until I ran `mvn install -DskipTests` After that, `mvn test` has succeeded consistently. --- If your project is set

[GitHub] storm pull request: Correct capitalization typo

2015-02-09 Thread pdelre
Github user pdelre commented on the pull request: https://github.com/apache/storm/pull/383#issuecomment-73546557 Thank you @d2r. I don't have an ID, so no worries there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request: fix storm-hbase pom parent version

2015-02-09 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/287#issuecomment-73546260 This pull request was closed because it looked abandoned. Please re-open if is not. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] storm pull request: fix storm-hbase pom parent version

2015-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-456) Storm UI: cannot navigate to topology page when name contains spaces

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312464#comment-14312464 ] ASF GitHub Bot commented on STORM-456: -- Github user d2r commented on the pull request:

[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...

2015-02-09 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/318#issuecomment-73545196 @Parth-Brahmbhatt, @NareshKosgi , Does #360 sufficiently resolve STORM-456? If so, we should close this pull request and resolve STORM-456. --- If your project is set up for

Re: [DISCUSS] Logging framework logback -> log4j 2.x

2015-02-09 Thread Michael Rose
slf4j-log4j12 would still need to be excluded with log4j2, as you must use slf4j-log4j2. log4j2 its self has a package and coordinate change, so now people would be excluding sfl4j-log4j12, log4j 1.2 and logback. Switching to log4j2 does not solve that particular issue and perhaps slightly exacerba

[jira] [Commented] (STORM-653) missing DRPC HTTP port in SECURITY.md

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312462#comment-14312462 ] ASF GitHub Bot commented on STORM-653: -- Github user kishorvpatil commented on the pull

[GitHub] storm pull request: [STORM-653] missing DRPC HTTP port in SECURITY...

2015-02-09 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/413#issuecomment-73544830 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312455#comment-14312455 ] ASF GitHub Bot commented on STORM-634: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-02-09 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/414#issuecomment-73544378 The code also needs an upmerge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[jira] [Commented] (STORM-253) Allow worker to choose available port instead of pre-configed

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312452#comment-14312452 ] ASF GitHub Bot commented on STORM-253: -- Github user d2r commented on the pull request:

[GitHub] storm pull request: STORM-253: Allow storm worker to use dynamic p...

2015-02-09 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/45#issuecomment-73544085 @clockfly, Is this pull request still valid? If so, it seems we need an up-merge. If not, can we close it? --- If your project is set up for it, you can reply to this email

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312450#comment-14312450 ] ASF GitHub Bot commented on STORM-634: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-02-09 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/414#issuecomment-73543546 I have two big questions/issues with the current patch. I think it is a step in the right direction. --- If your project is set up for it, you can reply to this email an

[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-09 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312448#comment-14312448 ] Derek Dagit commented on STORM-534: --- I noticed this issue has been resolved as a duplicat

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312444#comment-14312444 ] ASF GitHub Bot commented on STORM-634: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-02-09 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/414#discussion_r24342731 --- Diff: storm-core/src/clj/backtype/storm/converter.clj --- @@ -0,0 +1,200 @@ +(ns backtype.storm.converter --- End diff -- I personally woul

[GitHub] storm pull request: Correct capitalization typo

2015-02-09 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/383#issuecomment-73542370 @pdelre, I resolved the JIRA created for this pull request. If you would like proper attribution in Apache JIRA, then let us know what your Apache JIRA ID is. --- If your p

[GitHub] storm pull request: Correct capitalization typo

2015-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Resolved] (STORM-667) Incorrect capitalization "SHell" in Multilang-protocol.md

2015-02-09 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Derek Dagit resolved STORM-667. --- Resolution: Fixed Fix Version/s: 0.10.0 Thanks, Paul. I merged this to master. > Incorrect cap

[jira] [Commented] (STORM-667) Incorrect capitalization "SHell" in Multilang-protocol.md

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312437#comment-14312437 ] ASF GitHub Bot commented on STORM-667: -- Github user d2r commented on the pull request:

[GitHub] storm pull request: Correct capitalization typo

2015-02-09 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/383#issuecomment-73541891 +1 Created [STORM-667](https://issues.apache.org/jira/browse/STORM-667) for this pull request. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-02-09 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/414#discussion_r24342289 --- Diff: storm-core/src/jvm/backtype/storm/serialization/ThriftSerializationDelegate.java --- @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Softwa

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312436#comment-14312436 ] ASF GitHub Bot commented on STORM-634: -- Github user revans2 commented on a diff in the

[jira] [Created] (STORM-667) Incorrect capitalization "SHell" in Multilang-protocol.md

2015-02-09 Thread Derek Dagit (JIRA)
Derek Dagit created STORM-667: - Summary: Incorrect capitalization "SHell" in Multilang-protocol.md Key: STORM-667 URL: https://issues.apache.org/jira/browse/STORM-667 Project: Apache Storm Issue

Re: [DISCUSS] Logging framework logback -> log4j 2.x

2015-02-09 Thread Harsha
I am +1 on switching to log4j. I second Bobby on excluding log4j and new users/devs run into this issue quite often. Thanks, Harsha On Mon, Feb 9, 2015, at 08:28 AM, Bobby Evans wrote: > I haven't seen any reply to this yet. It is a real pain to repeatedly > tell our downstream users to run mvn de

Re: [DISCUSS] Logging framework logback -> log4j 2.x

2015-02-09 Thread Bobby Evans
I haven't seen any reply to this yet. It is a real pain to repeatedly tell our downstream users to run mvn dependecy:tree look for slf4j log4j bindings and exclude them.  That alone is enough for me to say lets switch.  - Bobby On Monday, February 2, 2015 3:07 PM, Derek Dagit wrote:

[GitHub] storm pull request: Update "get-task-object" function, change the ...

2015-02-09 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/312#issuecomment-73540020 @BuDongDong any update? Should we get a new pull request for this, or can we fix the Unknown Repository Problem another way? --- If your project is set up for it, you can re

[GitHub] storm pull request: 0.8.3

2015-02-09 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/300#issuecomment-73538930 This pull request has not been acted on in over 100 days, and I am not sure what its purpose is. @kksri19, is this still needed, or can you close this request? --- If you

[GitHub] storm pull request: Windows fork option

2015-02-09 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/335#issuecomment-73539489 Hi @JamisonWhite, it looks like this needs an up-merge. Would you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear o

[jira] [Commented] (STORM-162) Load Balancing Shuffle Grouping

2015-02-09 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312399#comment-14312399 ] Robert Joseph Evans commented on STORM-162: --- [~azaroth] There are a number of pla

[jira] [Resolved] (STORM-601) Have jira-github-join ignore case in matting JIRA number

2015-02-09 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Derek Dagit resolved STORM-601. --- Resolution: Fixed Fix Version/s: 0.10.0 Thanks, [~revans2]. I merged this to master. > Have jir

[GitHub] storm pull request: STORM-601: Make jira-github-join ignore case.

2015-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-601) Have jira-github-join ignore case in matting JIRA number

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312396#comment-14312396 ] ASF GitHub Bot commented on STORM-601: -- Github user asfgit closed the pull request at:

[jira] [Resolved] (STORM-626) merging a pull request can be a pain

2015-02-09 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Derek Dagit resolved STORM-626. --- Resolution: Fixed Fix Version/s: 0.10.0 Thanks [~revans2], I merged this to master. > merging a

[jira] [Commented] (STORM-626) merging a pull request can be a pain

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312387#comment-14312387 ] ASF GitHub Bot commented on STORM-626: -- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-626: Add script to print out the merge c...

2015-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/380 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-626) merging a pull request can be a pain

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312381#comment-14312381 ] ASF GitHub Bot commented on STORM-626: -- Github user d2r commented on the pull request:

[GitHub] storm pull request: STORM-626: Add script to print out the merge c...

2015-02-09 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/380#issuecomment-73535010 Looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-601) Have jira-github-join ignore case in matting JIRA number

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312380#comment-14312380 ] ASF GitHub Bot commented on STORM-601: -- Github user d2r commented on the pull request:

[GitHub] storm pull request: STORM-601: Make jira-github-join ignore case.

2015-02-09 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/358#issuecomment-73534819 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[jira] [Commented] (STORM-660) IndexOutOfBoundsException with shuffle grouping and a large number of paralleliziation hint

2015-02-09 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312375#comment-14312375 ] Robert Joseph Evans commented on STORM-660: --- The question is should we make the O

Re: [jira] [Commented] (STORM-660) IndexOutOfBoundsException with shuffle grouping and a large number of paralleliziation hint

2015-02-09 Thread clay teahouse
Then I suppose we need to put the emits in a synchronized block. On Sun, Feb 8, 2015 at 6:52 PM, P. Taylor Goetz (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/STORM-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311676#comment-14311

[jira] [Commented] (STORM-329) Add Option to Config Message handling strategy when connection timeout

2015-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312356#comment-14312356 ] ASF GitHub Bot commented on STORM-329: -- Github user miguno commented on the pull reque

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2015-02-09 Thread miguno
Github user miguno commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-73527901 I have improved the patch in this pull request, which particularly meant modifications to The updated patch is availabe at: * https://github.com/miguno/storm/c

Re: Do I need to synchronize emits?

2015-02-09 Thread Bobby Evans
If you are emitting from multiple threads then, yes you need to synchronize around the emit call.  This is not a typical use case so we do not synchronize by default. - Bobby On Sunday, February 8, 2015 4:01 AM, clay teahouse wrote: Hi All, I emit my tuples in batches. Do I need

Re: A question on CLASSPATH when submitting a topology

2015-02-09 Thread Bobby Evans
All of them have been moved out already.  They were moved out when we went to the maven assembly plugin for packaging.  Including STORM_HOME in the classpath is for legacy purposes, meaning we missed changing it when we made the update.   If you want to file a JIRA and put up a pull request I wou

Storm Cluster on EC2 With Vagrant Provider

2015-02-09 Thread Sasaki Kai
Hi all The other day, I developed storm-devenv for developing storm itself. And I applied it on AWS EC2. You can construct storm cluster with same interface to VirtualBox and EC2. http://www.lewuathe.com/blog/2015/02/05/storm-cluster-on-ec2-with-vagrant-provider/

A question on CLASSPATH when submitting a topology

2015-02-09 Thread 田杰
Suppose my Storm exists in /home/storm/storm-0.9.0.1: By checking the script "bin/storm", I find it collects all jars in "/home/storm/storm-0.9.0.1"(HOME_DIR) and "storm-0.9.0.1/lib/" into CLASSPATH ( ... -cp ...). I just think it is a little tricky here to collect all jars under storm-0.9.0.

[jira] [Comment Edited] (STORM-605) Attempting to call unbound fn during bolt prepare

2015-02-09 Thread Li Chaomo (JIRA)
[ https://issues.apache.org/jira/browse/STORM-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311925#comment-14311925 ] Li Chaomo edited comment on STORM-605 at 2/9/15 8:38 AM: - [~srihars

[jira] [Comment Edited] (STORM-605) Attempting to call unbound fn during bolt prepare

2015-02-09 Thread Li Chaomo (JIRA)
[ https://issues.apache.org/jira/browse/STORM-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311925#comment-14311925 ] Li Chaomo edited comment on STORM-605 at 2/9/15 8:36 AM: - [~srihars

[jira] [Commented] (STORM-605) Attempting to call unbound fn during bolt prepare

2015-02-09 Thread Li Chaomo (JIRA)
[ https://issues.apache.org/jira/browse/STORM-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311925#comment-14311925 ] Li Chaomo commented on STORM-605: - [~sriharsha] hello, i found something today though i don

[jira] [Comment Edited] (STORM-605) Attempting to call unbound fn during bolt prepare

2015-02-09 Thread Li Chaomo (JIRA)
[ https://issues.apache.org/jira/browse/STORM-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311925#comment-14311925 ] Li Chaomo edited comment on STORM-605 at 2/9/15 8:35 AM: - [~srihars