[GitHub] storm pull request: [STORM-712] Storm daemons shutdown if OutOfMem...

2015-03-26 Thread longdafeng
Github user longdafeng commented on a diff in the pull request: https://github.com/apache/storm/pull/468#discussion_r27273285 --- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java --- @@ -533,4 +533,16 @@ private static SerializationDelegate getSerializationDelegate(Map stor

[jira] [Commented] (STORM-712) Storm daemons must shutdown JVM in case of OOM in any thread

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383262#comment-14383262 ] ASF GitHub Bot commented on STORM-712: -- Github user longdafeng commented on a diff in

[GitHub] storm pull request: [storm-redis] Clarify Redis*StateUpdater's exp...

2015-03-26 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/488#issuecomment-86784079 nice, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] storm pull request: [storm-redis] Clarify Redis*StateUpdater's exp...

2015-03-26 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/488#issuecomment-86746560 @dashengju @revans2 Please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request: [storm-redis] Clarify Redis*StateUpdater's exp...

2015-03-26 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/488 [storm-redis] Clarify Redis*StateUpdater's expire is optional It's not released to official, and I've just changed constructor signature so I'm not sure it can be treated to small patch.

[jira] [Commented] (STORM-704) Apply Travis CI

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382830#comment-14382830 ] ASF GitHub Bot commented on STORM-704: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: STORM-704 Apply Travis CI to Apache Storm Proj...

2015-03-26 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/486#issuecomment-86740796 Failing build (from storm-core) output for example : https://s3.amazonaws.com/archive.travis-ci.org/jobs/56016756/log.txt --- If your project is set up for it, you ca

[jira] [Commented] (STORM-704) Apply Travis CI

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382825#comment-14382825 ] ASF GitHub Bot commented on STORM-704: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: STORM-704 Apply Travis CI to Apache Storm Proj...

2015-03-26 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/486#issuecomment-86739674 Applied first on my forked repo: https://travis-ci.org/HeartSaVioR/storm/jobs/56021892 Could any committers help requesting set up Travis CI to Apache Infra?

Re: Wish to hear your opinion on adopting public CI

2015-03-26 Thread 임정택
Yes, we should ask Apache Infra to set up Travis CI (with asfgit account), which is not an issue cause many projects on Apache already uses Travis CI. ex. https://issues.apache.org/jira/browse/INFRA-6161 I've just finished work about adopting Travis CI (with my fork), so we're ready! https://travi

[jira] [Commented] (STORM-730) UI: Component Page has extra } for executor ids of Bolts

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382797#comment-14382797 ] ASF GitHub Bot commented on STORM-730: -- GitHub user d2r opened a pull request: ht

[GitHub] storm pull request: [STORM-730] remove extra curly brace

2015-03-26 Thread d2r
GitHub user d2r opened a pull request: https://github.com/apache/storm/pull/487 [STORM-730] remove extra curly brace You can merge this pull request into a Git repository by running: $ git pull https://github.com/d2r/storm storm-730-extra-brace Alternatively you can review an

[jira] [Created] (STORM-730) UI: Component Page has extra } for executor ids of Bolts

2015-03-26 Thread Derek Dagit (JIRA)
Derek Dagit created STORM-730: - Summary: UI: Component Page has extra } for executor ids of Bolts Key: STORM-730 URL: https://issues.apache.org/jira/browse/STORM-730 Project: Apache Storm Issue T

[jira] [Commented] (STORM-704) Apply Travis CI

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382790#comment-14382790 ] ASF GitHub Bot commented on STORM-704: -- GitHub user HeartSaVioR opened a pull request:

[GitHub] storm pull request: STORM-704 Apply Travis CI to Apache Storm Proj...

2015-03-26 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/486 STORM-704 Apply Travis CI to Apache Storm Project * support build matrix (openjdk6, openjdk7, oraclejdk7, oraclejdk8) * change log level to WARN while running unit tests * print out clojur

[jira] [Commented] (STORM-729) UI: Component Page Executors header is missing the selected window

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382785#comment-14382785 ] ASF GitHub Bot commented on STORM-729: -- GitHub user d2r opened a pull request: ht

[GitHub] storm pull request: [STORM-729] Include Executors (Window Hint) if...

2015-03-26 Thread d2r
GitHub user d2r opened a pull request: https://github.com/apache/storm/pull/485 [STORM-729] Include Executors (Window Hint) if the component is of Bolt type This was missing only from the Bolt case. You can merge this pull request into a Git repository by running: $ git pull ht

[jira] [Created] (STORM-729) UI: Component Page Executors header is missing the selected window

2015-03-26 Thread Derek Dagit (JIRA)
Derek Dagit created STORM-729: - Summary: UI: Component Page Executors header is missing the selected window Key: STORM-729 URL: https://issues.apache.org/jira/browse/STORM-729 Project: Apache Storm

[jira] [Commented] (STORM-727) Storm tests should succeed even if a storm process is running locally.

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382745#comment-14382745 ] ASF GitHub Bot commented on STORM-727: -- Github user d2r commented on the pull request:

[jira] [Commented] (STORM-714) Polish the new CSS Styles brought in with dataTables

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382740#comment-14382740 ] ASF GitHub Bot commented on STORM-714: -- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-727: nimbus_auth_test should not use def...

2015-03-26 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/483#issuecomment-86729962 It would be even better to use an ephemeral port, as with util/available-port. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: [STORM-714] Make CSS more consistent with self...

2015-03-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-728) UI: Component Page "Spout stats" table has Emitted and Transferred in each other's column

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382738#comment-14382738 ] ASF GitHub Bot commented on STORM-728: -- GitHub user d2r opened a pull request: ht

[GitHub] storm pull request: [STORM-728] Put emitted and transferred stats ...

2015-03-26 Thread d2r
GitHub user d2r opened a pull request: https://github.com/apache/storm/pull/484 [STORM-728] Put emitted and transferred stats under correct columns The column headers were consistent with other UI tables, so I swapped the data. You can merge this pull request into a Git repository

[jira] [Commented] (STORM-728) UI: Component Page "Spout stats" table has Emitted and Transferred in each other's column

2015-03-26 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382704#comment-14382704 ] Derek Dagit commented on STORM-728: --- Pull request coming after some quick testing. > UI:

[jira] [Created] (STORM-728) UI: Component Page "Spout stats" table has Emitted and Transferred in each other's column

2015-03-26 Thread Derek Dagit (JIRA)
Derek Dagit created STORM-728: - Summary: UI: Component Page "Spout stats" table has Emitted and Transferred in each other's column Key: STORM-728 URL: https://issues.apache.org/jira/browse/STORM-728 Proje

[jira] [Commented] (STORM-727) Storm tests should succeed even if a storm process is running locally.

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382689#comment-14382689 ] ASF GitHub Bot commented on STORM-727: -- GitHub user Parth-Brahmbhatt opened a pull req

[GitHub] storm pull request: STORM-727: nimbus_auth_test should not use def...

2015-03-26 Thread Parth-Brahmbhatt
GitHub user Parth-Brahmbhatt opened a pull request: https://github.com/apache/storm/pull/483 STORM-727: nimbus_auth_test should not use default nimbus port. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Parth-Brahmbhatt/incubat

[jira] [Created] (STORM-727) Storm tests should succeed even if a storm process is running locally.

2015-03-26 Thread Parth Brahmbhatt (JIRA)
Parth Brahmbhatt created STORM-727: -- Summary: Storm tests should succeed even if a storm process is running locally. Key: STORM-727 URL: https://issues.apache.org/jira/browse/STORM-727 Project: Apach

[ANNOUNCE] Apache Storm 0.9.4 Released

2015-03-26 Thread P. Taylor Goetz
The Apache Storm community is pleased to announce the release of Apache Storm version 0.9.4. Storm is a distributed, fault-tolerant, and high-performance realtime computation system that provides strong guarantees on the processing of data. You can read more about Storm on the project website:

[jira] [Commented] (STORM-726) Adding nimbus.host config for backward compatibility of client config

2015-03-26 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/STORM-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382398#comment-14382398 ] Parth Brahmbhatt commented on STORM-726: Cant really post PR against nimbus-ha bran

[jira] [Created] (STORM-726) Adding nimbus.host config for backward compatibility of client config

2015-03-26 Thread Parth Brahmbhatt (JIRA)
Parth Brahmbhatt created STORM-726: -- Summary: Adding nimbus.host config for backward compatibility of client config Key: STORM-726 URL: https://issues.apache.org/jira/browse/STORM-726 Project: Apache

[jira] [Commented] (STORM-712) Storm daemons must shutdown JVM in case of OOM in any thread

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382189#comment-14382189 ] ASF GitHub Bot commented on STORM-712: -- Github user lazyval commented on a diff in the

[jira] [Commented] (STORM-712) Storm daemons must shutdown JVM in case of OOM in any thread

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382183#comment-14382183 ] ASF GitHub Bot commented on STORM-712: -- Github user lazyval commented on a diff in the

[GitHub] storm pull request: [STORM-712] Storm daemons shutdown if OutOfMem...

2015-03-26 Thread lazyval
Github user lazyval commented on a diff in the pull request: https://github.com/apache/storm/pull/468#discussion_r27231134 --- Diff: storm-core/src/jvm/backtype/storm/drpc/DRPCSpout.java --- @@ -129,7 +133,9 @@ private void checkFutures() { public void open(Map conf, Topolo

[GitHub] storm pull request: [STORM-712] Storm daemons shutdown if OutOfMem...

2015-03-26 Thread lazyval
Github user lazyval commented on a diff in the pull request: https://github.com/apache/storm/pull/468#discussion_r27230992 --- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java --- @@ -533,4 +533,16 @@ private static SerializationDelegate getSerializationDelegate(Map stormCo

[jira] [Commented] (STORM-712) Storm daemons must shutdown JVM in case of OOM in any thread

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382140#comment-14382140 ] ASF GitHub Bot commented on STORM-712: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: [STORM-712] Storm daemons shutdown if OutOfMem...

2015-03-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/468#issuecomment-86600804 +1 the code looks good to me. I had to do something similar for hadoop. @lazyval do you have any more questions or concerns about this? --- If your project is s

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382037#comment-14382037 ] DashengJu commented on STORM-723: - [~kabhwan] we should change the Updater/Querier interfa

Re: Wish to hear your opinion on adopting public CI

2015-03-26 Thread Bobby Evans
I would love to see CI setup.  I don't know how Apache feels about travis-ci, we mostly ran into issues with setting up ruby on the jenkins nodes.  Now I am sure there will be issues with nodejs.  If travis-ci makes this simpler I would be all for using it.  But because it requires some github h

Re: DISCUSS: Apache Storm possibly combining with JStorm

2015-03-26 Thread Bobby Evans
In all likelihood both code bases would coexist for a while until the features added to Storm can be ported over to JStorm, and any discrepancies between the two can be worked out.  - Bobby On Thursday, March 26, 2015 9:27 AM, Supun Kamburugamuva wrote: Having a Java code base w

[jira] [Resolved] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-723. --- Resolution: Fixed Fix Version/s: 0.11.0 0.10.0 [~kabhwan], I

[jira] [Commented] (STORM-724) [storm-redis] Document RedisStoreBolt and RedisLookupBolt which is missed

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381972#comment-14381972 ] ASF GitHub Bot commented on STORM-724: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...

2015-03-26 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/481#issuecomment-86543353 @dashengju Basic Bolts are planned to release 0.11.0. You can find it from CHANGES.md. But we can also discuss it to include Basic Bolts to 0.10.0, and actually I'

[jira] [Commented] (STORM-724) [storm-redis] Document RedisStoreBolt and RedisLookupBolt which is missed

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381969#comment-14381969 ] ASF GitHub Bot commented on STORM-724: -- Github user dashengju commented on the pull re

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381968#comment-14381968 ] ASF GitHub Bot commented on STORM-723: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...

2015-03-26 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/481#issuecomment-86542208 @revans2 I think we should merge this PR to all branches. please help to review. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86542171 @HeartSaVioR yes, but this is a very easy cherry-pick, when we are depleting code. I am running the tests on 0.10.x-branch now to be sure everything looks good, and then I

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381957#comment-14381957 ] ASF GitHub Bot commented on STORM-723: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86541464 @revans2 Thanks for merging! Especially I know that cherry-picking commits is not a easy way to do. ;) --- If your project is set up for it, you can reply to this ema

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381948#comment-14381948 ] ASF GitHub Bot commented on STORM-723: -- Github user asfgit closed the pull request at:

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381947#comment-14381947 ] Jungtaek Lim commented on STORM-723: Thanks! I'll give it a try. > [storm-redis] Redis

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381928#comment-14381928 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. > [storm-redis] RedisS

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381941#comment-14381941 ] DashengJu commented on STORM-723: - good idea > [storm-redis] RedisStateSetUpdater writes s

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381942#comment-14381942 ] ASF GitHub Bot commented on STORM-723: -- Github user revans2 commented on the pull requ

[jira] [Commented] (STORM-587) trident transactional state in zk should be namespaced with topology id

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381940#comment-14381940 ] ASF GitHub Bot commented on STORM-587: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86539867 OK, I'll merge this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: DISCUSS: Apache Storm possibly combining with JStorm

2015-03-26 Thread Supun Kamburugamuva
Having a Java code base would hugely decrease the barrier for programmers like myself who are willing to contribute, but are not familiar with Clojure. How is this merge going to happen if it at all happens.. Both code bases co-exists? Thanks, Supun.. On Tue, Mar 24, 2015 at 7:31 PM, Brian O'Nei

[GitHub] storm pull request: STORM-587. trident transactional state in zk s...

2015-03-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/475#issuecomment-86539624 This is the path I saw through the code. Please let me know if I missed anything. https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/topolog

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) > [storm-redis] RedisStateSetUpdater writes sta

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) > [storm-redis] RedisStateSetUpdater writes sta

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) > [storm-redis] RedisStateSetUpdater writes sta

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) > [storm-redis] RedisStateSetUpdater writes sta

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) > [storm-redis] RedisStateSetUpdater writes sta

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) > [storm-redis] RedisStateSetUpdater writes sta

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381929#comment-14381929 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. > [storm-redis] RedisS

[jira] [Commented] (STORM-587) trident transactional state in zk should be namespaced with topology id

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381927#comment-14381927 ] ASF GitHub Bot commented on STORM-587: -- Github user revans2 commented on the pull requ

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381933#comment-14381933 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. > [storm-redis] RedisS

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381930#comment-14381930 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. > [storm-redis] RedisS

[jira] [Issue Comment Deleted] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DashengJu updated STORM-723: Comment: was deleted (was: I'm ok with withExpire() method.) > [storm-redis] RedisStateSetUpdater writes sta

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381932#comment-14381932 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. > [storm-redis] RedisS

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381931#comment-14381931 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. > [storm-redis] RedisS

[GitHub] storm pull request: STORM-587. trident transactional state in zk s...

2015-03-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/475#issuecomment-86536961 Sorry I am wrong, I need to look at it more. It is convoluted the path through the code, which is why I need to look into this more. Right now it appears to be the stream

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381925#comment-14381925 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. > [storm-redis] RedisS

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread DashengJu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381926#comment-14381926 ] DashengJu commented on STORM-723: - I'm ok with withExpire() method. > [storm-redis] RedisS

[jira] [Commented] (STORM-587) trident transactional state in zk should be namespaced with topology id

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381914#comment-14381914 ] ASF GitHub Bot commented on STORM-587: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-587. trident transactional state in zk s...

2015-03-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/475#issuecomment-86529303 -1, I know it is convoluted the path through the code for this, but ID is already the topology name. I don't see a reason to break backwards compatibility to have the top

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381907#comment-14381907 ] ASF GitHub Bot commented on STORM-723: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86526814 I think we should remove these 2 files from all branches, since we'll introduce new classes if we need. --- If your project is set up for it, you can reply to this em

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381902#comment-14381902 ] ASF GitHub Bot commented on STORM-723: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-723 Remove RedisStateSetUpdater / RedisS...

2015-03-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/482#issuecomment-86521810 I am +1 on the change, but my only question is do we want to do this only for all branches? or only for 0.10.X? --- If your project is set up for it, you can reply to thi

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381626#comment-14381626 ] Jungtaek Lim commented on STORM-723: I reviewed RedisStateUpdater and RedisStateQuerier

[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

2015-03-26 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381579#comment-14381579 ] Jungtaek Lim commented on STORM-723: Great! It makes better clarification. Btw, maybe