Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/544#issuecomment-99113342
Great! I looked at b5ace22 and also looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
[
https://issues.apache.org/jira/browse/STORM-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528636#comment-14528636
]
ASF GitHub Bot commented on STORM-809:
--
Github user HeartSaVioR commented on the pull
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/544#issuecomment-99100130
LGTM.
Regarding NotNullPosIntegerValidator, it may be better to add some tests on
config_test.clj.
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/STORM-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528629#comment-14528629
]
ASF GitHub Bot commented on STORM-809:
--
Github user revans2 commented on the pull
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/544#issuecomment-99112732
@HeartSaVioR great comment. I added in the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/STORM-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528548#comment-14528548
]
ASF GitHub Bot commented on STORM-809:
--
Github user HeartSaVioR commented on the pull
Hi All,
What would be the reason for getting this exception while running a
topology? Everything works fine for a while, and then I get this error and
the topology dies.
org.apache.zookeeper.KeeperException$ConnectionLossException:
KeeperErrorCode = ConnectionLoss for /storm/partition_6
...
...