Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/621
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630036#comment-14630036
]
ASF GitHub Bot commented on STORM-926:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/STORM-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-926.
---
Resolution: Fixed
Fix Version/s: 0.11.0
Thanks [~caofangkun],
I merged this
Github user lyonbrw commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122034395
Included reusable parseInputStream for use by parseFile and parseResource.
Also allows a path for programatically creating topologies without the need to
write to / read
[
https://issues.apache.org/jira/browse/STORM-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-793.
---
Resolution: Fixed
Fix Version/s: 0.11.0
Thanks [~sanket991],
I merged this
Github user lyonbrw closed the pull request at:
https://github.com/apache/storm/pull/637
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630083#comment-14630083
]
ASF GitHub Bot commented on STORM-793:
--
Github user asfgit closed the pull request at:
GitHub user lyonbrw reopened a pull request:
https://github.com/apache/storm/pull/637
Add FluxParser method parseInputStream() to eliminate disk usage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lyonbrw/storm master
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630424#comment-14630424
]
ASF GitHub Bot commented on STORM-942:
--
Github user HeartSaVioR commented on the pull
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122117993
@lyonbrw
I cherry-picked your efforts into master now. Would you close this PR?
---
If your project is set up for it, you can reply to this email and have your
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/630#issuecomment-122119993
Since many users are already affected this situation, it should be included
to 0.9.x line.
---
If your project is set up for it, you can reply to this email and
[
https://issues.apache.org/jira/browse/STORM-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630293#comment-14630293
]
ASF GitHub Bot commented on STORM-857:
--
Github user revans2 commented on the pull
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/621#issuecomment-122027544
I ran my own cluster and it looks good so I am inclined to check it in +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/STORM-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630032#comment-14630032
]
ASF GitHub Bot commented on STORM-926:
--
Github user revans2 commented on the pull
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/619
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/619#issuecomment-122010877
+1 looks great to me
@charleswhchan I merged this into master keep up the good work.
---
If your project is set up for it, you can reply to this email and have your
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/620#issuecomment-122011966
+1 looks great to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/620#issuecomment-122012144
@charleswhchan I merged this into master thanks for the update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/620
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/621#issuecomment-122013414
The changes look fine to me. I am a bit concerned about minimizing the
shaded jars. Have you tested this in a stand alone cluster? My understanding
is that it removes
[
https://issues.apache.org/jira/browse/STORM-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629974#comment-14629974
]
ASF GitHub Bot commented on STORM-926:
--
Github user revans2 commented on the pull
[
https://issues.apache.org/jira/browse/STORM-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629960#comment-14629960
]
ASF GitHub Bot commented on STORM-799:
--
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/607
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630311#comment-14630311
]
ASF GitHub Bot commented on STORM-857:
--
Github user asfgit closed the pull request at:
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-122071976
@chuanlei Sorry this has taken so long. The change looks good to me. +1
@HeartSaVioR I don't think we need a JIRA for this, it is a minor
documentation change.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122099913
@lyonbrw
Actually I recommended you to make new branch before do some works.
I can cherry-pick your commits into master, so let me handle it for now.
---
If
Github user lyonbrw commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122099783
Indentation fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/584#issuecomment-122083375
@chuanlei This is a rather interesting feature. It would be nice if you
could file a JIRA for this.
---
If your project is set up for it, you can reply to this email
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/586
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brendan W Lyon updated STORM-942:
-
Affects Version/s: 0.10.0
Fix Version/s: 0.11.0
Add FluxParser method parseInputStream()
[
https://issues.apache.org/jira/browse/STORM-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630264#comment-14630264
]
ASF GitHub Bot commented on STORM-845:
--
Github user revans2 commented on the pull
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630291#comment-14630291
]
ASF GitHub Bot commented on STORM-942:
--
Github user HeartSaVioR commented on a diff in
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/637#discussion_r34835109
--- Diff:
external/flux/flux-core/src/main/java/org/apache/storm/flux/parser/FluxParser.java
---
@@ -44,40 +44,47 @@ private FluxParser(){}
//
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/582#issuecomment-122081360
@chuanlei I like auto-tuning max spout pending, but I am confused what we
are tuning it for. The current code seems to increase the size of
max-spout-pending if the
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630314#comment-14630314
]
ASF GitHub Bot commented on STORM-942:
--
Github user HeartSaVioR commented on the pull
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122090455
@lyonbrw
Indentation is still broken. Please compare parseInputStream()'s indent
level to other methods.
Btw, could you get rid of merge commit from PR
Github user lyonbrw commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122097348
Apologize for the merge commit. What is the proper way to remove it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630336#comment-14630336
]
ASF GitHub Bot commented on STORM-942:
--
Github user lyonbrw commented on the pull
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630348#comment-14630348
]
ASF GitHub Bot commented on STORM-942:
--
Github user HeartSaVioR commented on the pull
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630281#comment-14630281
]
ASF GitHub Bot commented on STORM-942:
--
Github user HeartSaVioR commented on a diff in
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630345#comment-14630345
]
ASF GitHub Bot commented on STORM-942:
--
Github user lyonbrw commented on the pull
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630346#comment-14630346
]
ASF GitHub Bot commented on STORM-942:
--
Github user HeartSaVioR commented on the pull
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122100673
OK, confirmed that all things fixed. +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-122078266
@revans2
I didn't mean this PR needs a JIRA issue. I just guided @chuanlei to get
familiar with contributing rule while waiting for committers to review.
I
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-122078315
@sweetest The code looks great to me. I would like to see some more
javadocs explaining what each of the bolts/state do/need as input. I would
also like to see some
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-122084941
@HeartSaVioR Sounds good. Thanks by the way for all of the reviews before
becoming a committer. We need more people to keep up with all of the pull
requests.
---
If
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/583#issuecomment-122082381
+1
@dossett do you want to file a JIRA for this? It is not a big deal because
it is such a small change, but it does impact what type of credit you get for
your
[
https://issues.apache.org/jira/browse/STORM-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-857.
---
Resolution: Fixed
Fix Version/s: 0.11.0
Thanks [~dagit],
I merged this into
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/582#issuecomment-122097464
@chuanlei
We can get a hint from Heron paper that Twitter don't catch up latest Storm
version.
Paper mentions ZeroMQ, but Storm changes default transport
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/570
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630676#comment-14630676
]
caofangkun commented on STORM-930:
--
See:
[
https://issues.apache.org/jira/browse/STORM-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630681#comment-14630681
]
Xin Wang commented on STORM-732:
Sorry I took so long to respond. You can visit
GitHub user tedxia opened a pull request:
https://github.com/apache/storm/pull/639
STORM-946: We should remove Closed Client form cached-node+port-socket in
worker
Patch for [STORM-946](https://issues.apache.org/jira/browse/STORM-946)
The client may be Closed status after
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/615#issuecomment-122156319
@revans2
The whole usages call delete-node with ```:force true```, that is the
```:force ``` parameter is unneeded at all.
---
If your project is set up for
[
https://issues.apache.org/jira/browse/STORM-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630697#comment-14630697
]
ASF GitHub Bot commented on STORM-913:
--
Github user caofangkun commented on the pull
[
https://issues.apache.org/jira/browse/STORM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630716#comment-14630716
]
ASF GitHub Bot commented on STORM-945:
--
GitHub user caofangkun opened a pull request:
[
https://issues.apache.org/jira/browse/STORM-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630661#comment-14630661
]
ASF GitHub Bot commented on STORM-913:
--
Github user vesense commented on the pull
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/615#issuecomment-122147057
-0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/638
STORM-945:DefaultRolloverStrategy element is not a policy,and should not
be putted in the Policies element
```
- storm-current bin/storm nimbus
Running: /usr/share/jdk-current/bin/java
[
https://issues.apache.org/jira/browse/STORM-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630728#comment-14630728
]
ASF GitHub Bot commented on STORM-946:
--
GitHub user tedxia opened a pull request:
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/639#issuecomment-122184898
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/STORM-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630819#comment-14630819
]
ASF GitHub Bot commented on STORM-946:
--
Github user vesense commented on the pull
caofangkun created STORM-945:
Summary: DefaultRolloverStrategy element is not a policy,and
should not be putted in the Policies element.
Key: STORM-945
URL: https://issues.apache.org/jira/browse/STORM-945
xiajun created STORM-946:
Summary: We should remove Closed Client form
cached-node+port-socket in worker
Key: STORM-946
URL: https://issues.apache.org/jira/browse/STORM-946
Project: Apache Storm
[
https://issues.apache.org/jira/browse/STORM-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiajun updated STORM-946:
-
Description:
The client may be Closed status after reconnect failed, and we will remove
closed client from
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/630#issuecomment-122113950
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/STORM-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630397#comment-14630397
]
ASF GitHub Bot commented on STORM-935:
--
Github user HeartSaVioR commented on the pull
[
https://issues.apache.org/jira/browse/STORM-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim updated STORM-728:
---
Fix Version/s: (was: 0.10.0)
0.9.6
UI: Component Page Spout stats table has
[
https://issues.apache.org/jira/browse/STORM-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim updated STORM-728:
---
Affects Version/s: (was: 0.10.0)
0.9.5
UI: Component Page Spout stats
[
https://issues.apache.org/jira/browse/STORM-944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Dossett reassigned STORM-944:
---
Assignee: Aaron Dossett
storm-hive pom.xml has a dependency conflict with calcite
[
https://issues.apache.org/jira/browse/STORM-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Dossett reopened STORM-943:
-
Reopening since the pull request is not yet merged
In TestHiveBolt make the collector mock slightly
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630624#comment-14630624
]
Aaron Dossett commented on STORM-944:
-
Pull request available here:
[
https://issues.apache.org/jira/browse/STORM-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Dossett resolved STORM-943.
-
Resolution: Fixed
In TestHiveBolt make the collector mock slightly more precise
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/630#issuecomment-122124259
It is merged to master, and I'm working on backport to 0.10.x and 0.9.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/STORM-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630469#comment-14630469
]
ASF GitHub Bot commented on STORM-935:
--
Github user HeartSaVioR commented on the pull
[
https://issues.apache.org/jira/browse/STORM-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630468#comment-14630468
]
ASF GitHub Bot commented on STORM-935:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630518#comment-14630518
]
ASF GitHub Bot commented on STORM-942:
--
Github user lyonbrw commented on the pull
Github user lyonbrw commented on the pull request:
https://github.com/apache/storm/pull/637#issuecomment-122130478
Will do. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630519#comment-14630519
]
ASF GitHub Bot commented on STORM-942:
--
Github user lyonbrw closed the pull request
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/630#issuecomment-122131324
I merged this into 0.10.x-branch and 0.9.x-branch by cherry-picked.
Since there're different available sets of config validators among branches
- master,
Github user lyonbrw closed the pull request at:
https://github.com/apache/storm/pull/637
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim resolved STORM-935.
Resolution: Fixed
Fix Version/s: 0.9.6
Thanks [~xingyu] for great work.
I merged into master,
[
https://issues.apache.org/jira/browse/STORM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim resolved STORM-942.
Resolution: Fixed
Assignee: Brendan W Lyon
Thanks [~lyonbrw] for the great work.
I merged into
[
https://issues.apache.org/jira/browse/STORM-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630429#comment-14630429
]
ASF GitHub Bot commented on STORM-943:
--
Github user dossett commented on the pull
[
https://issues.apache.org/jira/browse/STORM-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630534#comment-14630534
]
ASF GitHub Bot commented on STORM-935:
--
Github user HeartSaVioR commented on the pull
[
https://issues.apache.org/jira/browse/STORM-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim updated STORM-935:
---
Affects Version/s: 0.9.5
0.10.0
Update Disruptor queue version to 2.10.4
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/611
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-122113786
@revans2
Sure. The more, the better.
We(PMC members) are responsible for considering how to make Storm community
more active.
---
If your project is set up
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/583#issuecomment-122118472
Thanks for the feedback @revans2. STORM-943 created and associated to this
JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/STORM-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim resolved STORM-503.
Resolution: Fixed
Assignee: Xingyu Su
Thanks [~xingyu] for great work.
I merged into master,
[
https://issues.apache.org/jira/browse/STORM-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim updated STORM-503:
---
Fix Version/s: 0.9.6
Short disruptor queue wait time leads to high CPU usage when idle
[
https://issues.apache.org/jira/browse/STORM-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630568#comment-14630568
]
Jungtaek Lim commented on STORM-728:
Thanks [~dagit], I merged new PR into
93 matches
Mail list logo
