[jira] [Commented] (STORM-1052) TridentKafkaState uses new Kafka Producer API

[ https://issues.apache.org/jira/browse/STORM-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14805042#comment-14805042 ] ASF GitHub Bot commented on STORM-1052: --- GitHub user vesense opened a pull request:

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/743 [STORM-1052] TridentKafkaState uses new Kafka Producer API You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-6 Alternatively

Re: Emitting Custom Object as Tuple from spout

You can implement your own backtype.storm.spout.MultiScheme where in backtype.storm.spout.MultiScheme.deserialize(byte[]) allows you to convert your data in required object. However you also need to register the class for serialisation using backtype.storm.Config.registerSerialization(Class)

[GitHub] storm pull request: configurable supervisor log filename

Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/733#issuecomment-141532910 +1. sorry for the delay. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: configurable supervisor log filename

Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/733#issuecomment-141532980 will wait for 24 hours as per our Bylaws and merge it in tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876687#comment-14876687 ] ASF GitHub Bot commented on STORM-1051: --- Github user schonfeld commented on the pull request:

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876686#comment-14876686 ] Michael Schonfeld commented on STORM-1051: -- Do I need to attach a patch file? Or is the pull

[GitHub] storm pull request: [STORM-1005] set storm.local.dir relative valu...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/722 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/745#issuecomment-141593987 @schonfeld Yes, we maintains three version lines, master (0.11.x), 0.10.x, 0.9.x. It should be applied to all three version branches. --- If your project is

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876694#comment-14876694 ] ASF GitHub Bot commented on STORM-1051: --- Github user HeartSaVioR commented on the pull request:

[jira] [Updated] (STORM-1005) Supervisor do not get running workers after restart.

[ https://issues.apache.org/jira/browse/STORM-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-1005: Component/s: (was: Storm-eventhubs) > Supervisor do not get running workers after restart. >

[jira] [Commented] (STORM-1005) Supervisor do not get running workers after restart.

[ https://issues.apache.org/jira/browse/STORM-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876720#comment-14876720 ] ASF GitHub Bot commented on STORM-1005: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (STORM-1005) Supervisor do not get running workers after restart.

[ https://issues.apache.org/jira/browse/STORM-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1005. - Resolution: Fixed Assignee: Renkai Ge Fix Version/s: 0.10.0 Thanks [~RenkaiGe], I

[jira] [Commented] (STORM-1005) Supervisor do not get running workers after restart.

[ https://issues.apache.org/jira/browse/STORM-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876755#comment-14876755 ] ASF GitHub Bot commented on STORM-1005: --- Github user erikdw commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-1005]replace default storm.local.dir va...

Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/713#discussion_r39913602 --- Diff: docs/documentation/Setting-up-a-Storm-cluster.md --- @@ -52,10 +52,13 @@ storm.zookeeper.servers: If the port that your Zookeeper cluster

[GitHub] storm pull request: [STORM-1032] Add generics to component configu...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1032) Add generics to component configuration methods

[ https://issues.apache.org/jira/browse/STORM-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876761#comment-14876761 ] ASF GitHub Bot commented on STORM-1032: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/745#discussion_r39913836 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -317,7 +317,7 @@ private int iteratorSize(Iterator msgs) { * If the

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876768#comment-14876768 ] ASF GitHub Bot commented on STORM-1051: --- Github user erikdw commented on a diff in the pull request:

[GitHub] storm pull request: configurable supervisor log filename

Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/733#issuecomment-141549873 +1 on merging into 0.10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876702#comment-14876702 ] ASF GitHub Bot commented on STORM-1051: --- Github user schonfeld commented on the pull request:

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

Github user schonfeld commented on the pull request: https://github.com/apache/storm/pull/745#issuecomment-141595905 Ah, ok! Here's what it looked like in our logs, just in case someone else tries to Google the exception at some point... ``` 2015-09-17 15:03:22

[jira] [Resolved] (STORM-1032) Add generics to component configuration methods

[ https://issues.apache.org/jira/browse/STORM-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1032. - Resolution: Fixed Fix Version/s: 0.11.0 Thanks [~ddebree], I merged into master. > Add

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876683#comment-14876683 ] ASF GitHub Bot commented on STORM-1051: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

Github user schonfeld commented on the pull request: https://github.com/apache/storm/pull/745#issuecomment-141593725 @HeartSaVioR all branches >= 0.9.6 ... that's when STORM-763 introduced the bug. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876713#comment-14876713 ] Jungtaek Lim commented on STORM-1051: - We are waiting for more reviewer to review. In bylaws, we

[jira] [Created] (STORM-1053) Correct storm-kafka readme file because of using new kafka-clients api

Xin Wang created STORM-1053: --- Summary: Correct storm-kafka readme file because of using new kafka-clients api Key: STORM-1053 URL: https://issues.apache.org/jira/browse/STORM-1053 Project: Apache Storm

[jira] [Updated] (STORM-1053) Correct storm-kafka readme file because of using new kafka-clients api

[ https://issues.apache.org/jira/browse/STORM-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Wang updated STORM-1053: Priority: Minor (was: Major) > Correct storm-kafka readme file because of using new kafka-clients api >

[jira] [Commented] (STORM-1053) Correct storm-kafka readme file because of using new kafka-clients api

[ https://issues.apache.org/jira/browse/STORM-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14805118#comment-14805118 ] ASF GitHub Bot commented on STORM-1053: --- GitHub user vesense opened a pull request:

[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...

GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/744 [STORM-1053] Correct storm-kafka readme file because of using new kafka-clients api correct readme file: new producer link & configs You can merge this pull request into a Git repository by

[GitHub] storm pull request: configurable supervisor log filename

Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/733#issuecomment-141541329 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/700#issuecomment-141544473 @zhuoliu I looked over the code, and I ran some tests with a word count program that does not sleep, and there are not enough split sentence bolts. This kept the

[jira] [Comment Edited] (STORM-893) Resource Aware Scheduling

[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876237#comment-14876237 ] Boyang Jerry Peng edited comment on STORM-893 at 9/18/15 7:53 PM: --

[jira] [Updated] (STORM-886) Automatic Back Pressure

[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-886: --- Attachment: (was: an simple example for backpressure.png) > Automatic Back Pressure >

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

GitHub user jerrypeng opened a pull request: https://github.com/apache/storm/pull/746 [STORM-893] Resource Aware Scheduling I have created a initial open source implementation of the Resource Aware Scheduler as described in the paper I published:

[GitHub] storm pull request: configurable supervisor log filename

Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/733#issuecomment-141547493 @erikdw This is a small enough change that I personally would feel OK with pulling this into the 0.10 release branch, but I would want at least one other committer to

[GitHub] storm pull request: configurable supervisor log filename

Github user erikdw commented on the pull request: https://github.com/apache/storm/pull/733#issuecomment-141545439 Thanks guys! Can I help with backporting it to the 0.9.6 train? I sent a PR to that branch, but I feel like that might been counterproductive? Also, is there any

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/745#issuecomment-141545624 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: Netty Zlib Encoding Decoding

https://github.com/apache/storm/blob/master/storm-core/src/jvm/backtype/storm/Config.java#L212-L217  topology.tuple.serializer - Bobby On Friday, September 18, 2015 12:54 PM, Onur Yalazı wrote: Hello Bobby, If it's possible to enable a TupleSerializer

Re: Netty Zlib Encoding Decoding

Hello Bobby, If it's possible to enable a TupleSerializer while submitting topologies, without touching Storm's internals it would be really wise and a fast way to implement compression. Actually I have no idea if it's possible this way. Other than that, If I got the Netty's gist right, to

[jira] [Commented] (STORM-893) Resource Aware Scheduling

[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876154#comment-14876154 ] ASF GitHub Bot commented on STORM-893: -- GitHub user jerrypeng opened a pull request:

[jira] [Commented] (STORM-886) Automatic Back Pressure

[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876214#comment-14876214 ] ASF GitHub Bot commented on STORM-886: -- Github user asfgit closed the pull request at:

[jira] [Resolved] (STORM-886) Automatic Back Pressure

[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-886. --- Resolution: Fixed Fix Version/s: 0.11.0 Thanks [~zhuoliu], Sorry it took so

[jira] [Updated] (STORM-886) Automatic Back Pressure

[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-886: --- Attachment: aSimpleExampleOfBackpressure.png > Automatic Back Pressure > --- > >

[jira] [Updated] (STORM-1050) Topologies with same name run on one cluster

[ https://issues.apache.org/jira/browse/STORM-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-1050: Affects Version/s: 0.9.5 0.10.0 > Topologies with same name run on one

[jira] [Resolved] (STORM-1050) Topologies with same name run on one cluster

[ https://issues.apache.org/jira/browse/STORM-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1050. - Resolution: Fixed Assignee: chenyuzhao Fix Version/s: (was: 0.11.0)

[jira] [Commented] (STORM-1050) Topologies with same name run on one cluster

[ https://issues.apache.org/jira/browse/STORM-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876810#comment-14876810 ] ASF GitHub Bot commented on STORM-1050: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-1050:Topologies with same name run on on...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/739 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

Github user schonfeld commented on a diff in the pull request: https://github.com/apache/storm/pull/745#discussion_r39916772 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -317,7 +317,7 @@ private int iteratorSize(Iterator msgs) { * If the

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876909#comment-14876909 ] ASF GitHub Bot commented on STORM-1051: --- Github user schonfeld commented on the pull request:

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

Github user schonfeld commented on the pull request: https://github.com/apache/storm/pull/745#issuecomment-141625088 @erikdw better now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876911#comment-14876911 ] ASF GitHub Bot commented on STORM-1051: --- Github user schonfeld commented on a diff in the pull

[jira] [Updated] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-1051: Priority: Critical (was: Major) > Netty Client.java's flushMessages produces a

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876667#comment-14876667 ] Jungtaek Lim commented on STORM-1051: - It could occur easily, and the result is shown as strange

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/745#issuecomment-141580360 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-1012 STORM-967 STORM-922 STORM-1042 Shad...

Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/741#issuecomment-141475150 @HeartSaVioR Great I will upmerge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (STORM-1012) Shade Jackson dependency

[ https://issues.apache.org/jira/browse/STORM-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875726#comment-14875726 ] ASF GitHub Bot commented on STORM-1012: --- Github user revans2 commented on the pull request:

Exception using custom 0.9.6 RPM

Hi, We installed a custom RPM built from the 0.9.x branch in an attempt to fix this bug: https://issues.apache.org/jira/browse/STORM-763 But when running on the new installation, we see the below stacktrace. Any recommendations of how to fix the issue we are seeing, or if/when a stable release

Netty Zlib Encoding Decoding

Hello, I'm very new to storm world and the list, so Hello from Turkey. Because of a recent incident we had to increase our openstack network bandwidth soft limits from 1gb/s to 2gb/s. And of course even though the problem resides in our tuples' size and topology size, I thought if storm's

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/700 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-886) Automatic Back Pressure

[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875866#comment-14875866 ] ASF GitHub Bot commented on STORM-886: -- Github user revans2 commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/700#discussion_r39872683 --- Diff: storm-core/src/jvm/backtype/storm/utils/DisruptorQueue.java --- @@ -35,6 +35,7 @@ import java.util.HashMap; import java.util.Map;

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/700#issuecomment-141499766 For the most part things look really good. I would also love to see something added to Examples. Like a Word Count that just goes as fast as it can. That way we can

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

GitHub user schonfeld opened a pull request: https://github.com/apache/storm/pull/745 [STORM-1051] Fix for flushMessagse NPE STORM-763 introduced a situation in which flushMessages could receive batch = null, in which case, an NPE is thrown because we weren't validating != null

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

Github user schonfeld closed the pull request at: https://github.com/apache/storm/pull/742 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

Github user schonfeld commented on the pull request: https://github.com/apache/storm/pull/742#issuecomment-141500177 Closing in favor of PR #745 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/700#discussion_r39871444 --- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj --- @@ -602,6 +640,7 @@ (log-message "Activating spout " component-id

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875909#comment-14875909 ] ASF GitHub Bot commented on STORM-1051: --- Github user schonfeld commented on the pull request:

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875907#comment-14875907 ] ASF GitHub Bot commented on STORM-1051: --- GitHub user schonfeld opened a pull request:

[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

[ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875910#comment-14875910 ] ASF GitHub Bot commented on STORM-1051: --- Github user schonfeld closed the pull request at:

[GitHub] storm pull request: Disruptor Queue Batching (DON'T MERGE YET)

Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/704#issuecomment-141484458 I have done a lot of testing on this, and we need batching, but this is not the correct way to do it. I have a proof of concept with some micro benchmarks, but I am

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/700#issuecomment-141491743 @zhuoliu looks like you missed adding in a file, We also need to upmerge. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: [STORM-1051] Fix for flushMessagse NPE

Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/742#issuecomment-141480621 @schonfeld Could you post a new PR which points to master, too? Thanks in advance! --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (STORM-1012) Shade Jackson dependency

[ https://issues.apache.org/jira/browse/STORM-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875778#comment-14875778 ] ASF GitHub Bot commented on STORM-1012: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-886) Automatic Back Pressure

[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875828#comment-14875828 ] ASF GitHub Bot commented on STORM-886: -- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/700#discussion_r39872212 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -1024,6 +1024,48 @@ /** + * Whether to enable backpressure in for a

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/700#discussion_r39872538 --- Diff: storm-core/src/jvm/backtype/storm/utils/DisruptorQueue.java --- @@ -138,7 +150,21 @@ private void consumeBatchToCursor(long cursor, EventHandler

[jira] [Commented] (STORM-886) Automatic Back Pressure

[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875862#comment-14875862 ] ASF GitHub Bot commented on STORM-886: -- Github user revans2 commented on a diff in the pull request:

[jira] [Commented] (STORM-886) Automatic Back Pressure

[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876011#comment-14876011 ] ASF GitHub Bot commented on STORM-886: -- Github user zhuoliu commented on the pull request:

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/700#issuecomment-141514572 Thanks, Bobby @revans2 . I addressed all the comments. Actually I have such examples already written and tested. See:

Re: Netty Zlib Encoding Decoding

Compression was just not something that we really though about all that much.  The fastest route is probably to replace the tuple serializer with one that can handle compression.  We did something similar for encryption.