[GitHub] storm pull request: fix keyword (schema -> scheme) from main-route...

2015-10-21 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/809 fix keyword (schema -> scheme) from main-routes You can merge this pull request into a Git repository by running: $ git pull https://github.com/HeartSaVioR/storm STORM-1120 Alternatively

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967379#comment-14967379 ] ASF GitHub Bot commented on STORM-1057: --- Github user wangli1426 commented on the pull request:

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-10-21 Thread wangli1426
Github user wangli1426 commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-149948793 Hi @revans2 , Recent commits to the master branch cause conflict to my PR, so I up-merged my PR in 4de33d1. Could you please review the code again? Thank you very

Storm at Stackoverflow

2015-10-21 Thread Matthias J. Sax
Hi, currently, there are two tags (apache-storm and storm) used on SO. I just suggested "apache-storm" to be the main tag and "storm" to be a synonym for it. This enables that all questions get tagged with a unique tag. Old and new questions get re-tag from storm to apache-storm automatically if

[jira] [Created] (STORM-1121) Improve Nimbus Topology submission time

2015-10-21 Thread Kishor Patil (JIRA)
Kishor Patil created STORM-1121: --- Summary: Improve Nimbus Topology submission time Key: STORM-1121 URL: https://issues.apache.org/jira/browse/STORM-1121 Project: Apache Storm Issue Type: Bug

[GitHub] storm pull request: Minor grammar fix to FAQ

2015-10-21 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/808#issuecomment-149974237 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: Disruptor batching v2

2015-10-21 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/765#issuecomment-149987537 So I have been running a number of tests trying to come to a conclusive decision on how storm should handle batching, and trying to understand the difference between my

[jira] [Commented] (STORM-1121) Improve Nimbus Topology submission time

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967654#comment-14967654 ] ASF GitHub Bot commented on STORM-1121: --- Github user revans2 commented on a diff in the pull

[jira] [Commented] (STORM-855) Add tuple batching

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967622#comment-14967622 ] ASF GitHub Bot commented on STORM-855: -- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-21 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/810 [STORM-1121] Remove method call to avoid overhead during topology submission time Nimbus calls mk-assignments from SubmitTopology within lock is causing it to wait for processing of all

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-21 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/810#discussion_r42666392 --- Diff: storm-core/test/clj/backtype/storm/integration_test.clj --- @@ -236,6 +237,7 @@ "acking-test1"

[jira] [Commented] (STORM-1121) Improve Nimbus Topology submission time

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967689#comment-14967689 ] ASF GitHub Bot commented on STORM-1121: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1111) Fix Validation for lots of different configs

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967714#comment-14967714 ] ASF GitHub Bot commented on STORM-: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1111] - Fix Validation for lots of diff...

2015-10-21 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/807#discussion_r42669817 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -1215,6 +1254,7 @@ * to be equal to the number of workers configured for this

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967757#comment-14967757 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-21 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/810#issuecomment-149996906 I love the concept, but I would like to see the tests updated so we are not adding several mins to the time it takes to run the unit tests. --- If your project is set

[GitHub] storm pull request: [STORM-1111] - Fix Validation for lots of diff...

2015-10-21 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/807#discussion_r42669491 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -247,6 +253,7 @@ * * Defaults to false. */ +@Deprecated

[jira] [Commented] (STORM-1111) Fix Validation for lots of different configs

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967711#comment-14967711 ] ASF GitHub Bot commented on STORM-: --- Github user revans2 commented on a diff in the pull

[jira] [Commented] (STORM-1111) Fix Validation for lots of different configs

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967715#comment-14967715 ] ASF GitHub Bot commented on STORM-: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1111] - Fix Validation for lots of diff...

2015-10-21 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/807#issuecomment-150001051 Just two minor nits and then I am +1 on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-1115] Stale leader-lock key effectively...

2015-10-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/802 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1115) Stale leader-lock key effectively bans all nodes from becoming leaders

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967732#comment-14967732 ] ASF GitHub Bot commented on STORM-1115: --- Github user asfgit closed the pull request at:

[jira] [Updated] (STORM-1115) Stale leader-lock key effectively bans all nodes from becoming leaders

2015-10-21 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans updated STORM-1115: --- Assignee: Daniel Schonfeld > Stale leader-lock key effectively bans all nodes from

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967756#comment-14967756 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-10-21 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-150007774 I just have two minor questions now. After that I am +1, but I would like to hear from @d2r. He wrote a lot of the recent metrics code changes and I value his opinion

[jira] [Resolved] (STORM-1115) Stale leader-lock key effectively bans all nodes from becoming leaders

2015-10-21 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1115. Resolution: Fixed Fix Version/s: 0.11.0 Thanks [~danielschonfeld], I merged

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967738#comment-14967738 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-10-21 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r42671953 --- Diff: STORM-UI-REST-API.md --- @@ -351,11 +354,13 @@ Sample response: "executors": 12, "emitted": 184580,

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-10-21 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r42673357 --- Diff: storm-core/src/clj/backtype/storm/stats.clj --- @@ -277,15 +277,34 @@ (value-stats stats SPOUT-FIELDS) {:type :spout}))

[jira] [Commented] (STORM-1121) Improve Nimbus Topology submission time

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968137#comment-14968137 ] ASF GitHub Bot commented on STORM-1121: --- Github user kishorvpatil commented on the pull request:

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-21 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/810#issuecomment-150049582 @HeartSaVioR looking into compilation issue. Somehow it did not get committed. Re-running the build. --- If your project is set up for it, you can reply to this

[jira] [Resolved] (STORM-1017) If ignoreZkOffsets set true,KafkaSpout will reset zk offset when recover from failure.

2015-10-21 Thread Priyank Shah (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priyank Shah resolved STORM-1017. - Resolution: Fixed > If ignoreZkOffsets set true,KafkaSpout will reset zk offset when recover from

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/810#issuecomment-150051486 @kishorvpatil rebalance seems not work cause it requires topology to be alive at the moment. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (STORM-1121) Improve Nimbus Topology submission time

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968155#comment-14968155 ] ASF GitHub Bot commented on STORM-1121: --- Github user HeartSaVioR commented on the pull request:

[jira] [Updated] (STORM-1017) If ignoreZkOffsets set true,KafkaSpout will reset zk offset when recover from failure.

2015-10-21 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-1017: Fix Version/s: 0.11.0 > If ignoreZkOffsets set true,KafkaSpout will reset zk offset when recover

[jira] [Commented] (STORM-1121) Improve Nimbus Topology submission time

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968106#comment-14968106 ] ASF GitHub Bot commented on STORM-1121: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: [STORM-1121] Remove method call to avoid overh...

2015-10-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/810#issuecomment-150045478 @kishorvpatil You may want to check Travis build failure, seems like there's a missing spot. > Exception in thread "main"

[jira] [Commented] (STORM-1121) Improve Nimbus Topology submission time

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968116#comment-14968116 ] ASF GitHub Bot commented on STORM-1121: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-10-21 Thread wangli1426
Github user wangli1426 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r42704498 --- Diff: storm-core/src/clj/backtype/storm/stats.clj --- @@ -277,15 +277,34 @@ (value-stats stats SPOUT-FIELDS) {:type

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-10-21 Thread wangli1426
Github user wangli1426 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r42704561 --- Diff: STORM-UI-REST-API.md --- @@ -351,11 +354,13 @@ Sample response: "executors": 12, "emitted": 184580,

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968353#comment-14968353 ] ASF GitHub Bot commented on STORM-1057: --- Github user wangli1426 commented on a diff in the pull

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968354#comment-14968354 ] ASF GitHub Bot commented on STORM-1057: --- Github user wangli1426 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-10-21 Thread wangli1426
Github user wangli1426 commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-150076986 Hi @revans2 , Thanks for very much for your time and efforts. Following your suggestions, I have made ```update-values``` as a regular function and fixed the

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968355#comment-14968355 ] ASF GitHub Bot commented on STORM-1057: --- Github user wangli1426 commented on the pull request:

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-10-21 Thread wangli1426
Github user wangli1426 commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-150077548 Hi @d2r, Could you please review this PR? Your response is highly appreciated. Thanks. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968358#comment-14968358 ] ASF GitHub Bot commented on STORM-1057: --- Github user wangli1426 commented on the pull request:

Re: Storm at Stackoverflow

2015-10-21 Thread 임정택
Nice work Matthias! Upvoted. Jungtaek Lim (HeartSaVioR) 2015-10-22 1:16 GMT+09:00 Matthias J. Sax : > Hi, > > currently, there are two tags (apache-storm and storm) used on SO. I > just suggested "apache-storm" to be the main tag and "storm" to be a > synonym for it. This

[jira] [Created] (STORM-1120) main-routes in backtype.storm.ui.core uses wrong keyword - schema

2015-10-21 Thread Jungtaek Lim (JIRA)
Jungtaek Lim created STORM-1120: --- Summary: main-routes in backtype.storm.ui.core uses wrong keyword - schema Key: STORM-1120 URL: https://issues.apache.org/jira/browse/STORM-1120 Project: Apache Storm