[GitHub] storm pull request: [STORM-1254]: port ui.helper to java

2016-02-24 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/storm/pull/1139#discussion_r53916420 --- Diff: storm-core/src/clj/org/apache/storm/ui/helpers.clj --- @@ -46,197 +46,3 @@ (fn [req] --- End diff -- I prefer to leave it here, s

[jira] [Commented] (STORM-1254) port backtype.storm.ui.helpers to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162761#comment-15162761 ] ASF GitHub Bot commented on STORM-1254: --- Github user wuchong commented on a diff in

[GitHub] storm pull request: [STORM-1254]: port ui.helper to java

2016-02-24 Thread wuchong
Github user wuchong commented on the pull request: https://github.com/apache/storm/pull/1139#issuecomment-188174878 @revans2 @abhishekagarwal87 @hustfxj Thanks for your review, I have addressed all the comments. Can you have a look again? --- If your project is set up fo

[jira] [Commented] (STORM-1254) port backtype.storm.ui.helpers to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162766#comment-15162766 ] ASF GitHub Bot commented on STORM-1254: --- Github user wuchong commented on the pull r

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread satishd
Github user satishd commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188196306 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-1569) Allowing users to specify the nimbus thrift server queue size.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162826#comment-15162826 ] ASF GitHub Bot commented on STORM-1569: --- Github user satishd commented on the pull r

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188215628 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1569) Allowing users to specify the nimbus thrift server queue size.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162872#comment-15162872 ] ASF GitHub Bot commented on STORM-1569: --- Github user abhishekagarwal87 commented on

[GitHub] storm pull request: [STORM-1252] port backtype.storm.stats to java

2016-02-24 Thread unsleepy22
GitHub user unsleepy22 opened a pull request: https://github.com/apache/storm/pull/1147 [STORM-1252] port backtype.storm.stats to java This PR is quite large but because the defrecords are changed to java POJO's and they're used in many places, I could not break it into small PR's.

[jira] [Commented] (STORM-1252) port backtype.storm.stats to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162959#comment-15162959 ] ASF GitHub Bot commented on STORM-1252: --- GitHub user unsleepy22 opened a pull reques

[jira] [Commented] (STORM-1570) Support nested field lookup and user defined functions in Storm sql

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162976#comment-15162976 ] ASF GitHub Bot commented on STORM-1570: --- Github user satishd commented on a diff in

[GitHub] storm pull request: [STORM-1570] Storm SQL support for nested fiel...

2016-02-24 Thread satishd
Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/1141#discussion_r53937034 --- Diff: external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/ExprCompiler.java --- @@ -234,14 +253,20 @@ public String translate(ExprCompiler

[GitHub] storm pull request: [STORM-1570] Storm SQL support for nested fiel...

2016-02-24 Thread satishd
Github user satishd commented on the pull request: https://github.com/apache/storm/pull/1141#issuecomment-188257212 Overall LGTM. +1 once the comment is addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[jira] [Commented] (STORM-1570) Support nested field lookup and user defined functions in Storm sql

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162987#comment-15162987 ] ASF GitHub Bot commented on STORM-1570: --- Github user satishd commented on the pull r

[GitHub] storm pull request: [STORM-1252] port backtype.storm.stats to java

2016-02-24 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1147#issuecomment-188278662 PR is indeed quite large. StatsUtil file is too large right now. I think while we are porting from clojure, we should also shift from functional paradigm to Ob

[jira] [Commented] (STORM-1252) port backtype.storm.stats to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163079#comment-15163079 ] ASF GitHub Bot commented on STORM-1252: --- Github user abhishekagarwal87 commented on

[GitHub] storm pull request: [STORM-1252] port backtype.storm.stats to java

2016-02-24 Thread unsleepy22
Github user unsleepy22 commented on the pull request: https://github.com/apache/storm/pull/1147#issuecomment-188288595 @abhishekagarwal87 thanks, good point! I'll address your comments~ --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[jira] [Commented] (STORM-1252) port backtype.storm.stats to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163131#comment-15163131 ] ASF GitHub Bot commented on STORM-1252: --- Github user unsleepy22 commented on the pul

[GitHub] storm pull request: Documentation for cgroup support in Storm

2016-02-24 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1054#issuecomment-188304984 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[jira] [Commented] (STORM-1254) port backtype.storm.ui.helpers to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163208#comment-15163208 ] ASF GitHub Bot commented on STORM-1254: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1254]: port ui.helper to java

2016-02-24 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1139#issuecomment-188311189 +1 looks good. I am still seeing some issues with ``` java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.String at org.apa

[GitHub] storm pull request: [STORM-1273] port backtype.storm.cluster to ja...

2016-02-24 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1081#discussion_r53958459 --- Diff: storm-core/src/jvm/org/apache/storm/cluster/ClusterUtils.java --- @@ -0,0 +1,261 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (STORM-1273) port backtype.storm.cluster to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163225#comment-15163225 ] ASF GitHub Bot commented on STORM-1273: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1273] port backtype.storm.cluster to ja...

2016-02-24 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1081#issuecomment-188328586 +1 looks god to me. Did some manual testing and things look good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (STORM-1273) port backtype.storm.cluster to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163262#comment-15163262 ] ASF GitHub Bot commented on STORM-1273: --- Github user revans2 commented on the pull r

[jira] [Commented] (STORM-1273) port backtype.storm.cluster to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163265#comment-15163265 ] ASF GitHub Bot commented on STORM-1273: --- Github user asfgit closed the pull request

[jira] [Resolved] (STORM-1273) port backtype.storm.cluster to java

2016-02-24 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1273. Thanks [~Johnbaba], I merged this into master. > port backtype.storm.cluster to java >

[GitHub] storm pull request: [STORM-1273] port backtype.storm.cluster to ja...

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1081 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request: [STORM-1572] throw NPE when parsing the comman...

2016-02-24 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1142#discussion_r53965439 --- Diff: storm-core/src/jvm/org/apache/storm/command/CLI.java --- @@ -238,10 +238,13 @@ public CLIBuilder arg(String name, Parse parse, Assoc assoc) {

[jira] [Commented] (STORM-1572) throw NPE when parsing the command line arguments by CLI

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163289#comment-15163289 ] ASF GitHub Bot commented on STORM-1572: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1572] throw NPE when parsing the comman...

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (STORM-1572) throw NPE when parsing the command line arguments by CLI

2016-02-24 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1572. Resolution: Fixed Fix Version/s: 2.0.0 Thanks [~Johnbaba], I merged this int

[jira] [Commented] (STORM-1572) throw NPE when parsing the command line arguments by CLI

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163300#comment-15163300 ] ASF GitHub Bot commented on STORM-1572: --- Github user asfgit closed the pull request

[GitHub] storm pull request: [STORM-1267, STORM-1266, STORM-1265] Port set_...

2016-02-24 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1137#issuecomment-188358152 +1 There is a merge conflict in the test. It is minor and I can fix it when doing the merge. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (STORM-1267) port backtype.storm.command.set-log-level to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163338#comment-15163338 ] ASF GitHub Bot commented on STORM-1267: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1267, STORM-1266, STORM-1265] Port set_...

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1267) port backtype.storm.command.set-log-level to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163372#comment-15163372 ] ASF GitHub Bot commented on STORM-1267: --- Github user asfgit closed the pull request

[jira] [Resolved] (STORM-1265) port backtype.storm.command.monitor to java

2016-02-24 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1265. Resolution: Fixed Fix Version/s: 2.0.0 Thanks [~abhishek.agarwal], I merged

[jira] [Resolved] (STORM-1267) port backtype.storm.command.set-log-level to java

2016-02-24 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1267. Resolution: Fixed Fix Version/s: 2.0.0 Thanks [~abhishek.agarwal], I merged

[jira] [Resolved] (STORM-1266) port backtype.storm.command.rebalance to java

2016-02-24 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1266. Resolution: Fixed Fix Version/s: 2.0.0 Thanks [~abhishek.agarwal], I merged

[jira] [Commented] (STORM-1488) UI Topology Page component last error timestamp is from 1970

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163397#comment-15163397 ] ASF GitHub Bot commented on STORM-1488: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1488] fix broken component error times

2016-02-24 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1129#issuecomment-188375495 +1 the travis failure looks unrelated. Do you have a corresponding fix for master? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] storm pull request: [STORM-1564] fix wrong package-info in org.apa...

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1564) fix wrong package-info in org.apache.storm.utils.staticmocking

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163425#comment-15163425 ] ASF GitHub Bot commented on STORM-1564: --- Github user asfgit closed the pull request

[jira] [Resolved] (STORM-1564) fix wrong package-info in org.apache.storm.utils.staticmocking

2016-02-24 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1564. Resolution: Fixed Fix Version/s: 2.0.0 Thanks [~vesense], I merged this into

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188409357 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[jira] [Commented] (STORM-1569) Allowing users to specify the nimbus thrift server queue size.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163541#comment-15163541 ] ASF GitHub Bot commented on STORM-1569: --- Github user knusbaum commented on the pull

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1569) Allowing users to specify the nimbus thrift server queue size.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163551#comment-15163551 ] ASF GitHub Bot commented on STORM-1569: --- Github user asfgit closed the pull request

[jira] [Commented] (STORM-1571) Improvment Kafka Spout Time Metric

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163607#comment-15163607 ] ASF GitHub Bot commented on STORM-1571: --- Github user knusbaum commented on the pull

[GitHub] storm pull request: [STORM-1571]Improvment Kafka Spout Time Metric

2016-02-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1143#issuecomment-188428153 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] storm pull request: [STORM-1571]Improvment Kafka Spout Time Metric

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1571) Improvment Kafka Spout Time Metric

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163700#comment-15163700 ] ASF GitHub Bot commented on STORM-1571: --- Github user asfgit closed the pull request

Storm recent build problems

2016-02-24 Thread Rodrigo Valladares
I was trying to build the current github version and run it to do some experiments with the new LoadAwareGrouping, but I am having some problems running topologies with it. Nimbus and supervisor start and from the UI you see workers and executors are all allocated, but no tuple is processed. I trie

[GitHub] storm pull request: [STORM-1488] fix broken component error times

2016-02-24 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/1129#issuecomment-188432892 > +1 the travis failure looks unrelated. Do you have a corresponding fix for master? I do not have a branch ready for master, but I can do that. The only conflictâ

[jira] [Commented] (STORM-1488) UI Topology Page component last error timestamp is from 1970

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163713#comment-15163713 ] ASF GitHub Bot commented on STORM-1488: --- Github user d2r commented on the pull reque

[jira] [Resolved] (STORM-1571) Improvment Kafka Spout Time Metric

2016-02-24 Thread Kyle Nusbaum (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyle Nusbaum resolved STORM-1571. - Resolution: Fixed Fix Version/s: 2.0.0 > Improvment Kafka Spout Time Metric > -

[jira] [Resolved] (STORM-1569) Allowing users to specify the nimbus thrift server queue size.

2016-02-24 Thread Kyle Nusbaum (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyle Nusbaum resolved STORM-1569. - Resolution: Fixed Fix Version/s: (was: 1.0.0) 2.0.0 > Allowing users

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188446369 @Parth-Brahmbhatt I merged this and resolved the jira, but the the jira's resolved version was listed as 1.0. I changed it to 2.0, but do we want to backport this to 1.

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188447027 @knusbaum I think we should. WE have see RejectedExecutionException on > 5 different customer clusters. I can backport this if others also agree. --- If your p

[jira] [Commented] (STORM-1569) Allowing users to specify the nimbus thrift server queue size.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163761#comment-15163761 ] ASF GitHub Bot commented on STORM-1569: --- Github user Parth-Brahmbhatt commented on t

[jira] [Commented] (STORM-1569) Allowing users to specify the nimbus thrift server queue size.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163760#comment-15163760 ] ASF GitHub Bot commented on STORM-1569: --- Github user knusbaum commented on the pull

[GitHub] storm pull request: [STORM-1488] fix broken component error times

2016-02-24 Thread d2r
Github user d2r closed the pull request at: https://github.com/apache/storm/pull/1129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] storm pull request: [STORM-1488] fix broken component error times

2016-02-24 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/1129#issuecomment-188452484 I saw an epoc date reported on the master branch when no errors had yet been reported. Defaulting the error time to `0` instead of the empty string may not be handled corre

Re: Storm recent build problems

2016-02-24 Thread Bobby Evans
the master branch has been going through a lot of changes lately.  We are in the process of merging with the JStorm project and as such we expect there to be some instability.  We are trying to keep the build so it continues to pass all tests and could be released if need be, but as expected wit

[jira] [Commented] (STORM-1488) UI Topology Page component last error timestamp is from 1970

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163799#comment-15163799 ] ASF GitHub Bot commented on STORM-1488: --- Github user d2r commented on the pull reque

[jira] [Commented] (STORM-1488) UI Topology Page component last error timestamp is from 1970

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163800#comment-15163800 ] ASF GitHub Bot commented on STORM-1488: --- Github user d2r closed the pull request at:

Re: Storm recent build problems

2016-02-24 Thread Bobby Evans
Inside the log for your worker it shows that you have the config "storm.zookeeper.port" 2000, Not sure where it came from, but it is in your config.  - Bobby On Wednesday, February 24, 2016 3:04 PM, Bobby Evans wrote: the master branch has been going through a lot of changes lately. 

[GitHub] storm pull request: STORM-1569: Adding option in nimbus to specify...

2016-02-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1144#issuecomment-188461160 @Parth-Brahmbhatt I'll just go ahead and merge it. It is a very small change and was already marked for 1.0. --- If your project is set up for it, you can reply to thi

[jira] [Commented] (STORM-1569) Allowing users to specify the nimbus thrift server queue size.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163842#comment-15163842 ] ASF GitHub Bot commented on STORM-1569: --- Github user knusbaum commented on the pull

[GitHub] storm pull request: [STORM-1488] fix broken component error times

2016-02-24 Thread d2r
GitHub user d2r reopened a pull request: https://github.com/apache/storm/pull/1129 [STORM-1488] fix broken component error times Note that the errorTime reported for the component/ path was previously in milliseconds, but the errorTime reported for the topology/ path was in seconds.

[GitHub] storm pull request: [STORM-1488] fix broken component error times

2016-02-24 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/1129#issuecomment-188477173 The last error time on the topology page for bolts and spouts is once again blank when no errors have been reported. --- If your project is set up for it, you can reply to

[jira] [Commented] (STORM-1488) UI Topology Page component last error timestamp is from 1970

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163905#comment-15163905 ] ASF GitHub Bot commented on STORM-1488: --- GitHub user d2r reopened a pull request:

[jira] [Commented] (STORM-1488) UI Topology Page component last error timestamp is from 1970

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163904#comment-15163904 ] ASF GitHub Bot commented on STORM-1488: --- Github user d2r commented on the pull reque

[jira] [Commented] (STORM-1488) UI Topology Page component last error timestamp is from 1970

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15164481#comment-15164481 ] ASF GitHub Bot commented on STORM-1488: --- GitHub user d2r opened a pull request:

[GitHub] storm pull request: [STORM-1488] fix broken component error times

2016-02-24 Thread d2r
GitHub user d2r opened a pull request: https://github.com/apache/storm/pull/1148 [STORM-1488] fix broken component error times See 1.x-branch PR #1129 You can merge this pull request into a Git repository by running: $ git pull https://github.com/d2r/storm storm-1488-master-err

[jira] [Created] (STORM-1574) Better exception handling in backpressure thread, and remove backpressure dir during topology kill.

2016-02-24 Thread Zhuo Liu (JIRA)
Zhuo Liu created STORM-1574: --- Summary: Better exception handling in backpressure thread, and remove backpressure dir during topology kill. Key: STORM-1574 URL: https://issues.apache.org/jira/browse/STORM-1574

[GitHub] storm pull request: [STORM-1574] Better handle backpressure thread...

2016-02-24 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/storm/pull/1149 [STORM-1574] Better handle backpressure thread exception & clear dir. 1. Better handle exception. 2. Remove topo dir during kill. 3. Add a unit test. You can merge this pull request into a G

[jira] [Commented] (STORM-1574) Better exception handling in backpressure thread, and remove backpressure dir during topology kill.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15165686#comment-15165686 ] ASF GitHub Bot commented on STORM-1574: --- GitHub user zhuoliu opened a pull request:

[GitHub] storm pull request: [STORM-1574] Better handle backpressure thread...

2016-02-24 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1149#issuecomment-188537244 +1 It looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[jira] [Commented] (STORM-1574) Better exception handling in backpressure thread, and remove backpressure dir during topology kill.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166442#comment-15166442 ] ASF GitHub Bot commented on STORM-1574: --- Github user hustfxj commented on the pull r

[GitHub] storm pull request: [STORM-1574] Better handle backpressure thread...

2016-02-24 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1149#issuecomment-188543268 Some Tests failed. It prompts tests can't find remove-backpressure!. I guess it generate some questions when it merge with master. --- If your project is set up for it

[jira] [Commented] (STORM-1574) Better exception handling in backpressure thread, and remove backpressure dir during topology kill.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166478#comment-15166478 ] ASF GitHub Bot commented on STORM-1574: --- Github user hustfxj commented on the pull r

[GitHub] storm pull request: [STORM-1254]: port ui.helper to java

2016-02-24 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1139#issuecomment-188543700 +1. It looks fairly good. Thank you @wuchong --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Commented] (STORM-1254) port backtype.storm.ui.helpers to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166483#comment-15166483 ] ASF GitHub Bot commented on STORM-1254: --- Github user hustfxj commented on the pull r

[GitHub] storm pull request: [STORM-1254]: port ui.helper to java

2016-02-24 Thread wuchong
Github user wuchong commented on the pull request: https://github.com/apache/storm/pull/1139#issuecomment-188546255 @revans2 It's a bug which has been fixed in #1119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (STORM-1254) port backtype.storm.ui.helpers to java

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166495#comment-15166495 ] ASF GitHub Bot commented on STORM-1254: --- Github user wuchong commented on the pull r

[GitHub] storm pull request: Documentation for cgroup support in Storm

2016-02-24 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/storm/pull/1054#discussion_r54042400 --- Diff: documentation/cgroups_in_storm.md --- @@ -0,0 +1,65 @@ +# CGroups in Storm + +CGroups are used by Storm to limit the resource usage of wo

[GitHub] storm pull request: [STORM-1574] Better handle backpressure thread...

2016-02-24 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/storm/pull/1149#discussion_r54043672 --- Diff: storm-core/test/jvm/org/apache/storm/utils/WorkerBackpressureThreadTest.java --- @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software F

[jira] [Commented] (STORM-1574) Better exception handling in backpressure thread, and remove backpressure dir during topology kill.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166643#comment-15166643 ] ASF GitHub Bot commented on STORM-1574: --- Github user wuchong commented on a diff in

[GitHub] storm pull request: [STORM-1574] Better handle backpressure thread...

2016-02-24 Thread wuchong
Github user wuchong commented on the pull request: https://github.com/apache/storm/pull/1149#issuecomment-188582664 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-1574) Better exception handling in backpressure thread, and remove backpressure dir during topology kill.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166645#comment-15166645 ] ASF GitHub Bot commented on STORM-1574: --- Github user wuchong commented on the pull r

Re: Storm recent build problems

2016-02-24 Thread Abhishek Agarwal
Robert, Running a topology in local mode launches in-process zookeeper which by default binds to 2000. https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/zookeeper/Zookeeper.java#L284 @Rodrigo It is possible that you are killing the local cluster just after you spawn i

[GitHub] storm pull request: [STORM-1574] Better handle backpressure thread...

2016-02-24 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1149#discussion_r54049182 --- Diff: storm-core/src/jvm/org/apache/storm/utils/WorkerBackpressureThread.java --- @@ -43,17 +48,33 @@ static public void notifyBackpressureCheck

[jira] [Commented] (STORM-1574) Better exception handling in backpressure thread, and remove backpressure dir during topology kill.

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166730#comment-15166730 ] ASF GitHub Bot commented on STORM-1574: --- Github user abhishekagarwal87 commented on

[jira] [Created] (STORM-1575) TwitterSampleSpout throws NPE on close

2016-02-24 Thread Manu Zhang (JIRA)
Manu Zhang created STORM-1575: - Summary: TwitterSampleSpout throws NPE on close Key: STORM-1575 URL: https://issues.apache.org/jira/browse/STORM-1575 Project: Apache Storm Issue Type: Bug

[GitHub] storm pull request: [STORM-1015] Allow Kafka offsets to be saved u...

2016-02-24 Thread hsun-cnnxty
Github user hsun-cnnxty commented on the pull request: https://github.com/apache/storm/pull/705#issuecomment-188634249 Just did another merge to keep it up to date with master branch. Not sure what the plan is now. I would be happy to make any changes that can help to make the final

[jira] [Commented] (STORM-1015) Store Kafka offsets with Kafka's consumer offset management api

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166804#comment-15166804 ] ASF GitHub Bot commented on STORM-1015: --- Github user hsun-cnnxty commented on the pu

[jira] [Updated] (STORM-1575) TwitterSampleSpout throws NPE on close

2016-02-24 Thread Manu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manu Zhang updated STORM-1575: -- Affects Version/s: 2.0.0 1.0.0 > TwitterSampleSpout throws NPE on close > ---

[GitHub] storm pull request: [STORM-1038] Upgraded netty to 4.x

2016-02-24 Thread hsun-cnnxty
Github user hsun-cnnxty commented on the pull request: https://github.com/apache/storm/pull/728#issuecomment-188640434 @revans2 Just merged code from master and seems there is performance degradation with recent changes. I noticed that it not only affects this branch, but al

  1   2   >