[jira] [Commented] (STORM-963) Frozen topology (KafkaSpout + Multilang bolt)

2016-03-04 Thread Kirill Prasalov (JIRA)
[ https://issues.apache.org/jira/browse/STORM-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181463#comment-15181463 ] Kirill Prasalov commented on STORM-963: --- Hi! I have the same. Storm v. 0. 9. 4. Pure

[jira] [Updated] (STORM-963) Frozen topology (KafkaSpout + Multilang bolt)

2016-03-04 Thread Kirill Prasalov (JIRA)
[ https://issues.apache.org/jira/browse/STORM-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirill Prasalov updated STORM-963: -- Attachment: jstack-bopcat.txt > Frozen topology (KafkaSpout + Multilang bolt) > -

[GitHub] storm pull request: STORM-1604:Delayed transition should handle No...

2016-03-04 Thread Parth-Brahmbhatt
GitHub user Parth-Brahmbhatt opened a pull request: https://github.com/apache/storm/pull/1188 STORM-1604:Delayed transition should handle NotALeaderException You can merge this pull request into a Git repository by running: $ git pull https://github.com/Parth-Brahmbhatt/incuba

[jira] [Commented] (STORM-1604) Delayed transition should handle NotALeaderException

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181326#comment-15181326 ] ASF GitHub Bot commented on STORM-1604: --- GitHub user Parth-Brahmbhatt opened a pull

[jira] [Created] (STORM-1604) Delayed transition should handle NotALeaderException

2016-03-04 Thread Parth Brahmbhatt (JIRA)
Parth Brahmbhatt created STORM-1604: --- Summary: Delayed transition should handle NotALeaderException Key: STORM-1604 URL: https://issues.apache.org/jira/browse/STORM-1604 Project: Apache Storm

[jira] [Commented] (STORM-1269) port backtype.storm.daemon.common to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180608#comment-15180608 ] ASF GitHub Bot commented on STORM-1269: --- Github user redsanket commented on the pull

[GitHub] storm pull request: [STORM-1269] port backtype.storm.daemon.common...

2016-03-04 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1185#issuecomment-192486048 upmerge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] storm pull request: STORM-1588: Do not add event logger details if...

2016-03-04 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1175#issuecomment-192418520 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-1588) component page gets divide by 0 if no event loggers configured

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180392#comment-15180392 ] ASF GitHub Bot commented on STORM-1588: --- Github user revans2 commented on the pull r

[jira] [Resolved] (STORM-1529) Change default worker temp directory location for workers

2016-03-04 Thread Kishor Patil (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kishor Patil resolved STORM-1529. - Resolution: Fixed Fix Version/s: 2.0.0 1.0.0 > Change default worker tem

[jira] [Commented] (STORM-1529) Change default worker temp directory location for workers

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180371#comment-15180371 ] ASF GitHub Bot commented on STORM-1529: --- Github user asfgit closed the pull request

[GitHub] storm pull request: [STORM-1529] Change default temp dir for worke...

2016-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1187 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1529) Change default worker temp directory location for workers

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180357#comment-15180357 ] ASF GitHub Bot commented on STORM-1529: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1529] Change default temp dir for worke...

2016-03-04 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1187#issuecomment-192406935 @kishorvpatil yes the build failures look like they need the changes I made to reduce the memory usage in travis. --- If your project is set up for it, you can reply to

[GitHub] storm pull request: [STORM-1529] Change default temp dir for worke...

2016-03-04 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1187#issuecomment-192405319 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-1529] Change default temp dir for worke...

2016-03-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/1187#issuecomment-192405669 The Travis CI build failure seems unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (STORM-1529) Change default worker temp directory location for workers

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180349#comment-15180349 ] ASF GitHub Bot commented on STORM-1529: --- Github user revans2 commented on the pull r

[jira] [Commented] (STORM-1529) Change default worker temp directory location for workers

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180350#comment-15180350 ] ASF GitHub Bot commented on STORM-1529: --- Github user kishorvpatil commented on the p

[GitHub] storm pull request: [STORM-1529] Change default temp dir for worke...

2016-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1087 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1529) Change default worker temp directory location for workers

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180292#comment-15180292 ] ASF GitHub Bot commented on STORM-1529: --- Github user asfgit closed the pull request

[GitHub] storm pull request: [STORM-1529] Change default temp dir for worke...

2016-03-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/1087#issuecomment-192388405 @revans2 @ptgoetz I created a separate Pull request for 1.x-branch as I can't merge ConfigUtils. #1187. Please review. --- If your project is set up for it,

[jira] [Commented] (STORM-1529) Change default worker temp directory location for workers

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180288#comment-15180288 ] ASF GitHub Bot commented on STORM-1529: --- Github user kishorvpatil commented on the p

[jira] [Commented] (STORM-1529) Change default worker temp directory location for workers

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180287#comment-15180287 ] ASF GitHub Bot commented on STORM-1529: --- GitHub user kishorvpatil opened a pull requ

[GitHub] storm pull request: [STORM-1529] Change default temp dir for worke...

2016-03-04 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/1187 [STORM-1529] Change default temp dir for workers to worker launch directory for 1.x branch You can merge this pull request into a Git repository by running: $ git pull https://github.com

[jira] [Commented] (STORM-1529) Change default worker temp directory location for workers

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180246#comment-15180246 ] ASF GitHub Bot commented on STORM-1529: --- Github user kishorvpatil commented on the p

[GitHub] storm pull request: [STORM-1529] Change default temp dir for worke...

2016-03-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/1087#issuecomment-192378480 Travis CI build failure is unrelated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Resolved] (STORM-1543) DRPCSpout should always try to reconnect disconnected DRPCInvocationsClient

2016-03-04 Thread Kishor Patil (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kishor Patil resolved STORM-1543. - Resolution: Fixed Fix Version/s: 2.0.0 1.0.0 > DRPCSpout should always t

[jira] [Commented] (STORM-1543) DRPCSpout should always try to reconnect disconnected DRPCInvocationsClient

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180232#comment-15180232 ] ASF GitHub Bot commented on STORM-1543: --- Github user asfgit closed the pull request

[GitHub] storm pull request: [STORM-1543] Always try to reconnect disconnec...

2016-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1529) Change default worker temp directory location for workers

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180202#comment-15180202 ] ASF GitHub Bot commented on STORM-1529: --- Github user ptgoetz commented on the pull r

[GitHub] storm pull request: [STORM-1529] Change default temp dir for worke...

2016-03-04 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1087#issuecomment-192370725 +1 for merging to both branches. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Updated] (STORM-1543) DRPCSpout should always try to reconnect disconnected DRPCInvocationsClient

2016-03-04 Thread Kishor Patil (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kishor Patil updated STORM-1543: Affects Version/s: 2.0.0 0.10.1 1.0.0

[GitHub] storm pull request: [STORM-1529] Change default temp dir for worke...

2016-03-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/1087#issuecomment-192368860 @revans2 @ptgoetz I have upmerged this again. I feel this is important fix to avoid letting workers write to /tmp and cause disk full issues. So we should put this

[jira] [Commented] (STORM-1529) Change default worker temp directory location for workers

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180192#comment-15180192 ] ASF GitHub Bot commented on STORM-1529: --- Github user kishorvpatil commented on the p

[jira] [Commented] (STORM-1561) Supervisor should relaunch worker if assignments have changed

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180162#comment-15180162 ] ASF GitHub Bot commented on STORM-1561: --- Github user kishorvpatil commented on the p

[GitHub] storm pull request: [STORM-1561] Supervisor should kill/restart if...

2016-03-04 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/1125#issuecomment-192362113 I merged this changed in both master and 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Resolved] (STORM-1561) Supervisor should relaunch worker if assignments have changed

2016-03-04 Thread Kishor Patil (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kishor Patil resolved STORM-1561. - Resolution: Fixed Fix Version/s: 2.0.0 1.0.0 > Supervisor should relaunc

[jira] [Updated] (STORM-1561) Supervisor should relaunch worker if assignments have changed

2016-03-04 Thread Kishor Patil (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kishor Patil updated STORM-1561: Affects Version/s: 2.0.0 1.0.0 > Supervisor should relaunch worker if assignm

[jira] [Resolved] (STORM-1528) Fix CsvPreparableReporter log directory

2016-03-04 Thread Kishor Patil (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kishor Patil resolved STORM-1528. - Resolution: Fixed Fix Version/s: 2.0.0 > Fix CsvPreparableReporter log directory >

[jira] [Updated] (STORM-1528) Fix CsvPreparableReporter log directory

2016-03-04 Thread Kishor Patil (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kishor Patil updated STORM-1528: Component/s: storm-core > Fix CsvPreparableReporter log directory >

[jira] [Commented] (STORM-1528) Fix CsvPreparableReporter log directory

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180140#comment-15180140 ] ASF GitHub Bot commented on STORM-1528: --- Github user asfgit closed the pull request

[jira] [Commented] (STORM-1561) Supervisor should relaunch worker if assignments have changed

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180141#comment-15180141 ] ASF GitHub Bot commented on STORM-1561: --- Github user asfgit closed the pull request

[GitHub] storm pull request: [STORM-1561] Supervisor should kill/restart if...

2016-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request: [STORM-1528] Fixing MetricsUtils csv directory...

2016-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1085 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1283) port backtype.storm.MockAutoCred to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180121#comment-15180121 ] ASF GitHub Bot commented on STORM-1283: --- Github user abhishekagarwal87 commented on

[GitHub] storm pull request: STORM-1283: port backtype.storm.MockAutoCred t...

2016-03-04 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1176#issuecomment-192350355 Thanks @revans2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Resolved] (STORM-1283) port backtype.storm.MockAutoCred to java

2016-03-04 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1283. Resolution: Fixed Fix Version/s: 2.0.0 Thanks [~abhishek.agarwal], I merged

[jira] [Commented] (STORM-1283) port backtype.storm.MockAutoCred to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180091#comment-15180091 ] ASF GitHub Bot commented on STORM-1283: --- Github user asfgit closed the pull request

[GitHub] storm pull request: STORM-1283: port backtype.storm.MockAutoCred t...

2016-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1283) port backtype.storm.MockAutoCred to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180043#comment-15180043 ] ASF GitHub Bot commented on STORM-1283: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1601] Check if /backpressure/storm-id n...

2016-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1181 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request: STORM-1283: port backtype.storm.MockAutoCred t...

2016-03-04 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1176#issuecomment-192330629 @abhishekagarwal87 actually I'll just do it as part of the check-in. There is no code change so it should be fine. --- If your project is set up for it, you can reply

[jira] [Resolved] (STORM-1601) Cluster-state must check if znode exists before getting children for storm backpressure

2016-03-04 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1601. Resolution: Fixed Fix Version/s: 1.0.0 Thanks [~kishorvpatil], I merged this

[jira] [Commented] (STORM-1601) Cluster-state must check if znode exists before getting children for storm backpressure

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180032#comment-15180032 ] ASF GitHub Bot commented on STORM-1601: --- Github user asfgit closed the pull request

[jira] [Commented] (STORM-1601) Cluster-state must check if znode exists before getting children for storm backpressure

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180033#comment-15180033 ] ASF GitHub Bot commented on STORM-1601: --- Github user asfgit closed the pull request

[GitHub] storm pull request: [STORM-1601] Check if /backpressure/storm-id z...

2016-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1283) port backtype.storm.MockAutoCred to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180022#comment-15180022 ] ASF GitHub Bot commented on STORM-1283: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: STORM-1283: port backtype.storm.MockAutoCred t...

2016-03-04 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1176#issuecomment-192325237 Please move MockAutoCred from `src/jvm/org/apache/storm` to `test/jvm/org/apache/storm`. The test still passes, and it was only put in the src directory because of prob

[jira] [Commented] (STORM-1601) Cluster-state must check if znode exists before getting children for storm backpressure

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180017#comment-15180017 ] ASF GitHub Bot commented on STORM-1601: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1601] Check if /backpressure/storm-id z...

2016-03-04 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1182#issuecomment-192324639 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-1601) Cluster-state must check if znode exists before getting children for storm backpressure

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180008#comment-15180008 ] ASF GitHub Bot commented on STORM-1601: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1601] Check if /backpressure/storm-id n...

2016-03-04 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1181#issuecomment-192318678 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: add private constructor to KafkaUtils

2016-03-04 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1186 add private constructor to KafkaUtils Since all of the methods and fields are static, I think it is a good idea to add a private constructor to KafkaUtils to avoid been constructed. You can merg

[GitHub] storm pull request: [STORM-1250]: port backtype.storm.serializatio...

2016-03-04 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1150#issuecomment-192307424 Just one minor comment. I am +1 even without the update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (STORM-1250) port backtype.storm.serialization-test to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179959#comment-15179959 ] ASF GitHub Bot commented on STORM-1250: --- Github user revans2 commented on a diff in

[jira] [Commented] (STORM-1250) port backtype.storm.serialization-test to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179965#comment-15179965 ] ASF GitHub Bot commented on STORM-1250: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1250]: port backtype.storm.serializatio...

2016-03-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1150#discussion_r55037499 --- Diff: storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java --- @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache Software Fou

[GitHub] storm pull request: [STORM-1252] port backtype.storm.stats to java

2016-03-04 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1147#issuecomment-192304011 @unsleepy22 I understand the desire to keep them compatible, and that is a decent first step, but one of the goals of this translation is to remove the clojure entirely

[jira] [Commented] (STORM-1252) port backtype.storm.stats to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179950#comment-15179950 ] ASF GitHub Bot commented on STORM-1252: --- Github user revans2 commented on the pull r

[jira] [Commented] (STORM-1252) port backtype.storm.stats to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179770#comment-15179770 ] ASF GitHub Bot commented on STORM-1252: --- Github user unsleepy22 commented on the pul

[GitHub] storm pull request: [STORM-1252] port backtype.storm.stats to java

2016-03-04 Thread unsleepy22
Github user unsleepy22 commented on the pull request: https://github.com/apache/storm/pull/1147#issuecomment-192244223 @revans2 I get your idea and you don't have to go through all of them, my initial thought was to keep it compatible with original clojure data structures, but I'm ok

[jira] [Commented] (STORM-1250) port backtype.storm.serialization-test to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179736#comment-15179736 ] ASF GitHub Bot commented on STORM-1250: --- Github user wuchong commented on the pull r

[GitHub] storm pull request: [STORM-1250]: port backtype.storm.serializatio...

2016-03-04 Thread wuchong
Github user wuchong commented on the pull request: https://github.com/apache/storm/pull/1150#issuecomment-192233525 @revans2 can you have a look ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-1269) port backtype.storm.daemon.common to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179622#comment-15179622 ] ASF GitHub Bot commented on STORM-1269: --- Github user abhishekagarwal87 commented on

[jira] [Commented] (STORM-1269) port backtype.storm.daemon.common to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179621#comment-15179621 ] ASF GitHub Bot commented on STORM-1269: --- Github user abhishekagarwal87 commented on

[GitHub] storm pull request: [STORM-1269] port backtype.storm.daemon.common...

2016-03-04 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1185#discussion_r55007994 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java --- @@ -0,0 +1,605 @@ +/** + * Licensed to the Apache Software Foundati

[GitHub] storm pull request: [STORM-1269] port backtype.storm.daemon.common...

2016-03-04 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1185#discussion_r55007937 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java --- @@ -0,0 +1,605 @@ +/** + * Licensed to the Apache Software Foundati

[jira] [Commented] (STORM-1269) port backtype.storm.daemon.common to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179619#comment-15179619 ] ASF GitHub Bot commented on STORM-1269: --- Github user abhishekagarwal87 commented on

[GitHub] storm pull request: [STORM-1269] port backtype.storm.daemon.common...

2016-03-04 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1185#discussion_r55007696 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java --- @@ -0,0 +1,605 @@ +/** + * Licensed to the Apache Software Foundati

[jira] [Commented] (STORM-1269) port backtype.storm.daemon.common to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179617#comment-15179617 ] ASF GitHub Bot commented on STORM-1269: --- Github user abhishekagarwal87 commented on

[GitHub] storm pull request: [STORM-1269] port backtype.storm.daemon.common...

2016-03-04 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1185#discussion_r55007490 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java --- @@ -0,0 +1,605 @@ +/** + * Licensed to the Apache Software Foundati

[jira] [Commented] (STORM-1269) port backtype.storm.daemon.common to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179616#comment-15179616 ] ASF GitHub Bot commented on STORM-1269: --- Github user abhishekagarwal87 commented on

[GitHub] storm pull request: [STORM-1269] port backtype.storm.daemon.common...

2016-03-04 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1185#discussion_r55007408 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java --- @@ -0,0 +1,605 @@ +/** + * Licensed to the Apache Software Foundati

[jira] [Commented] (STORM-1269) port backtype.storm.daemon.common to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179608#comment-15179608 ] ASF GitHub Bot commented on STORM-1269: --- Github user abhishekagarwal87 commented on

[GitHub] storm pull request: [STORM-1269] port backtype.storm.daemon.common...

2016-03-04 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1185#discussion_r55007255 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java --- @@ -0,0 +1,605 @@ +/** + * Licensed to the Apache Software Foundati

[jira] [Commented] (STORM-1269) port backtype.storm.daemon.common to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179604#comment-15179604 ] ASF GitHub Bot commented on STORM-1269: --- Github user abhishekagarwal87 commented on

[GitHub] storm pull request: [STORM-1269] port backtype.storm.daemon.common...

2016-03-04 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1185#discussion_r55006975 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java --- @@ -0,0 +1,605 @@ +/** + * Licensed to the Apache Software Foundati

[GitHub] storm pull request: [STORM-1269] port backtype.storm.daemon.common...

2016-03-04 Thread bastiliu
Github user bastiliu commented on a diff in the pull request: https://github.com/apache/storm/pull/1185#discussion_r55005929 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -2302,4 +2302,54 @@ public Object call() { public static long bitXor(Long a, Lo

[jira] [Commented] (STORM-1269) port backtype.storm.daemon.common to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179589#comment-15179589 ] ASF GitHub Bot commented on STORM-1269: --- Github user bastiliu commented on a diff in

[jira] [Commented] (STORM-1269) port backtype.storm.daemon.common to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179556#comment-15179556 ] ASF GitHub Bot commented on STORM-1269: --- Github user hustfxj commented on a diff in

[GitHub] storm pull request: [STORM-1269] port backtype.storm.daemon.common...

2016-03-04 Thread hustfxj
Github user hustfxj commented on a diff in the pull request: https://github.com/apache/storm/pull/1185#discussion_r55002193 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -2302,4 +2302,54 @@ public Object call() { public static long bitXor(Long a, Lon

[jira] [Commented] (STORM-1603) Storm UT fails on supervisor test in Windows (0.10.x)

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179553#comment-15179553 ] ASF GitHub Bot commented on STORM-1603: --- Github user hustfxj commented on a diff in

[GitHub] storm pull request: STORM-1603 Storm UT fails on supervisor test i...

2016-03-04 Thread hustfxj
Github user hustfxj commented on a diff in the pull request: https://github.com/apache/storm/pull/1183#discussion_r55001806 --- Diff: storm-core/test/clj/backtype/storm/supervisor_test.clj --- @@ -261,8 +260,8 @@ (str "-Dstorm.id=" mock-storm-id)

[jira] [Commented] (STORM-1269) port backtype.storm.daemon.common to java

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179542#comment-15179542 ] ASF GitHub Bot commented on STORM-1269: --- GitHub user bastiliu opened a pull request:

[GitHub] storm pull request: [STORM-1269] port backtype.storm.daemon.common...

2016-03-04 Thread bastiliu
GitHub user bastiliu opened a pull request: https://github.com/apache/storm/pull/1185 [STORM-1269] port backtype.storm.daemon.common to java 1. Following clojure defined records in common, "Assignment, StormBase, SupervisorInfo, ExecutorStats", were not migrated here. There are corr

[jira] [Commented] (STORM-1603) Storm UT fails on supervisor test in Windows (0.10.x)

2016-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179536#comment-15179536 ] ASF GitHub Bot commented on STORM-1603: --- Github user HeartSaVioR commented on a diff

[GitHub] storm pull request: STORM-1603 Storm UT fails on supervisor test i...

2016-03-04 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1183#discussion_r55000427 --- Diff: storm-core/test/clj/backtype/storm/supervisor_test.clj --- @@ -261,8 +260,8 @@ (str "-Dstorm.id=" mock-storm