[jira] [Commented] (STORM-1277) port backtype.storm.daemon.executor to java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401611#comment-15401611 ] ASF GitHub Bot commented on STORM-1277: --- Github user HeartSaVioR commented on a diff

[GitHub] storm pull request #1445: [STORM-1277] port backtype.storm.daemon.executor t...

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1445#discussion_r72930327 --- Diff: storm-core/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java --- @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache

[jira] [Commented] (STORM-1277) port backtype.storm.daemon.executor to java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401528#comment-15401528 ] ASF GitHub Bot commented on STORM-1277: --- Github user HeartSaVioR commented on a diff

[GitHub] storm pull request #1445: [STORM-1277] port backtype.storm.daemon.executor t...

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1445#discussion_r72924227 --- Diff: storm-core/src/jvm/org/apache/storm/executor/Executor.java --- @@ -0,0 +1,575 @@ +/** + * Licensed to the Apache Software Foundation (ASF

Re: [DISCUSSION] Policy of resolving dependencies for non storm-core modules

2016-07-31 Thread Jungtaek Lim
Not yet. It would be good to continue discussion on this thread for now. Thanks, Jungtaek Lim (HeartSaVioR) 2016년 8월 1일 (월) 오후 1:38, Satish Duggana 님이 작성: > Hi, > Did we find a way to comment on the proposal? How can we proceed with this > discussion? > > Thanks, > Satish. > > > On Thu, Jul 28,

[jira] [Commented] (STORM-2006) Storm metrics feature improvement: support per-worker level metrics aggregation

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401521#comment-15401521 ] ASF GitHub Bot commented on STORM-2006: --- Github user HeartSaVioR commented on the is

[GitHub] storm issue #1595: STORM-2006 Storm metrics feature improvement: support per...

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1595 @harshach The wish-list contains ideas/opinions in discussions on user@ and also dev@. http://mail-archives.apache.org/mod_mbox/storm-user/201604.mbox/%3CCAF5108iwhGgae7Z2AKgMVNP4P

Re: [DISCUSSION] Policy of resolving dependencies for non storm-core modules

2016-07-31 Thread Satish Duggana
Hi, Did we find a way to comment on the proposal? How can we proceed with this discussion? Thanks, Satish. On Thu, Jul 28, 2016 at 9:42 AM, Jungtaek Lim wrote: > I've made a design document for adding jars and maven artifacts at > submission. > Since we don't have any formats for this, I just

[jira] [Commented] (STORM-2003) Make sure config contains TOPIC before get it

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401514#comment-15401514 ] ASF GitHub Bot commented on STORM-2003: --- Github user satishd commented on a diff in

[GitHub] storm pull request #1590: [STORM-2003] Make sure config contains TOPIC befor...

2016-07-31 Thread satishd
Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/1590#discussion_r72922977 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -98,7 +98,11 @@ public void prepare(Map stormConf, TopologyContext c

[jira] [Commented] (STORM-1277) port backtype.storm.daemon.executor to java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401511#comment-15401511 ] ASF GitHub Bot commented on STORM-1277: --- Github user unsleepy22 commented on the iss

[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java

2016-07-31 Thread unsleepy22
Github user unsleepy22 commented on the issue: https://github.com/apache/storm/pull/1445 @HeartSaVioR your comments are addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1277) port backtype.storm.daemon.executor to java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401509#comment-15401509 ] ASF GitHub Bot commented on STORM-1277: --- Github user unsleepy22 commented on a diff

[GitHub] storm pull request #1445: [STORM-1277] port backtype.storm.daemon.executor t...

2016-07-31 Thread unsleepy22
Github user unsleepy22 commented on a diff in the pull request: https://github.com/apache/storm/pull/1445#discussion_r72922608 --- Diff: storm-core/test/clj/integration/org/apache/storm/integration_test.clj --- @@ -403,17 +403,18 @@ (def bolt-prepared? (atom false)) (defb

[jira] [Commented] (STORM-2003) Make sure config contains TOPIC before get it

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401501#comment-15401501 ] ASF GitHub Bot commented on STORM-2003: --- Github user harshach commented on the issue

[GitHub] storm issue #1590: [STORM-2003] Make sure config contains TOPIC before get i...

2016-07-31 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1590 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1595: STORM-2006 Storm metrics feature improvement: support per...

2016-07-31 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1595 @HeartSaVioR It will be good to have confluent wiki setup like other projects in apache do. We can have proposal setup there and go through the process of discussion in mailing list. I would start o

[jira] [Commented] (STORM-2006) Storm metrics feature improvement: support per-worker level metrics aggregation

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401500#comment-15401500 ] ASF GitHub Bot commented on STORM-2006: --- Github user harshach commented on the issue

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401495#comment-15401495 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[GitHub] storm issue #1586: STORM-1839: Storm spout implementation for Amazon Kinesis...

2016-07-31 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1586 @priyank5485 left couple of comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401496#comment-15401496 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on the issue

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-31 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72921532 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed to

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401494#comment-15401494 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-31 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72921486 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed to

[GitHub] storm pull request #1445: [STORM-1277] port backtype.storm.daemon.executor t...

2016-07-31 Thread unsleepy22
Github user unsleepy22 commented on a diff in the pull request: https://github.com/apache/storm/pull/1445#discussion_r72920746 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/Task.java --- @@ -179,23 +180,22 @@ public BuiltinMetrics getBuiltInMetrics() { private Topolo

[jira] [Commented] (STORM-1277) port backtype.storm.daemon.executor to java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401482#comment-15401482 ] ASF GitHub Bot commented on STORM-1277: --- Github user unsleepy22 commented on a diff

Re: Question about Storm UI

2016-07-31 Thread Alessandro Bellina
Sorry about that, attached on this email. The chart is pretty simple/bare bones. On Sunday, July 31, 2016 5:25 PM, Jungtaek Lim wrote: Inline image seems broken. Could you make it available? Regarding internal storage, below is what I observed from other projects while working with met

[jira] [Commented] (STORM-1435) Build a single jar with dependency for StormSQL dependency

2016-07-31 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401403#comment-15401403 ] Jungtaek Lim commented on STORM-1435: - Thanks for clarifying. Do you have something in

[DISCUSSION] Move out porting tests to after JStorm merger (Phase 3 or even 2.x)

2016-07-31 Thread Jungtaek Lim
Hi devs, Porting to Java seems to be longer than we expected, and now working on storm-core requires working for Java and Clojure, say twice. One of reason for port is "lowering learning curve to have more contributors", but now contributors need to know Clojure to contribute storm-core targeted f

[jira] [Closed] (STORM-1296) port backtype.storm.multilang-test to java and move out of storm-core

2016-07-31 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim closed STORM-1296. --- Resolution: Invalid We're removing multilang test so while it can be a new task, it's not a part of p

[jira] [Resolved] (STORM-1285) port backtype.storm.command.get-errors to java

2016-07-31 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1285. - Resolution: Fixed Fix Version/s: 2.0.0 Merged into master. > port backtype.storm.command.g

[GitHub] storm pull request #1597: STORM-1285 port backtype.storm.command.get-errors ...

2016-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1597 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1285) port backtype.storm.command.get-errors to java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401381#comment-15401381 ] ASF GitHub Bot commented on STORM-1285: --- Github user asfgit closed the pull request

[jira] [Resolved] (STORM-2010) port org.apache.storm.command.heartbeats.clj to Java

2016-07-31 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-2010. - Resolution: Fixed Fix Version/s: 2.0.0 Merged into master. > port org.apache.storm.command

[GitHub] storm pull request #1598: STORM-2010 port org.apache.storm.command.heartbeat...

2016-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-2010) port org.apache.storm.command.heartbeats.clj to Java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401379#comment-15401379 ] ASF GitHub Bot commented on STORM-2010: --- Github user asfgit closed the pull request

Re: Question about Storm UI

2016-07-31 Thread Jungtaek Lim
Inline image seems broken. Could you make it available? Regarding internal storage, below is what I observed from other projects while working with metrics. JStorm is using RocksDB in Nimbus to store metrics internally (only given time frame), and provide plugin to store metrics to external storag

Re: Question about Storm UI

2016-07-31 Thread Alessandro Bellina
HeartSaVIoR This is different than STORM-1994. By the way added some screenshots there to clarify. I agree it would be good to reorganize the statistics shown in the UI. Perhaps having two parts to this, one goes to a dashboard like Grafana, while the simpler metrics (snapshots, or aggregations

[jira] [Comment Edited] (STORM-1994) Add table with per-topology & worker resource usage and components in (new) supervisor and topology pages

2016-07-31 Thread Alessandro Bellina (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401199#comment-15401199 ] Alessandro Bellina edited comment on STORM-1994 at 7/31/16 4:01 PM:

[jira] [Updated] (STORM-1994) Add table with per-topology & worker resource usage and components in (new) supervisor and topology pages

2016-07-31 Thread Alessandro Bellina (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Bellina updated STORM-1994: -- Attachment: topology_page_worker_table.png > Add table with per-topology & worker resour

[jira] [Updated] (STORM-1994) Add table with per-topology & worker resource usage and components in (new) supervisor and topology pages

2016-07-31 Thread Alessandro Bellina (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Bellina updated STORM-1994: -- Attachment: supervisor_page_worker_table.png > Add table with per-topology & worker reso

[jira] [Updated] (STORM-1994) Add table with per-topology & worker resource usage and components in (new) supervisor and topology pages

2016-07-31 Thread Alessandro Bellina (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Bellina updated STORM-1994: -- Attachment: (was: screenshot-1.png) > Add table with per-topology & worker resource

[jira] [Commented] (STORM-1994) Add table with per-topology & worker resource usage and components in (new) supervisor and topology pages

2016-07-31 Thread Alessandro Bellina (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401199#comment-15401199 ] Alessandro Bellina commented on STORM-1994: --- I added a screenshot of the new sup

[jira] [Updated] (STORM-1994) Add table with per-topology & worker resource usage and components in (new) supervisor and topology pages

2016-07-31 Thread Alessandro Bellina (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Bellina updated STORM-1994: -- Attachment: screenshot-1.png > Add table with per-topology & worker resource usage and c

[jira] [Updated] (STORM-1994) Add table with per-topology & worker resource usage and components in (new) supervisor and topology pages

2016-07-31 Thread Alessandro Bellina (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Bellina updated STORM-1994: -- Attachment: (was: supervisor-page.png) > Add table with per-topology & worker resour

[jira] [Updated] (STORM-1994) Add table with per-topology & worker resource usage and components in (new) supervisor and topology pages

2016-07-31 Thread Alessandro Bellina (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Bellina updated STORM-1994: -- Attachment: supervisor-page.png > Add table with per-topology & worker resource usage an

[GitHub] storm issue #1598: STORM-2010 port org.apache.storm.command.heartbeats.clj t...

2016-07-31 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1598 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[jira] [Commented] (STORM-2010) port org.apache.storm.command.heartbeats.clj to Java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401196#comment-15401196 ] ASF GitHub Bot commented on STORM-2010: --- Github user satishd commented on the issue:

[jira] [Commented] (STORM-1285) port backtype.storm.command.get-errors to java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401195#comment-15401195 ] ASF GitHub Bot commented on STORM-1285: --- Github user satishd commented on the issue:

[GitHub] storm issue #1597: STORM-1285 port backtype.storm.command.get-errors to java

2016-07-31 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1597 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] storm issue #1395: storm-1726: use Put#addColumn to replace the deprecated P...

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1395 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[jira] [Commented] (STORM-1963) Replace Put add with addColumn

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401174#comment-15401174 ] ASF GitHub Bot commented on STORM-1963: --- Github user darionyaphet closed the pull re

[GitHub] storm pull request #1555: [Storm 1963] Replace Put add with addColumn

2016-07-31 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1555 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (STORM-1726) use Put#addColumn to replace the deprecated Put#add

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401175#comment-15401175 ] ASF GitHub Bot commented on STORM-1726: --- Github user darionyaphet commented on the i

[GitHub] storm issue #1555: [Storm 1963] Replace Put add with addColumn

2016-07-31 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1555 Yes It's duplicated with `STORM-1726` and I close this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[jira] [Commented] (STORM-1726) use Put#addColumn to replace the deprecated Put#add

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401172#comment-15401172 ] ASF GitHub Bot commented on STORM-1726: --- Github user HeartSaVioR commented on the is

[GitHub] storm issue #1555: [Storm 1963] Replace Put add with addColumn

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1555 Seems like it's duplicated with STORM-1726, and PR is submitted for that issue. Could you close this and also JIRA issue? --- If your project is set up for it, you can reply to this email a

[jira] [Resolved] (STORM-1594) org.apache.storm.tuple.Fields can throw NPE if given invalid field in selector

2016-07-31 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1594. - Resolution: Fixed Assignee: lujinhong Fix Version/s: 1.0.3 1.1.0

[GitHub] storm pull request #1522: [STORM-1594] org.apache.storm.tuple.Fields can thr...

2016-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1594) org.apache.storm.tuple.Fields can throw NPE if given invalid field in selector

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401169#comment-15401169 ] ASF GitHub Bot commented on STORM-1594: --- Github user asfgit closed the pull request

[jira] [Resolved] (STORM-1995) downloadChunk in nimbus.clj should close the input stream

2016-07-31 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1995. - Resolution: Fixed Assignee: Alessandro Bellina Fix Version/s: 1.0.3

[jira] [Commented] (STORM-1995) downloadChunk in nimbus.clj should close the input stream

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401159#comment-15401159 ] ASF GitHub Bot commented on STORM-1995: --- Github user asfgit closed the pull request

[GitHub] storm pull request #1593: STORM-1995: close input stream and other tweaks to...

2016-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #1601: 1.x branch

2016-07-31 Thread jayakrishnan-nair
GitHub user jayakrishnan-nair opened a pull request: https://github.com/apache/storm/pull/1601 1.x branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/storm 1.x-branch Alternatively you can review and apply these chang

[GitHub] storm pull request #1445: [STORM-1277] port backtype.storm.daemon.executor t...

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1445#discussion_r72901269 --- Diff: storm-core/test/clj/integration/org/apache/storm/integration_test.clj --- @@ -403,17 +403,18 @@ (def bolt-prepared? (atom false)) (def

[jira] [Commented] (STORM-1277) port backtype.storm.daemon.executor to java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401072#comment-15401072 ] ASF GitHub Bot commented on STORM-1277: --- Github user HeartSaVioR commented on a diff

[jira] [Commented] (STORM-1277) port backtype.storm.daemon.executor to java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401071#comment-15401071 ] ASF GitHub Bot commented on STORM-1277: --- Github user HeartSaVioR commented on a diff

[GitHub] storm pull request #1445: [STORM-1277] port backtype.storm.daemon.executor t...

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1445#discussion_r72901161 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/Task.java --- @@ -179,23 +180,22 @@ public BuiltinMetrics getBuiltInMetrics() { private Topol

[jira] [Commented] (STORM-1277) port backtype.storm.daemon.executor to java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401067#comment-15401067 ] ASF GitHub Bot commented on STORM-1277: --- Github user HeartSaVioR commented on the is

[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1445 @unsleepy22 Sure. I'll level another comment when I finish review for the first pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[jira] [Commented] (STORM-1277) port backtype.storm.daemon.executor to java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401065#comment-15401065 ] ASF GitHub Bot commented on STORM-1277: --- Github user HeartSaVioR commented on a diff

[GitHub] storm pull request #1445: [STORM-1277] port backtype.storm.daemon.executor t...

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1445#discussion_r72900809 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -2364,4 +2374,23 @@ public static long bitXor(Long a, Long b) { return r

[jira] [Resolved] (STORM-2009) port org.apache.storm.blobstore.clj and org.apache.storm.command.blobstore.clj to Java

2016-07-31 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-2009. - Resolution: Fixed Fix Version/s: 2.0.0 Merged into master. > port org.apache.storm.blobsto

[jira] [Commented] (STORM-2009) port org.apache.storm.blobstore.clj and org.apache.storm.command.blobstore.clj to Java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401060#comment-15401060 ] ASF GitHub Bot commented on STORM-2009: --- Github user asfgit closed the pull request

[GitHub] storm pull request #1599: STORM-2009 port org.apache.storm.blobstore.clj and...

2016-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-2010) port org.apache.storm.command.heartbeats.clj to Java

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401059#comment-15401059 ] ASF GitHub Bot commented on STORM-2010: --- Github user HeartSaVioR commented on the is

[GitHub] storm issue #1598: STORM-2010 port org.apache.storm.command.heartbeats.clj t...

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1598 Thanks @satishd @harshach for reviewing. Addressed or commented review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[jira] [Commented] (STORM-1038) Upgrade netty transport from 3.x to 4.x

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401057#comment-15401057 ] ASF GitHub Bot commented on STORM-1038: --- Github user HeartSaVioR commented on the is

[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1591 You can close and reopen this PR to retrigger. Btw, apache repository seems to be unstable recent days. I saw other build failures due to repository connectivity issue. --- If your project is s

[jira] [Commented] (STORM-2006) Storm metrics feature improvement: support per-worker level metrics aggregation

2016-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401048#comment-15401048 ] ASF GitHub Bot commented on STORM-2006: --- Github user HeartSaVioR commented on the is

[GitHub] storm issue #1595: STORM-2006 Storm metrics feature improvement: support per...

2016-07-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1595 @ptgoetz @harshach @abhishekagarwal87 I just had the limitations of current metrics feature only in my mind, but it would be better to write it down and share to persuade the need for new me