[GitHub] storm issue #1626: STORM-2016 Topology submission improvement: support addin...

2016-08-22 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1626 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Resolved] (STORM-2047) In secure setup the log page can't be viewed

2016-08-22 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-2047. - Resolution: Fixed Published. Marking as fixed. > In secure setup the log page can't be viewed > -

[jira] [Commented] (STORM-2047) In secure setup the log page can't be viewed

2016-08-22 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431884#comment-15431884 ] Jungtaek Lim commented on STORM-2047: - Thanks [~arunmahadevan], I merged the change to

[jira] [Updated] (STORM-2047) In secure setup the log page can't be viewed

2016-08-22 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-2047: Fix Version/s: 1.0.3 1.1.0 2.0.0 > In secure setup the log pag

[GitHub] storm pull request #1636: [STORM-2047] Add note to add logviewer hosts to br...

2016-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1636 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #1637: Fixed log message for credential renewal

2016-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1637 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #1637: Fixed log message for credential renewal

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1637 Thanks @juanpaulo I merged into master, 1.x, 1.0.x branches. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] storm issue #1554: adjusted Flux documentation to show new flux-wrapper libr...

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1554 Thanks @slava92 for the work. I merged into master, 1.x, 1.0.x branches. I'll address this change to the website soon. --- If your project is set up for it, you can reply to this email and ha

[GitHub] storm pull request #1554: adjusted Flux documentation to show new flux-wrapp...

2016-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #1602: Fix command to run RollingTopWords example

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1602 Thanks @Zintinio I merged into master, 1.x, 1.0.x branches. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] storm pull request #1602: Fix command to run RollingTopWords example

2016-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1602 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #1629: Fix code in KafkaSpoutRetryExponentialBackoff.java

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1629 Merged into master, 1.x, 1.0.x branches respectively. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #1629: Fix code in KafkaSpoutRetryExponentialBackoff.java

2016-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1629 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #1629: Fix code in KafkaSpoutRetryExponentialBackoff.java

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1629 +1 Thanks for the work @leedohyun --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] storm issue #1554: adjusted Flux documentation to show new flux-wrapper libr...

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1554 Sorry to review this lately. Nice catch. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] storm issue #1626: STORM-2016 Topology submission improvement: support addin...

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1626 Found forward reference in storm.thrift from STORM-1994. I just addressed that from here since generated files might bother us. Please check the change for `storm.thrift`. --- If your projec

[GitHub] storm issue #1608: STORM-2016 Topology submission improvement: support addin...

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1608 Changed module name as suggestion from pull request on master branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] storm issue #1626: STORM-2016 Topology submission improvement: support addin...

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1626 @satishd Addressed naming comments. I also modified 1.x PR for changing module name from storm-submit to storm-submit-tools. --- If your project is set up for it, you can reply to this email and

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-22 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1642 DO NOT MERGE: Please review STORM-2018: Supervisor V2. Still needs run as user and CGroup work, but the rest is working Any feedback on this would be welcome. I am particularly intereste

[GitHub] storm issue #1626: STORM-2016 Topology submission improvement: support addin...

2016-08-22 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1626 @HeartSaVioR I am fine with the proposed name changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] storm issue #1629: Fix code in KafkaSpoutRetryExponentialBackoff.java

2016-08-22 Thread leedohyun
Github user leedohyun commented on the issue: https://github.com/apache/storm/pull/1629 @HeartSaVioR Thank you for your review!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] storm issue #1602: Fix command to run RollingTopWords example

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1602 Example 1 and example 2 seems inconsistent. Good catch. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #1636: [STORM-2047] Add note to add logviewer hosts to browser w...

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1636 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] storm issue #1637: Fixed log message for credential renewal

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1637 +1 Nice catch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: Details about the Storm Scheduler

2016-08-22 Thread Bobby Evans
That is something that we have been thinking about for a while (elasticity in a topology).  There are a lot of obstacles to overcome, beyond just the scheduler.  1) The metrics feedback loop is far from ideal in being able to automatically detect a bottleneck.  Capacity kind of works, but the

[jira] [Commented] (STORM-1985) Provide a tool for showing and killing corrupted topology

2016-08-22 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430751#comment-15430751 ] Robert Joseph Evans commented on STORM-1985: I personally would prefer a tool

[jira] [Updated] (STORM-1985) Provide a tool for showing and killing corrupted topology

2016-08-22 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans updated STORM-1985: --- Assignee: Kamal > Provide a tool for showing and killing corrupted topology >

[jira] [Resolved] (STORM-2045) NPE in SpoutExecutor in 2.0 branch

2016-08-22 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-2045. - Resolution: Fixed Thanks [~Cody], I merged into master. > NPE in SpoutExecutor in 2.0 branch > --

[GitHub] storm pull request #1634: [STORM-2045] fixed SpoutExecutor NPE

2016-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1634 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #1406: [STORM-433] [WIP] Executor queue backlog metric

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1406 @abhishekagarwal87 Could I ask some questions regarding this: what points did you need to work further? It's needed for someone including me to take this up and reuse your work. --- If you

[GitHub] storm issue #1595: STORM-2006 Storm metrics feature improvement: support per...

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1595 Struggled with this but no luck. This is not that easy as just checking the interface type. 1. Entire logic is strongly tied to IMetricsConsumer and IMetricConsumer.DataPoint. Given that

[GitHub] storm issue #1406: [STORM-433] [WIP] Executor queue backlog metric

2016-08-22 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1406 @heartsavior unfortunately I havent done any further work. This feature needs some gauranteed time which I am not able to give. Anyone else wants to take it up and reuse my work, please do

[jira] [Commented] (STORM-1985) Provide a tool for showing and killing corrupted topology

2016-08-22 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430399#comment-15430399 ] Jungtaek Lim commented on STORM-1985: - [~bkamal] Thanks for working on this. Since Sto

[GitHub] storm issue #1629: Fix code in KafkaSpoutRetryExponentialBackoff.java

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1629 @leedohyun +1 for the change, and yes I also think it would be better to change like you stated since other parameters already use that method. Could you also change that thing? Thanks in

[GitHub] storm issue #1406: [STORM-433] [WIP] Executor queue backlog metric

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1406 @abhishekagarwal87 Any updates here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] storm issue #1608: STORM-2016 Topology submission improvement: support addin...

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1608 Rebased with current 1.x-branch again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] storm issue #1626: STORM-2016 Topology submission improvement: support addin...

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1626 Rebased with latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1634: [STORM-2045] fixed SpoutExecutor NPE

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1634 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[jira] [Resolved] (STORM-1994) Add table with per-topology & worker resource usage and components in (new) supervisor and topology pages

2016-08-22 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1994. - Resolution: Fixed Fix Version/s: 1.1.0 2.0.0 Thanks [~abellina] for the

[GitHub] storm pull request #1592: STORM-1994: Add table with per-topology and worker...

2016-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1592 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #1641: STORM-1994: Add table with per-topology and worker...

2016-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1641 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #1641: STORM-1994: Add table with per-topology and worker resour...

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1641 +1 Applied patch and confirmed it works as expected. @abellina Thanks for the work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] storm issue #1635: STORM-1434 Support the GROUP BY clause in StormSQL

2016-08-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1635 @harshach @haohui @arunmahadevan Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[jira] [Created] (STORM-2050) [storm-sql] Support User Defined Aggregate Function for Trident mode

2016-08-22 Thread Jungtaek Lim (JIRA)
Jungtaek Lim created STORM-2050: --- Summary: [storm-sql] Support User Defined Aggregate Function for Trident mode Key: STORM-2050 URL: https://issues.apache.org/jira/browse/STORM-2050 Project: Apache Stor