Strange behavior on MAP and ARRAY type

2016-09-23 Thread Jungtaek Lim
Hi devs, I'm experimenting with ARRAY and MAP type with Calcite's JaninoRexCompiler. (with Calcite 1.9.0) While testing I found some behaviors, so would like to see they're intentional or bugs we want to resolve. 1. Even though I set map's key/value type or array's type explicitly, compiler igno

[GitHub] storm pull request #1713: Storm 2124 show requested cpu mem for each compone...

2016-09-23 Thread abellina
GitHub user abellina opened a pull request: https://github.com/apache/storm/pull/1713 Storm 2124 show requested cpu mem for each component Work done by @jerrypeng at Yahoo. I tweaked the UI a bit. Most of the change is in the generated thrift code. You can merge this pull request i

[GitHub] storm pull request #1710: STORM-1546: Adding Read and Write Aggregations for...

2016-09-23 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1710#discussion_r80324279 --- Diff: storm-core/test/jvm/org/apache/storm/PaceMakerStateStorageFactoryTest.java --- @@ -20,13 +20,22 @@ import org.apache.storm.cluster.PaceMakerStateSt

[GitHub] storm pull request #1710: STORM-1546: Adding Read and Write Aggregations for...

2016-09-23 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1710#discussion_r80314321 --- Diff: conf/defaults.yaml --- @@ -276,6 +276,7 @@ resource.aware.scheduler.priority.strategy: "org.apache.storm.scheduler.resource dev.zookeeper.path: "/t

[GitHub] storm pull request #1710: STORM-1546: Adding Read and Write Aggregations for...

2016-09-23 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1710#discussion_r80323247 --- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/PacemakerClientHandler.java --- @@ -69,7 +69,7 @@ else if(evm instanceof HBMessage) { @Over

[GitHub] storm pull request #1710: STORM-1546: Adding Read and Write Aggregations for...

2016-09-23 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1710#discussion_r80321800 --- Diff: storm-core/src/jvm/org/apache/storm/cluster/PaceMakerStateStorage.java --- @@ -160,13 +179,23 @@ public void set_worker_hb(String path, byte[] data, Li

[GitHub] storm pull request #1710: STORM-1546: Adding Read and Write Aggregations for...

2016-09-23 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1710#discussion_r80319044 --- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/PacemakerClientPool.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1710: STORM-1546: Adding Read and Write Aggregations for...

2016-09-23 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1710#discussion_r80319682 --- Diff: storm-core/src/jvm/org/apache/storm/pacemaker/PacemakerClientPool.java --- @@ -0,0 +1,114 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1710: STORM-1546: Adding Read and Write Aggregations for...

2016-09-23 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1710#discussion_r80321976 --- Diff: storm-core/src/jvm/org/apache/storm/cluster/PaceMakerStateStorageFactory.java --- @@ -18,48 +18,22 @@ package org.apache.storm.cluster;

[GitHub] storm issue #1711: STORM-2123: Added ByteKeyValueScheme class.

2016-09-23 Thread asmaier
Github user asmaier commented on the issue: https://github.com/apache/storm/pull/1711 I created the JIRA ticket STORM-2123 and added an Apache license header. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

2016-09-23 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 Still have #1699 and #1712 to backport before this is ready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] storm issue #1712: STORM-2122: Cache dependency data, and serialize reading ...

2016-09-23 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1712 The travis failure here is an odd one, it looks like it failed because some integration tests that didn't run before are now running and took so long travis timed them out. --- If your project is s

[GitHub] storm pull request #1677: STORM-1985: Admin Commands

2016-09-23 Thread kamleshbhatt
Github user kamleshbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/1677#discussion_r80296458 --- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java --- @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1677: STORM-1985: Admin Commands

2016-09-23 Thread kamleshbhatt
Github user kamleshbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/1677#discussion_r80294599 --- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java --- @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1705: STORM-2117 Supervisor V2 with local mode extracts ...

2016-09-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #1677: STORM-1985: Admin Commands

2016-09-23 Thread kamleshbhatt
Github user kamleshbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/1677#discussion_r80293802 --- Diff: bin/storm.py --- @@ -572,6 +572,22 @@ def kill_workers(*args): jvmtype="-client", extrajars=[USER_CONF_DIR, os.path.jo

[GitHub] storm pull request #1710: STORM-1546: Adding Read and Write Aggregations for...

2016-09-23 Thread knusbaum
Github user knusbaum closed the pull request at: https://github.com/apache/storm/pull/1710 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] storm pull request #1710: STORM-1546: Adding Read and Write Aggregations for...

2016-09-23 Thread knusbaum
GitHub user knusbaum reopened a pull request: https://github.com/apache/storm/pull/1710 STORM-1546: Adding Read and Write Aggregations for Pacemaker to make it HA compatible You can merge this pull request into a Git repository by running: $ git pull https://github.com/knusba

[GitHub] storm issue #1699: STORM-2109: Treat Supervisor CPU/MEMORY Configs as Number...

2016-09-23 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1699 Rebased and addressed the review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] storm pull request #1699: STORM-2109: Treat Supervisor CPU/MEMORY Configs as...

2016-09-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1699#discussion_r80282664 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/timer/SupervisorHeartbeat.java --- @@ -72,10 +72,10 @@ private SupervisorInfo buildSupervisor

[GitHub] storm pull request #1711: Added ByteKeyValueScheme class.

2016-09-23 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/1711#discussion_r80280538 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/ByteKeyValueScheme.java --- @@ -0,0 +1,33 @@ +package org.apache.storm.kafka; --- End di

[GitHub] storm issue #1711: Added ByteKeyValueScheme class.

2016-09-23 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1711 @asmaier Could you create a JIRA ticket for this and update the title so it's prefixed with the JIRA ID? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #1691: STORM-2090: Add integration test for storm windowing

2016-09-23 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1691 @raghavgautam Nope. All is good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request #1712: STORM-2122: Cache dependency data, and serialize r...

2016-09-23 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1712 STORM-2122: Cache dependency data, and serialize reading of the data. You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm ST

[GitHub] storm issue #1654: STORM-2066: make error message in IsolatedPool.java more ...

2016-09-23 Thread jerrypeng
Github user jerrypeng commented on the issue: https://github.com/apache/storm/pull/1654 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] storm pull request #1711: Added ByteKeyValueScheme class.

2016-09-23 Thread asmaier
GitHub user asmaier opened a pull request: https://github.com/apache/storm/pull/1711 Added ByteKeyValueScheme class. It is a common use case to send and receive byte key and values via Kafka. Unfortunately the storm-kafka package misses support for this. So I added a ByteKeyValueSc

[GitHub] storm pull request #1710: STORM-1546: Adding Read and Write Aggregations for...

2016-09-23 Thread knusbaum
GitHub user knusbaum opened a pull request: https://github.com/apache/storm/pull/1710 STORM-1546: Adding Read and Write Aggregations for Pacemaker to make it HA compatible You can merge this pull request into a Git repository by running: $ git pull https://github.com/knusbaum