[GitHub] storm pull request #1862: STORM-2278: Allow max number of disruptor queue fl...

2017-01-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1862 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1861: STORM-2277: Support given for storm-druid connecto...

2017-01-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1861 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1861: STORM-2277: Support given for storm-druid connector shade...

2017-01-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1861 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1862: STORM-2278: Allow max number of disruptor queue flusher t...

2017-01-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1862 +1 Thanks for the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1869: STORM-2279: Unable to open bolt page of storm ui

2017-01-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1869 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1870: STORM-2279: Unable to open bolt page of storm ui

2017-01-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1870 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1862: STORM-2278: Allow max number of disruptor queue flusher t...

2017-01-09 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1862 @HeartSaVioR I rebased and I think I addressed your review comments. Please have a look and see if it is what you wanted. --- If your project is set up for it, you can reply to this email and have

[GitHub] storm issue #1866: STORM-2279: Unable to open bolt page of storm ui

2017-01-09 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1866 @HeartSaVioR Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm pull request #1870: STORM-2279: Unable to open bolt page of storm ui

2017-01-09 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1870 STORM-2279: Unable to open bolt page of storm ui I have added logic to wrap the negative indexes around effectively giving it a python like behaviour. Same as pull #1866 You can merge

[GitHub] storm pull request #1869: STORM-2279: Unable to open bolt page of storm ui

2017-01-09 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1869 STORM-2279: Unable to open bolt page of storm ui I have added logic to wrap the negative indexes around effectively giving it a python like behaviour. Same as pull #1866 You can merge

[GitHub] storm issue #1808: STORM-2225: change spout config to be simpler.

2017-01-09 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1808 All outstanding review comments should be done now. This and the 1.x port at #1868 should be ready for a final pass and hopefully being merged in. --- If your project is set up for it, you can

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

2017-01-09 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1868 This is the 1.x version of #1808 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request #1868: STORM-2225: change spout config to be simpler. (1....

2017-01-09 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1868 STORM-2225: change spout config to be simpler. (1.x) You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-2225-1.x

[GitHub] storm pull request #1862: STORM-2278: Allow max number of disruptor queue fl...

2017-01-09 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1862#discussion_r95174977 --- Diff: storm-core/src/jvm/org/apache/storm/utils/DisruptorQueue.java --- @@ -63,6 +63,18 @@ private static final String PREFIX = "disruptor-";

Re: Mark DRPC as deprecated

2017-01-09 Thread Bobby Evans
I wrote the ForwardingMetricsConsumer for some performance tests.  It does work, I just didn't really test it all that well and don't feel comfortable with its stability.  If others want to try and harden it they are welcome to, but we are also in the process of redesigning how metrics work to

[GitHub] storm pull request #1862: STORM-2278: Allow max number of disruptor queue fl...

2017-01-09 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1862#discussion_r95169637 --- Diff: storm-core/src/jvm/org/apache/storm/utils/DisruptorQueue.java --- @@ -63,6 +63,18 @@ private static final String PREFIX = "disruptor-";