[GitHub] storm issue #2032: [STORM-2093] Fix permissions in multi-tenant, secure mode

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2032 @ppoulosk There's compilation error on Travis build. Could you check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #2038: STORM-2450: Write resources into correct local directory

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2038 +1 Nice finding. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #2034: STORM-2441 Break down 'storm-core' to extract client (wor...

2017-04-01 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2034 @HeartSaVioR Yes I gave these changes a +1 because they were as good as I could expect without having storm server removed completely from the storm jar classpath. To make that happen we really had

[GitHub] storm issue #2034: STORM-2441 Break down 'storm-core' to extract client (wor...

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2034 @revans2 I just saw you also address 'storm-clojure' to refer 'storm-client' in STORM-2447. Nice work. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm issue #2034: STORM-2441 Break down 'storm-core' to extract client (wor...

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2034 @revans2 We didn't address origin concern, dependencies issue. This patch doesn't relocate everything so it would be a regression for many users. I'd like to get it resolved before

[GitHub] storm issue #2034: STORM-2441 Break down 'storm-core' to extract client (wor...

2017-04-01 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2034 Just to let you know that I have been working on making local mode transparent. I have it working, but I have a lot of work to do on the examples and docs left.

[GitHub] storm pull request #2038: STORM-2450: Write resources into correct local dir...

2017-04-01 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2038 STORM-2450: Write resources into correct local directory You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-2450

[GitHub] storm issue #1943: [STORM-2363]Provide configuration to set the number of Ro...

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1943 @liu-zhaokun Let's close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1949: STORM-1290: port backtype.storm.local-state-test to java

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1949 @kamleshbhatt Any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1963: STORM-2380 worker.childopts with whitespace inside one pa...

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1963 @nilday Any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm pull request #1970: STORM-2383 Support HBase as state backend (1.x)

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1970#discussion_r109284284 --- Diff: external/storm-hbase/src/main/java/org/apache/storm/hbase/state/HBaseKeyValueState.java --- @@ -0,0 +1,399 @@ +/* + * Licensed to the

[GitHub] storm issue #2023: STORM-2429: Properly validate supervisor.scheduler.meta

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2023 +1 Nice catch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #2033: [STORM-2431]the default blobstore.dir is storm.local.dir/...

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2033 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #2035: [STORM-2442]modify the Usage Examples in storm-kafka-clie...

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2035 +1 Nice catch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #2036: [DEV-2440] Prevent KafkaSpout from hanging under certain ...

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2036 Please also change title to STORM-2440 instead of DEV-2440. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request #2036: [DEV-2440] Prevent KafkaSpout from hanging under c...

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2036#discussion_r109283834 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -267,9 +267,11 @@ ((:report-error <>) error)

[GitHub] storm pull request #2037: [STORM-2363] Provide configuration to set the numb...

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2037#discussion_r109283335 --- Diff: storm-core/src/jvm/org/apache/storm/stats/BoltExecutorStats.java --- @@ -36,8 +36,8 @@ public static final String PROCESS_LATENCIES =

[GitHub] storm pull request #2037: [STORM-2363] Provide configuration to set the numb...

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2037#discussion_r109283324 --- Diff: storm-core/src/jvm/org/apache/storm/stats/CommonStats.java --- @@ -37,7 +36,7 @@ protected final int rate; protected final

[GitHub] storm pull request #2037: [STORM-2363] Provide configuration to set the numb...

2017-04-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2037#discussion_r109283329 --- Diff: storm-core/src/jvm/org/apache/storm/stats/SpoutExecutorStats.java --- @@ -30,8 +30,8 @@ public static final String FAILED = "failed";