[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r128156078 --- Diff: docs/Windowing.md --- @@ -266,3 +266,105 @@ tuples can be received within the timeout period. An example toplogy `SlidingWindowTopology`

[GitHub] storm pull request #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly c...

Github user askprasanna closed the pull request at: https://github.com/apache/storm/pull/2217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...

Github user askprasanna commented on the issue: https://github.com/apache/storm/pull/2217 Closing the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2217 Merged via 6cfcbeef4cd2da9f601687966aa08f6b75e41597 @askprasanna I can't use Github automatic close because this PR is not against master branch. Could you close this PR? Thanks in

[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2217 Let's just reword the commit title while merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2208 OK now I'm seeing how it works... From topology side it's always set to "digest" from Storm Submitter, so it is not effectively configurable from topology level. From Daemon

[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2208 @liu-zhaokun I didn't mean we should replace configuration with normal string. I meant if the value is constant, don't add it to Storm configuration (even config map) and use the constant value

[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @harshach It has always been the case.In other words,the value of this configuration is digest all the time.You can see StormSubmitter.java,line 92.It doesn't matter even that is in case

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 1. I believe I tested it from binary distribution. I used "mvn clean install" to compile and "cd storm-dist/binary && mvn package" to created the binary distribution. And then I deployed it under

[GitHub] storm issue #2223: STORM-2541: Fix manual partition assignment (1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2223 +1 I'm OK to break the API if it didn't work anyway. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #2222: [STORM-2133] add page-rendered-at timestamp on the UI

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/ +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 @Ethanlm > 1. "Prev" "First" etc buttons seems to mix together. (On non-secure and secure cluster) Looks like failing to load css and also js file. We don't include static resource

[GitHub] storm issue #2174: STORM-2554: Trident Kafka Spout Refactoring to Include Ma...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2174 @hmcl Sorry for not looking at this earlier, I thought it made sense to finish up 2541 first. Could you fix the conflicts? Then I'd be happy to help review :) --- If your project is set up for it,

[GitHub] storm pull request #2150: STORM-2541: Fix storm-kafka-client manual subscrip...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Release Planning for 1.1.1 and others?

Those some of the one’s I’ve been tracking for 1.1.1. I’ll do another run through JIRA to see if there’s anything else pending that needs to be included. I would encourage others to do so as well. -Taylor > On Jul 18, 2017, at 2:27 PM, Hugo Da Cruz Louro > wrote: >

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 I did some simple tests manually in non-secure and secure storm cluster. It seems that it works well on non-secure storm cluster except some display issues. I found some issues on secure storm

Re: Release Planning for 1.1.1 and others?

Hi Jungtaek, Currently there are 2 critical bugs and no blocker bugs. https://issues.apache.org/jira/browse/STORM-2342- I still need to investigate it. It may or may not be a bug. It is a bit surprising that such basic functionality is not working.

[GitHub] storm issue #2220: STORM-2638: Add in maximum object size for Pacemaker Thri...

Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/2220 @vesense Agreed. How do I run the linter? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #2223: STORM-2541: Fix manual partition assignment (1.x)

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2223 The only change from the master version is replacing String.join with StringUtils.join in the topic filters. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request #2223: STORM-2541: Fix manual partition assignment (1.x)

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2223 STORM-2541: Fix manual partition assignment (1.x) Same as https://github.com/apache/storm/pull/2150, but for 1.x. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm issue #2222: [STORM-2133] add page-rendered-at timestamp on the UI

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/ The timestamp at the bottom of the page. https://user-images.githubusercontent.com/14900612/28331368-5f590b9a-6bb6-11e7-8f66-b17f23e79276.png;> --- If your project is set up for it, you

[GitHub] storm pull request #2222: [STORM-2133] add page-rendered-at timestamp on the...

GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/ [STORM-2133] add page-rendered-at timestamp on the UI As a user, I would like a simple timestamp of when a UI page was rendered, so that, I can quickly check if the information is fresh. This

[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2208 @HeartSaVioR wouldn't that be an issue incase of non-secure cluster if we are defaulting to "digest"? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request #2215: STORM-2548: Simplify KafkaSpoutConfig (1.x)

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2155: STORM-2548: Simplify KafkaSpoutConfig to avoid duplicatin...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2155 Thanks for the reviews everyone. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request #2155: STORM-2548: Simplify KafkaSpoutConfig to avoid dup...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2156: STORM-2549: Fix broken enforcement mechanism for maxUncom...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2156 @srdo I am doing one last review of this patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #2221: STORM-2544: [1.x-branch] Fixing issue in acking of tuples...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2221 @bharathguvvala Thanks for the fix. The commit doesn't apply cleanly to 1.0.x-branch, so please open another PR if you'd like it to go on that branch as well. --- If your project is set up for it,

[GitHub] storm pull request #2221: STORM-2544: [1.x-branch] Fixing issue in acking of...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2221 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2217 @askprasanna Could I get you to update the commit message to reflect the current JIRA number? I checked if this would go on 1.0.x unmodified as well, but 1.0.x was before we added the OffsetManager

Re: Release Planning for 1.1.1 and others?

I think a month seems realistic, yes. Thanks for clarifying when it is okay to skip the waiting period. 2017-07-18 13:44 GMT+02:00 Jungtaek Lim : > Thanks for following up Stig. > > According to your explanation, only a few issues are left for bug fix. I > feel they could be

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r127958478 --- Diff: docs/Windowing.md --- @@ -266,3 +266,105 @@ tuples can be received within the timeout period. An example toplogy `SlidingWindowTopology`

Re: Release Planning for 1.1.1 and others?

Thanks for following up Stig. According to your explanation, only a few issues are left for bug fix. I feel they could be resolved around a month, and then we can track them as epic issue from now on, and release once they're resolved. Make sense? Btw, if my understanding is right, you don't

Re: Release Planning for 1.1.1 and others?

Hi Jungtaek, I think we're not too far off for most of the issues I'm aware of. I'd like to get some fixes around topic compaction ( https://github.com/apache/storm/pull/2221 and https://github.com/apache/storm/pull/2217) in for 1.1.1. They should be mergeable once the 24 hour period has passed.

[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2217 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #2218: STORM-2614: Enhance stateful windowing to persist the win...

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2218 This builds on top of the existing state checkpointing mechanism (documented here - https://github.com/apache/storm/blob/master/docs/State-checkpointing.md). Theres nothing extra added to the

[GitHub] storm issue #2217: STORM-2639: [1.x-branch] Kafka Spout incorrectly computes...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2217 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2152: STORM-2639: Kafka Spout incorrectly computes numCo...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2152: STORM-2639: Kafka Spout incorrectly computes numCommitted...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2152 +1 again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #2221: STORM-2544: [1.x-branch] Fixing issue in acking of tuples...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2221 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2153: STORM-2544: Fixing issue in acking of tuples that hit ret...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2153 Thanks @askprasanna. Will merge the 1.x version as soon as possible (there's a 24 hour waiting period) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request #2153: STORM-2544: Fixing issue in acking of tuples that ...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2209: [STORM-2622] Add owner resource summary on storm U...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2153: STORM-2544: Fixing issue in acking of tuples that hit ret...

Github user askprasanna commented on the issue: https://github.com/apache/storm/pull/2153 Created PR https://github.com/apache/storm/pull/2221 for 1.x-branch (cc @bharathguvvala) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request #2221: STORM-2544: [1.x-branch] Fixing issue in acking of...

GitHub user bharathguvvala opened a pull request: https://github.com/apache/storm/pull/2221 STORM-2544: [1.x-branch] Fixing issue in acking of tuples that hit retry limit under manual commit mode You can merge this pull request into a Git repository by running: $ git pull

Re: Connection refused

Nimbus worked well . The error disappeared after restart machine !! Every time I got this error . It disappeared after restarting . Although I cleaned logs files and /var/ storm the extension of storm.local.dir On Tuesday, July 18, 2017, Li Wang wrote: > Make sure the